From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184517929381134336 X-Received: by 2002:a05:6870:1117:b0:163:255f:3571 with SMTP id 23-20020a056870111700b00163255f3571mr302026oaf.268.1674649637704; Wed, 25 Jan 2023 04:27:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6808:15a1:b0:36e:f65b:9754 with SMTP id t33-20020a05680815a100b0036ef65b9754ls1651941oiw.5.-pod-prod-gmail; Wed, 25 Jan 2023 04:27:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXu71oZ94rPq2zh31K8+Xaa3+NdJHpb6iNgHU8oMW6CA8bEhoTi1O2UPBgsFSeIL8qTOjBMM X-Received: by 2002:a05:6808:1310:b0:364:ba36:78f4 with SMTP id y16-20020a056808131000b00364ba3678f4mr18922534oiv.13.1674649637171; Wed, 25 Jan 2023 04:27:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674649637; cv=none; d=google.com; s=arc-20160816; b=NKNb9UT4/9ULNbr7vw0BLzW47YNCv/6rrT+b24pT7asx93osFqrftzS6VSZ12GTnIV z270R8yOdLpEwDeCqwlqpuHRZEgmFRN7DejjnI499AA8qBZcNpHwSF8PneqWQcBqB40q w9PWP+6TyI68ENS/mSq0BBY6+efw/scK3MMa9UhyGCeeDlxv+JfqXyo4ED/v4tk35xgn urSbdG+m1auHBk13y28q1mv3rpS6fCkzLjZdxh7CFBGm0N3VsnjLiy0BAk4Jw3/fIPl/ b3q1OT6QwKOpgauydOCrGue4n0qkROcBeoPL8F7ZQyIJjgK9rsoSxuExyG1S/txePQ7M UEsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Z3Xs7pB20GrZqCAMyYzEcXSrVOH1xHkzmA9ygipV01Q=; b=t+sauMaQ/eE7lLBMzWbVAgTd6yegndmZBy62d0KhPMubKFnMcer6Sgucp9NzEnZzZZ y7oH1GdQgwcNKWcMtWmBVqajcsUBy4v7ZPozyOJxSFFzK6dxkG7y1XJBg09hT1LZZ+pE X9rqVDFnGazTnMf5mjRxcDZBmg4m370kXBrnN12UwL/46285A8tqBZHtDhn3R6UIor1I 0R5WnS/bDDxBSvLa4Dm2jR1kEB/Pxao3NWGNCtJzN4829MsKCMfucDuDn7AaaNtv3pPQ Iz466Qo4ZCho8JZpHS1iz419hW1yZM1sYkTNhQemrKmoleM6O3RL38HeqxYDoPnquyXX E8pQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id cy23-20020a056830699700b0067054a075b7si948248otb.2.2023.01.25.04.27.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jan 2023 04:27:17 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from hp.localnet (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 30PCRChQ026822 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 13:27:13 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com Cc: "Roberto A. Foglietta" Subject: Re: [PATCH] dpkg class sbuild allows extra arguments by vars Date: Wed, 25 Jan 2023 15:27:09 +0300 Message-ID: <2176963.hkbZ0PkbqX@hp> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: jltcHSuQ8iCc In mail from Tuesday, 3 January 2023 22:58:15 +03 user Roberto A. Foglietta wrote: > Hi all, > > Sometimes it is necessary to add some extra commands or arguments to sbuild > but create a class into an upper layer just for this breaks the updates. > So, this patch allows setting extra parameters through two variables. > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/dpkg.bbclass | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > https://github.com/ilbers/isar/commit/7e72921747aedf588af492be95fb0b91ad70f4 > 55 Can't respond on specific line in the patch due to attachment form, but it would be better not to modify existing lines but just add new ones, like: --no-apt-update \ + ${DPKG_SBUILD_EXTRA_ARGS_PRE} \ --chroot-setup-commands=... It's a bit more readable. At first glance I wrongly tried to understand how it's related to "--no-apt- update" and "--debbuildopts"... :) You could send v2 or I can modify it on my side while testing / merging.