Re: [PATCH] linux-custom: Install config and map file to /boot

[vijai kumar <vijaikumar.kanagarajan@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3619 bytes --]



On Friday, April 3, 2020 at 12:58:46 PM UTC+5:30, vijai kumar wrote:
>
>
>
> On Wednesday, March 25, 2020 at 12:37:12 PM UTC+5:30, 
> cedric_h...@mentor.com wrote:
>>
>>
>>
>> On Tuesday, March 17, 2020 at 6:40:01 PM UTC+1, Jan Kiszka wrote:
>>>
>>> On 17.03.20 18:19, vijai kumar wrote: 
>>> > I am not sure how to test the um use case in kernel in ISAR. Are there 
>>> > any specific targets in ISAR that I am missing? 
>>> > 
>>>
>>> I don't think we had a um use case so far, so there might be things 
>>> silently broken. Not sure if Cedric tested the um special handling, I 
>>> surely didn't. 
>>>
>>
>> used "um" for another project (and without Isar).
>> I would recommend we don't bother with it as far as Isar is concerned 
>> until we get a request for it
>>
>
> Thank you for your input Cedric.
>


If there are no more review comments, can this be merged?

Thanks,
Vijai Kumar K
 

>  
>
>>
>>
>>> Jan 
>>>
>>> > Thanks, 
>>> > Vijai Kumar K 
>>> > 
>>> > On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: 
>>> > 
>>> >     Align with upstream debian linux-image package. Install the config 
>>> and 
>>> >     System.map file to /boot directory. Skip installation for User 
>>> Mode 
>>> >     Linux. 
>>> > 
>>> >     Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com 
>>> >     <mailto:Vijaikumar_Kanagarajan@mentor.com>> 
>>> >     --- 
>>> >       .../linux/files/debian/isar/install.tmpl           | 14 
>>> >     ++++++++++++++ 
>>> >       1 file changed, 14 insertions(+) 
>>> > 
>>> >     diff --git 
>>> >     a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl 
>>> >     b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl 
>>> >     index 12d592d..4e1f850 100644 
>>> >     --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl 
>>> >     +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl 
>>> >     @@ -37,6 +37,8 @@ do_install() { 
>>> >           set -x 
>>> > 
>>> >           install_image 
>>> >     +    install_config 
>>> >     +    install_map 
>>> >           install_hooks 
>>> >           install_dtbs 
>>> >           install_kmods 
>>> >     @@ -69,6 +71,18 @@ install_image() { 
>>> >           install_image_debug 
>>> >       } 
>>> > 
>>> >     +install_config() { 
>>> >     +    if [ "${ARCH}" != "um" ]; then 
>>> >     +        cp ${O}/.config ${deb_img_dir}/$(dirname 
>>> >     ${kimage_path})/config-${krel} 
>>> >     +    fi 
>>> >     +} 
>>> >     + 
>>> >     +install_map() { 
>>> >     +    if [ "${ARCH}" != "um" ]; then 
>>> >     +        cp ${O}/System.map ${deb_img_dir}/$(dirname 
>>> >     ${kimage_path})/System.map-${krel} 
>>> >     +    fi 
>>> >     +} 
>>> >     + 
>>> >       install_image_debug() { 
>>> >           # Different tools want the image in different locations 
>>> >           # perf 
>>> >     -- 
>>> >     2.17.1 
>>> > 
>>> > -- 
>>> > You received this message because you are subscribed to the Google 
>>> > Groups "isar-users" group. 
>>> > To unsubscribe from this group and stop receiving emails from it, send 
>>> > an email to isar-...@googlegroups.com 
>>> > <mailto:isar-users+unsubscribe@googlegroups.com>. 
>>> > To view this discussion on the web visit 
>>> > 
>>> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com 
>>> > <
>>> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com?utm_medium=email&utm_source=footer>. 
>>>
>>>
>>>
>>> -- 
>>> Siemens AG, Corporate Technology, CT RDA IOT SES-DE 
>>> Corporate Competence Center Embedded Linux 
>>>
>>

[-- Attachment #1.2: Type: text/html, Size: 6254 bytes --]