From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 Date: Fri, 3 Apr 2020 00:29:26 -0700 (PDT) From: vijai kumar To: isar-users Message-Id: <21aa7d8b-3445-4268-b26b-96e8ae8e9a18@googlegroups.com> In-Reply-To: References: <20200317171455.17840-1-Vijaikumar_Kanagarajan@mentor.com> <7d0d4cc5-149e-48f9-8391-23d324df6490@googlegroups.com> Subject: Re: [PATCH] linux-custom: Install config and map file to /boot MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_682_983819135.1585898966286" X-Google-Token: ENbLm_QFEsFh9WvYqq40 X-Google-IP: 192.94.34.34 X-TUID: vhGIzJ5NKJpT ------=_Part_682_983819135.1585898966286 Content-Type: multipart/alternative; boundary="----=_Part_683_1728416111.1585898966286" ------=_Part_683_1728416111.1585898966286 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Friday, April 3, 2020 at 12:58:46 PM UTC+5:30, vijai kumar wrote: > > > > On Wednesday, March 25, 2020 at 12:37:12 PM UTC+5:30, > cedric_h...@mentor.com wrote: >> >> >> >> On Tuesday, March 17, 2020 at 6:40:01 PM UTC+1, Jan Kiszka wrote: >>> >>> On 17.03.20 18:19, vijai kumar wrote: >>> > I am not sure how to test the um use case in kernel in ISAR. Are there >>> > any specific targets in ISAR that I am missing? >>> > >>> >>> I don't think we had a um use case so far, so there might be things >>> silently broken. Not sure if Cedric tested the um special handling, I >>> surely didn't. >>> >> >> used "um" for another project (and without Isar). >> I would recommend we don't bother with it as far as Isar is concerned >> until we get a request for it >> > > Thank you for your input Cedric. > If there are no more review comments, can this be merged? Thanks, Vijai Kumar K > > >> >> >>> Jan >>> >>> > Thanks, >>> > Vijai Kumar K >>> > >>> > On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: >>> > >>> > Align with upstream debian linux-image package. Install the config >>> and >>> > System.map file to /boot directory. Skip installation for User >>> Mode >>> > Linux. >>> > >>> > Signed-off-by: Vijai Kumar K >> > > >>> > --- >>> > .../linux/files/debian/isar/install.tmpl | 14 >>> > ++++++++++++++ >>> > 1 file changed, 14 insertions(+) >>> > >>> > diff --git >>> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > index 12d592d..4e1f850 100644 >>> > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > @@ -37,6 +37,8 @@ do_install() { >>> > set -x >>> > >>> > install_image >>> > + install_config >>> > + install_map >>> > install_hooks >>> > install_dtbs >>> > install_kmods >>> > @@ -69,6 +71,18 @@ install_image() { >>> > install_image_debug >>> > } >>> > >>> > +install_config() { >>> > + if [ "${ARCH}" != "um" ]; then >>> > + cp ${O}/.config ${deb_img_dir}/$(dirname >>> > ${kimage_path})/config-${krel} >>> > + fi >>> > +} >>> > + >>> > +install_map() { >>> > + if [ "${ARCH}" != "um" ]; then >>> > + cp ${O}/System.map ${deb_img_dir}/$(dirname >>> > ${kimage_path})/System.map-${krel} >>> > + fi >>> > +} >>> > + >>> > install_image_debug() { >>> > # Different tools want the image in different locations >>> > # perf >>> > -- >>> > 2.17.1 >>> > >>> > -- >>> > You received this message because you are subscribed to the Google >>> > Groups "isar-users" group. >>> > To unsubscribe from this group and stop receiving emails from it, send >>> > an email to isar-...@googlegroups.com >>> > . >>> > To view this discussion on the web visit >>> > >>> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com >>> > < >>> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com?utm_medium=email&utm_source=footer>. >>> >>> >>> >>> -- >>> Siemens AG, Corporate Technology, CT RDA IOT SES-DE >>> Corporate Competence Center Embedded Linux >>> >> ------=_Part_683_1728416111.1585898966286 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Friday, April 3, 2020 at 12:58:46 PM UTC+5:30, = vijai kumar wrote:


On Wednesday, March 25, 2020 at 12:37:12 PM UTC+5:30, cedri= c_h...@mentor.com wrote:


On Tuesday, March 17, 2020 at 6:40:01 PM UTC+1, Jan Kiszk= a wrote:
On 17.03.20 18:19, vijai ku= mar wrote:
> I am not sure how to test the um use case in kernel in ISAR. Are t= here=20
> any specific targets in ISAR that I am missing?
>=20

I don't think we had a um use case so far, so there might be things= =20
silently broken. Not sure if Cedric tested the um special handling, I= =20
surely didn't.

used "um" for another projec= t (and without Isar).
I would recommend we don't bother with = it as far as Isar is concerned until we get a request for it

Thank you for your input Cedric.


If there are no more rev= iew comments, can this be merged?

Thanks,
Vijai Kumar K
=C2=A0
=C2=A0


Jan

> Thanks,
> Vijai Kumar K
>=20
> On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wr= ote:
>=20
> =C2=A0 =C2=A0 Align with upstream debian linux-image package. Inst= all the config and
> =C2=A0 =C2=A0 System.map file to /boot directory. Skip installatio= n for User Mode
> =C2=A0 =C2=A0 Linux.
>=20
> =C2=A0 =C2=A0 Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com
> =C2=A0 =C2=A0 <mailto:Vijaikumar_Kanag= arajan@mentor.com>>
> =C2=A0 =C2=A0 ---
> =C2=A0 =C2=A0 =C2=A0=C2=A0.../linux/files/debian/isar/install= .tmpl =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 14
> =C2=A0 =C2=A0 ++++++++++++++
> =C2=A0 =C2=A0 =C2=A0=C2=A01 file changed, 14 insertions(+)
>=20
> =C2=A0 =C2=A0 diff --git
> =C2=A0 =C2=A0 a/meta/recipes-kernel/linux/files/debian/isar/i= nstall.tmpl
> =C2=A0 =C2=A0 b/meta/recipes-kernel/linux/files/debian/isar/i= nstall.tmpl
> =C2=A0 =C2=A0 index 12d592d..4e1f850 100644
> =C2=A0 =C2=A0 --- a/meta/recipes-kernel/linux/files/debian/is= ar/install.tmpl
> =C2=A0 =C2=A0 +++ b/meta/recipes-kernel/linux/files/debian/is= ar/install.tmpl
> =C2=A0 =C2=A0 @@ -37,6 +37,8 @@ do_install() {
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0set -x
>=20
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0install_image
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0install_config
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0install_map
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0install_hooks
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0install_dtbs
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0install_kmods
> =C2=A0 =C2=A0 @@ -69,6 +71,18 @@ install_image() {
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0install_image_debug
> =C2=A0 =C2=A0 =C2=A0=C2=A0}
>=20
> =C2=A0 =C2=A0 +install_config() {
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0if [ "${ARCH}" !=3D "u= m" ]; then
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0 =C2=A0 =C2=A0cp ${O}/.config ${deb_i= mg_dir}/$(dirname
> =C2=A0 =C2=A0 ${kimage_path})/config-${krel}
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0fi
> =C2=A0 =C2=A0 +}
> =C2=A0 =C2=A0 +
> =C2=A0 =C2=A0 +install_map() {
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0if [ "${ARCH}" !=3D "u= m" ]; then
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0 =C2=A0 =C2=A0cp ${O}/System.map ${de= b_img_dir}/$(dirname
> =C2=A0 =C2=A0 ${kimage_path})/System.map-${krel}
> =C2=A0 =C2=A0 + =C2=A0 =C2=A0fi
> =C2=A0 =C2=A0 +}
> =C2=A0 =C2=A0 +
> =C2=A0 =C2=A0 =C2=A0=C2=A0install_image_debug() {
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0# Different tools want the= image in different locations
> =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0# perf
> =C2=A0 =C2=A0 --=20
> =C2=A0 =C2=A0 2.17.1
>=20
> --=20
> You received this message because you are subscribed to the Google= =20
> Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, = send=20
> an email to isar-...@googlegroups.com=20
> <mailto:isar-users+unsubscribe@googleg= roups.com>.
> To view this discussion on the web visit=20
> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e= -4f10-83f5-349ad6847274%40googlegroups.com=20
> <https://= groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349a= d6847274%40googlegroups.com?utm_medium=3Demail&utm_source=3Df= ooter>.


--=20
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
------=_Part_683_1728416111.1585898966286-- ------=_Part_682_983819135.1585898966286--