From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH] isar-bootstrap: Fix SRC_URI inclusion
Date: Thu, 14 Oct 2021 09:40:19 +0300 [thread overview]
Message-ID: <21f88315-1004-a7c6-73e5-196f18182cb0@ilbers.de> (raw)
In-Reply-To: <20211012081922.31157-1-Vijaikumar_Kanagarajan@mentor.com>
On 12.10.21 11:19, Vijai Kumar K wrote:
> Fix commit 447b298.
>
> Include the right entries to SRC_URI.
>
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index b8af676..9f297ce 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -64,7 +64,7 @@ python () {
> d.appendVar("SRC_URI", " file://%s" % bb.parse.resolve_file(file, d))
>
> distro_apt_preferences = d.getVar(d.getVar("DISTRO_VARS_PREFIX") + "DISTRO_APT_PREFERENCES", True)
> - for file in distro_apt_sources.split():
> + for file in distro_apt_preferences.split():
> d.appendVar("SRC_URI", " file://%s" % bb.parse.resolve_file(file, d))
> }
>
There is no any check in case DISTRO_APT_PREFERENCES is not set, so this
will fail for CI targets.
Propose adding `or ""` for both distro_apt_sources and
distro_apt_preferences here.
--
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
next prev parent reply other threads:[~2021-10-14 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 8:19 Vijai Kumar K
2021-10-12 9:00 ` Jan Kiszka
2021-10-14 6:40 ` Anton Mikanovich [this message]
2021-10-18 12:44 ` vijaikumar....@gmail.com
2021-10-18 12:58 ` [PATCH v2] " Vijai Kumar K
2021-11-02 16:20 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f88315-1004-a7c6-73e5-196f18182cb0@ilbers.de \
--to=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox