From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7018102194747473920 X-Received: by 2002:a05:6512:3130:: with SMTP id p16mr3384667lfd.559.1634193624832; Wed, 13 Oct 2021 23:40:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3a83:: with SMTP id q3ls2346720lfu.2.gmail; Wed, 13 Oct 2021 23:40:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKdUXjvQ0uqBW0uehlgMHG3iZbHIhZ9I5Fmrm6A2+o1kZuicKJkCJrCaneH0wmsEynYTXZ X-Received: by 2002:a05:6512:2301:: with SMTP id o1mr3360240lfu.333.1634193623741; Wed, 13 Oct 2021 23:40:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634193623; cv=none; d=google.com; s=arc-20160816; b=mScvo10wCHplp6vaDPBxu5RTQ82a2U98LEN5fcdvNRKBKQVMtcnZElC6Sh9iBSSKI6 2hgEvOTCj+P/9DF32VpV3zCq0OTnSNf7O+uaeLYjkcBSGROznb7ZRl1FSKBtKjfTNadc yHfuWV9oXS1G4PhoQm+EM10vHzCT0/GfDPQKjHlR1FwhbZjH6/D7ETavLr9gD0t/eJqA WWWGoS5+u+JcxeOdhUcuqO64KN1GRM0ZqE6QP69XB5jnaAkDnTGOnjViLamfsyyVHHbe ld0DP+krGE8ar2zpYdo1MxVFxLxc2km6uh3/a4Db6EOBei9C1dZOhHnDXxisLlj2oob+ ijpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:cc:references:to:subject; bh=LV3RPegZp2F8Hk6tmtPLvKJYoxBfjH1GxJcPyKH4GAo=; b=hYWIVwbuX2BUhtOZJXes1inkBOCDZAUJmYxidteRivkB1Mr4NNxgz3EnLmRBjOkZxJ dK72BQ2lCZmcYjyDSIhONYd2pG/eKWztacqaPKC0/D6S+eMroGV67Qab1f4A/ylu3f0O 6PHlZcY9R5U1z7Lrp9b7tJGr/FJQuFb/tUMXhBQj+EaqAaC7ysYASUTizY2rsq5AnDdx CrHPmnPRlKz9TZwIqxZEomfRxr55ztglYwCosXpA6jKnsgFM9TqVsuynx/P5B+AjZlUa 3ew2LloRRmS8xCM4EUlx51FTZWmWqAeBVJWtk3FYiovA3OwFPLxb2wX++CkoC535+ivc H9Eg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id k8si101465ljq.8.2021.10.13.23.40.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Oct 2021 23:40:23 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [10.54.4.214] (leased-line-st-87-252-252-30.telecom.by [87.252.252.30]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 19E6eKXl012573 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 08:40:20 +0200 Subject: Re: [PATCH] isar-bootstrap: Fix SRC_URI inclusion To: isar-users@googlegroups.com References: <20211012081922.31157-1-Vijaikumar_Kanagarajan@mentor.com> Cc: Jan Kiszka From: Anton Mikanovich Message-ID: <21f88315-1004-a7c6-73e5-196f18182cb0@ilbers.de> Date: Thu, 14 Oct 2021 09:40:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211012081922.31157-1-Vijaikumar_Kanagarajan@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TUID: 8JJcBVrXHUt3 On 12.10.21 11:19, Vijai Kumar K wrote: > Fix commit 447b298. > > Include the right entries to SRC_URI. > > Signed-off-by: Vijai Kumar K > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > index b8af676..9f297ce 100644 > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > @@ -64,7 +64,7 @@ python () { > d.appendVar("SRC_URI", " file://%s" % bb.parse.resolve_file(file, d)) > > distro_apt_preferences = d.getVar(d.getVar("DISTRO_VARS_PREFIX") + "DISTRO_APT_PREFERENCES", True) > - for file in distro_apt_sources.split(): > + for file in distro_apt_preferences.split(): > d.appendVar("SRC_URI", " file://%s" % bb.parse.resolve_file(file, d)) > } > There is no any check in case DISTRO_APT_PREFERENCES is not set, so this will fail for CI targets. Propose adding `or ""` for both distro_apt_sources and distro_apt_preferences here. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov