From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7191847640499224576 X-Received: by 2002:aa7:95b8:0:b0:5a8:18d4:12f with SMTP id a24-20020aa795b8000000b005a818d4012fmr1537151pfk.18.1675942549110; Thu, 09 Feb 2023 03:35:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:8546:b0:192:62df:a3e7 with SMTP id d6-20020a170902854600b0019262dfa3e7ls2201942plo.9.-pod-prod-gmail; Thu, 09 Feb 2023 03:35:48 -0800 (PST) X-Google-Smtp-Source: AK7set8ZSzee0V6YailFTKFlod7+qKg6r7hgNthdmc5iSG4KvxsUsn9V6i6Abm15c2Tig4JtF9D6 X-Received: by 2002:a05:6a21:3398:b0:be:cbee:ed9d with SMTP id yy24-20020a056a21339800b000becbeeed9dmr13281865pzb.45.1675942548077; Thu, 09 Feb 2023 03:35:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675942548; cv=none; d=google.com; s=arc-20160816; b=Ry9bZuo12gtRHmXxQcAo3HFBolAQVF+eC2NlcKdczsEOiUgnF8cvPpRoU0Du+t/bKs ev9Sni0RWEVnEMTszVsJ46K2ueoYSwy9evGgEWlGtcZFo8cKO/Ld1xTtSsnuOiayb7du L+S4sir0gFRrMD2pnce6YlGHszwW/cLkYYbIZrpLs2jdQSfw1eDej60H0HfxH8eVoAhS oyjsXVmqY+MhOBWKt0EjallwbA6OQHBdYa2mZlYMhMGaAOfucOx2fsXoVbtIMtJIuhNV fXBafo404k1WV81+ppkIXi2Moy1aW4oqv1TfYRJeY8u9sdI57sh/KXo+lsuUUMqTfTYM OVpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=DMT9qRr96U/mVrnrjsSCl7cV252LuH7qgBzfOMAvf+M=; b=xyDp7Bg49h+2mXEKD07wgRa3UNU/xVh8HqIT8/pGmQYDG6k21dcLW16JjnxB8FhhEf yAXj9yXbfMoEBGg0KgUBh9NPi0a/JZEtF0FN9QqZ13XXTwgKxNF7niWW0mvIYZ7kqmxm +R9Sy21xFzgZsyXv7ayOmQHRMg0da+Dmjj4fAH3PE9HpfA+j4raGdwMkgPoJbRdzAqyM G1gYBHvciejz8oCVSNAkcXvxlEfTHyQHmXIE9fT43IsXuMLEdxX/IfWDg6Yh7vgWf+9T avEUUy14B3agpSyKIHxpYGNKE566sP5I2m4Nx4E5OkNRSUKASuDTEe3FOKlw1ZcKK7p5 E5Dw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id v3-20020a655c43000000b004a3ed20c3c0si94075pgr.3.2023.02.09.03.35.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Feb 2023 03:35:47 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 319BZiIV019041 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Feb 2023 12:35:45 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com Cc: Michael Adler Subject: Re: [PATCH] feat: add zstd support to image conversions Date: Thu, 09 Feb 2023 14:35:42 +0300 Message-ID: <2209477.vFx2qVVIhK@home> In-Reply-To: <20230123140016.71522-1-michael.adler@siemens.com> References: <20230123140016.71522-1-michael.adler@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ZMiKro0jf2lv In the email from Monday, 23 January 2023 17:00:16 +03 user Michael Adler wrote: > This patch enables ISAR to build zstd compressed images. > > Signed-off-by: Michael Adler > --- > meta/classes/imagetypes.bbclass | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/imagetypes.bbclass > b/meta/classes/imagetypes.bbclass index 1e8e223d..6950da7a 100644 > --- a/meta/classes/imagetypes.bbclass > +++ b/meta/classes/imagetypes.bbclass > @@ -93,7 +93,7 @@ IMAGE_CMD_ubi() { > IMAGE_CMD_ubi[depends] = "${PN}:do_transform_template" > > # image conversions > -IMAGE_CONVERSIONS = "gz xz" > +IMAGE_CONVERSIONS = "gz xz zst" > > CONVERSION_CMD_gz = "${SUDO_CHROOT} sh -c 'gzip -f -9 -n -c --rsyncable > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.gz'" CONVERSION_DEPS_gz = > "gzip" > @@ -105,3 +105,11 @@ XZ_OPTIONS ?= "--memlimit=${XZ_MEMLIMIT} > --threads=${XZ_THREADS}" XZ_OPTIONS[vardepsexclude] += "XZ_MEMLIMIT > XZ_THREADS" > CONVERSION_CMD_xz = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_OPTIONS} > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.xz'" CONVERSION_DEPS_xz = > "xz-utils" > + > +ZST_LEVEL ?= "19" > +ZST_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}" > +ZST_THREADS[vardepvalue] = "1" > +ZST_OPTIONS ?= "-${ZST_LEVEL} --threads=${ZST_THREADS}" > +ZST_OPTIONS[vardepsexclude] += "ZST_LEVEL ZST_THREADS" > +CONVERSION_CMD_zst = "${SUDO_CHROOT} sh -c 'zstd -c ${ZST_OPTIONS} Since we switched to Bitbake 2.0, we need v2 with using new syntax. Of course, in case we need this feature at all... > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.zst'" +CONVERSION_DEPS_zst = > "zstd"