Re: [PATCH] meta/classes/base: Fix showdata and liststasks after bitbake update

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-08 17:13, Jan Kiszka wrote:
> On 2018-02-08 16:47, Alexander Smirnov wrote:
>> On 02/08/2018 06:24 PM, Claudius Heine wrote:
>>> Hi Alex,
>>>
>>> On 02/08/2018 02:55 PM, Alexander Smirnov wrote:
>>>> Hi,
>>>>
>>>> On 02/08/2018 02:26 PM, claudius.heine.ext@siemens.com wrote:
>>>>> From: Claudius Heine <ch@denx.de>
>>>>>
>>>>> Those tasks were broken, this patchs fixes by implementing them similar
>>>>> to how openembedded-core does it.
>>>>>
>>>>
>>>> I see that this code is identical to OE one, do you know which
>>>> copyright it is? If this code is copied from OE, I think it makes
>>>> sense to mention this explicitly in the code.
>>>
>>> Sure, I got it from [1], and this file does not have an own header, so
>>> I suppose its MIT or GPLv2. I don't know if this falls under
>>> 'metadata' or not. Since Isar uses the same licenses, you might know
>>> what exactly is meant by that.
>>>
>>> How are you proposing to name the authors?
>>
>> I see it something like:
>>
>> # Derived from openembedded-core/meta/classes/utility-tasks.bbclass
>>
>> @Jan: do you think we should keep this reference?
> 
> It doesn't harm us, I would say.
> 
> In general, it would be better for Isar (compared to OE) to have clear
> licensing statements in each file. State-of-the-art is leaving the right
> SPDX-License-Identifier behind.

...which I didn't do either in my recent patches. Will fix and send v2.

How about this pattern:

# SPDX-License-Identifier: MIT
#
# <some optional file description>
#
# This software is a part of ISAR.
# Copyright (c) Siemens AG, 2018
#

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux