public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH v2] linux-custom: Fix decompressed kernel name for arm64
@ 2021-01-25 14:31 Anton Mikanovich
  2021-02-10  9:19 ` Anton Mikanovich
  2021-09-02 15:05 ` Henning Schild
  0 siblings, 2 replies; 4+ messages in thread
From: Anton Mikanovich @ 2021-01-25 14:31 UTC (permalink / raw)
  To: isar-users; +Cc: Anton Mikanovich

We are performing gunzip from vmlinuz on arm64, so output should have
correct naming.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
Changes since v1:
- Add RECIPE-API-CHANGELOG entry.
---
 RECIPE-API-CHANGELOG.md                                  | 5 +++++
 meta/conf/bitbake.conf                                   | 1 +
 meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 6 +++---
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index cc45f3f..bd8a204 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -282,3 +282,8 @@ like /boot/efi to avoid such issues.
 ### Deprecate BUILD_DEPENDS in u-boot-custom.inc
 
 Use DEBIAN_BUILD_DEPENDS instead, to align with deb_debianize.
+
+### Change kernel image name for arm64
+
+Kernel image name for arm64 platforms is vmlinux now. Image format was
+not changed (uncompressed executable) but now it is named correctly.
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index acce55d..9859456 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -61,6 +61,7 @@ CACHE = "${TMPDIR}/cache"
 KERNEL_FILE ?= "vmlinuz"
 KERNEL_FILE_mipsel ?= "vmlinux"
 KERNEL_FILE_riscv64 ?= "vmlinux"
+KERNEL_FILE_arm64 ?= "vmlinux"
 
 OVERRIDES = "${DISTRO_ARCH}:${COMPAT_OVERRIDE}:${MACHINE}:${DISTRO}:forcevariable"
 FILESOVERRIDES = "${DISTRO_ARCH}:${MACHINE}"
diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
index 8eca4c7..69fb88d 100644
--- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
@@ -26,9 +26,9 @@ do_install() {
     fi
     krel="$(${MAKE} O=${O} -s --no-print-directory kernelrelease)"
     case "${ARCH}" in
-        mips|powerpc|riscv) kimage_path="boot/vmlinux-${krel}"    ;;
-                        um) kimage_path="usr/bin/vmlinux-${krel}" ;;
-                         *) kimage_path="boot/vmlinuz-${krel}"    ;;
+        mips|powerpc|riscv|arm64) kimage_path="boot/vmlinux-${krel}"    ;;
+                              um) kimage_path="usr/bin/vmlinux-${krel}" ;;
+                               *) kimage_path="boot/vmlinuz-${krel}"    ;;
     esac
 
     print_settings
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] linux-custom: Fix decompressed kernel name for arm64
  2021-01-25 14:31 [PATCH v2] linux-custom: Fix decompressed kernel name for arm64 Anton Mikanovich
@ 2021-02-10  9:19 ` Anton Mikanovich
  2021-09-02 15:05 ` Henning Schild
  1 sibling, 0 replies; 4+ messages in thread
From: Anton Mikanovich @ 2021-02-10  9:19 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users

25.01.2021 17:31, Anton Mikanovich wrote:
> We are performing gunzip from vmlinuz on arm64, so output should have
> correct naming.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>

Applied to next.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] linux-custom: Fix decompressed kernel name for arm64
  2021-01-25 14:31 [PATCH v2] linux-custom: Fix decompressed kernel name for arm64 Anton Mikanovich
  2021-02-10  9:19 ` Anton Mikanovich
@ 2021-09-02 15:05 ` Henning Schild
  2021-10-06  5:09   ` Srinuvasan A
  1 sibling, 1 reply; 4+ messages in thread
From: Henning Schild @ 2021-09-02 15:05 UTC (permalink / raw)
  To: Anton Mikanovich; +Cc: isar-users

Turns out this is wrong. debian itself would use vmlinuz for arm64 and
in fact also does that i.e in "linux-update-symlinks" which takes its
"stem" from 

https://salsa.debian.org/kernel-team/linux-base/-/blob/master/lib/DebianLinux.pm#L79

And on the other side of the story ... debians kernel build sets the
arm64 stem

https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/arm64/defines#L14

I will send patches.

Henning

Am Mon, 25 Jan 2021 17:31:28 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> We are performing gunzip from vmlinuz on arm64, so output should have
> correct naming.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> Changes since v1:
> - Add RECIPE-API-CHANGELOG entry.
> ---
>  RECIPE-API-CHANGELOG.md                                  | 5 +++++
>  meta/conf/bitbake.conf                                   | 1 +
>  meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 6 +++---
>  3 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index cc45f3f..bd8a204 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -282,3 +282,8 @@ like /boot/efi to avoid such issues.
>  ### Deprecate BUILD_DEPENDS in u-boot-custom.inc
>  
>  Use DEBIAN_BUILD_DEPENDS instead, to align with deb_debianize.
> +
> +### Change kernel image name for arm64
> +
> +Kernel image name for arm64 platforms is vmlinux now. Image format
> was +not changed (uncompressed executable) but now it is named
> correctly. diff --git a/meta/conf/bitbake.conf
> b/meta/conf/bitbake.conf index acce55d..9859456 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -61,6 +61,7 @@ CACHE = "${TMPDIR}/cache"
>  KERNEL_FILE ?= "vmlinuz"
>  KERNEL_FILE_mipsel ?= "vmlinux"
>  KERNEL_FILE_riscv64 ?= "vmlinux"
> +KERNEL_FILE_arm64 ?= "vmlinux"
>  
>  OVERRIDES =
> "${DISTRO_ARCH}:${COMPAT_OVERRIDE}:${MACHINE}:${DISTRO}:forcevariable"
> FILESOVERRIDES = "${DISTRO_ARCH}:${MACHINE}" diff --git
> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index
> 8eca4c7..69fb88d 100644 ---
> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++
> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -26,9
> +26,9 @@ do_install() { fi krel="$(${MAKE} O=${O} -s
> --no-print-directory kernelrelease)" case "${ARCH}" in
> -        mips|powerpc|riscv) kimage_path="boot/vmlinux-${krel}"    ;;
> -                        um) kimage_path="usr/bin/vmlinux-${krel}" ;;
> -                         *) kimage_path="boot/vmlinuz-${krel}"    ;;
> +        mips|powerpc|riscv|arm64) kimage_path="boot/vmlinux-${krel}"
>    ;;
> +                              um)
> kimage_path="usr/bin/vmlinux-${krel}" ;;
> +                               *) kimage_path="boot/vmlinuz-${krel}"
>    ;; esac
>  
>      print_settings


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] linux-custom: Fix decompressed kernel name for arm64
  2021-09-02 15:05 ` Henning Schild
@ 2021-10-06  5:09   ` Srinuvasan A
  0 siblings, 0 replies; 4+ messages in thread
From: Srinuvasan A @ 2021-10-06  5:09 UTC (permalink / raw)
  To: isar-users


[-- Attachment #1.1: Type: text/plain, Size: 3109 bytes --]



On Friday, September 3, 2021 at 8:51:52 PM UTC+5:30 Henning Schild wrote:

> Turns out this is wrong. debian itself would use vmlinuz for arm64 and 
> in fact also does that i.e in "linux-update-symlinks" which takes its 
> "stem" from 
>
>
> https://salsa.debian.org/kernel-team/linux-base/-/blob/master/lib/DebianLinux.pm#L79 
>
> And on the other side of the story ... debians kernel build sets the 
> arm64 stem 
>
>
> https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/arm64/defines#L14 
>
> I will send patches.


  Can you please confirm kernel name for arm64 machine, Need to adjust in 
downstream layer.

  thanks, Srinuvasan.A

>
>
> Henning 
>
> Am Mon, 25 Jan 2021 17:31:28 +0300 
> schrieb Anton Mikanovich <ami...@ilbers.de>: 
>
> > We are performing gunzip from vmlinuz on arm64, so output should have 
> > correct naming. 
> > 
> > Signed-off-by: Anton Mikanovich <ami...@ilbers.de> 
> > --- 
> > Changes since v1: 
> > - Add RECIPE-API-CHANGELOG entry. 
> > --- 
> > RECIPE-API-CHANGELOG.md | 5 +++++ 
> > meta/conf/bitbake.conf | 1 + 
> > meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 6 +++--- 
> > 3 files changed, 9 insertions(+), 3 deletions(-) 
> > 
> > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md 
> > index cc45f3f..bd8a204 100644 
> > --- a/RECIPE-API-CHANGELOG.md 
> > +++ b/RECIPE-API-CHANGELOG.md 
> > @@ -282,3 +282,8 @@ like /boot/efi to avoid such issues. 
> > ### Deprecate BUILD_DEPENDS in u-boot-custom.inc 
> > 
> > Use DEBIAN_BUILD_DEPENDS instead, to align with deb_debianize. 
> > + 
> > +### Change kernel image name for arm64 
> > + 
> > +Kernel image name for arm64 platforms is vmlinux now. Image format 
> > was +not changed (uncompressed executable) but now it is named 
> > correctly. diff --git a/meta/conf/bitbake.conf 
> > b/meta/conf/bitbake.conf index acce55d..9859456 100644 
> > --- a/meta/conf/bitbake.conf 
> > +++ b/meta/conf/bitbake.conf 
> > @@ -61,6 +61,7 @@ CACHE = "${TMPDIR}/cache" 
> > KERNEL_FILE ?= "vmlinuz" 
> > KERNEL_FILE_mipsel ?= "vmlinux" 
> > KERNEL_FILE_riscv64 ?= "vmlinux" 
> > +KERNEL_FILE_arm64 ?= "vmlinux" 
> > 
> > OVERRIDES = 
> > "${DISTRO_ARCH}:${COMPAT_OVERRIDE}:${MACHINE}:${DISTRO}:forcevariable" 
> > FILESOVERRIDES = "${DISTRO_ARCH}:${MACHINE}" diff --git 
> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl 
> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index 
> > 8eca4c7..69fb88d 100644 --- 
> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ 
> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -26,9 
> > +26,9 @@ do_install() { fi krel="$(${MAKE} O=${O} -s 
> > --no-print-directory kernelrelease)" case "${ARCH}" in 
> > - mips|powerpc|riscv) kimage_path="boot/vmlinux-${krel}" ;; 
> > - um) kimage_path="usr/bin/vmlinux-${krel}" ;; 
> > - *) kimage_path="boot/vmlinuz-${krel}" ;; 
> > + mips|powerpc|riscv|arm64) kimage_path="boot/vmlinux-${krel}" 
> > ;; 
> > + um) 
> > kimage_path="usr/bin/vmlinux-${krel}" ;; 
> > + *) kimage_path="boot/vmlinuz-${krel}" 
> > ;; esac 
> > 
> > print_settings 
>
>

[-- Attachment #1.2: Type: text/html, Size: 4846 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-06  5:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 14:31 [PATCH v2] linux-custom: Fix decompressed kernel name for arm64 Anton Mikanovich
2021-02-10  9:19 ` Anton Mikanovich
2021-09-02 15:05 ` Henning Schild
2021-10-06  5:09   ` Srinuvasan A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox