Re: [PATCH 10/7] bitbake.conf: Clean up and enhance OVERRIDES

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Jan,

On 07/01/2019 07.06, [ext] Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> We do no use any "local" override, and there is no TARGET_OS and
> TARGET_ARCH in Isar. Rather adopt the OE core ordering of
> arch:machine:distro and also add the "forcevariable" the OE provides.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta/conf/bitbake.conf | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index b067a0d..0e521bb 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -28,7 +28,6 @@ FILE_DIRNAME = "${@os.path.dirname(d.getVar('FILE', False))}"
>   GITDIR = "${DL_DIR}/git"
>   IMAGE_CMD = "_NO_DEFINED_IMAGE_TYPES_"
>   IMAGE_ROOTFS = "${TMPDIR}/rootfs"
> -OVERRIDES = "local:${MACHINE}:${TARGET_OS}:${TARGET_ARCH}"
>   P = "${PN}-${PV}"
>   PF = "${PN}-${PV}-${PR}"
>   PN = "${@bb.parse.BBHandler.vars_from_file(d.getVar('FILE', False),d)[0] or 'defaultpkgname'}"
> @@ -55,6 +54,8 @@ BUILDCHROOT_HOST_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-host
>   BUILDCHROOT_TARGET_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-target/rootfs"
>   CACHE = "${TMPDIR}/cache"
>   
> +OVERRIDES = "${DISTRO_ARCH}:${MACHINE}:${DISTRO}:forcevariable"
> +

OE uses MACHINEOVERRIDES and DISTROOVERRIDES to model compatibility of 
machines and distros. Also having the 'pn-${PN}' entry in there can be 
useful as well if a certain variable from one recipe should be 
overwritten from local.conf/kas-project file.

Not in scope of this, but maybe something to think about would be the 
CLASSOVERRIDES. Maybe the cross-compile/native-compile mechanism could 
be changed to use different classes and then variables that need to have 
different values for each class can be specified with the class name 
override, like its done in OE.

regards and a happy new year to everyone,
Claudius

>   # Codename of the repository created by the caching class
>   DEBDISTRONAME = "isar"
>   
> @@ -66,8 +67,6 @@ REPO_ISAR_DB_DIR = "${DEPLOY_DIR}/isar-apt/db"
>   REPO_BASE_DIR = "${DL_DIR}/base-apt/apt"
>   REPO_BASE_DB_DIR = "${DL_DIR}/base-apt/db"
>   
> -OVERRIDES_append = ":${DISTRO}:${DISTRO_ARCH}"
> -
>   BB_HASHBASE_WHITELIST ?= "TMPDIR FILE PATH PWD BB_TASKHASH BBPATH BBSERVER DL_DIR \
>       SSTATE_DIR THISDIR FILESEXTRAPATHS FILE_DIRNAME HOME LOGNAME SHELL TERM \
>       USER FILESPATH STAGING_DIR_HOST STAGING_DIR_TARGET COREBASE PRSERV_HOST \
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de