From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 1/3] classes: images: remove cyclic "inherit"
Date: Tue, 1 Aug 2017 17:24:06 +0200 [thread overview]
Message-ID: <23a4ea9c98a5834651eed2888b02a2bdbe1d2ac3.1501600807.git.henning.schild@siemens.com> (raw)
In-Reply-To: <cover.1501600807.git.henning.schild@siemens.com>
In-Reply-To: <cover.1501600807.git.henning.schild@siemens.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
meta-isar/recipes-core/images/isar-image-base.bb | 4 +++-
meta/classes/ext4-img.bbclass | 2 +-
meta/classes/image.bbclass | 3 ---
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index 0810de0..25682ed 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -10,7 +10,9 @@ LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260
PV = "1.0"
-inherit image
+IMAGE_TYPE ?= "ext4-img"
+
+inherit ${IMAGE_TYPE}
DEPENDS += "${IMAGE_INSTALL}"
diff --git a/meta/classes/ext4-img.bbclass b/meta/classes/ext4-img.bbclass
index 5125d8e..61699b8 100644
--- a/meta/classes/ext4-img.bbclass
+++ b/meta/classes/ext4-img.bbclass
@@ -1,7 +1,7 @@
# This software is a part of ISAR.
# Copyright (C) 2015-2016 ilbers GmbH
-inherit isar-base-image
+inherit image
# Extra space for rootfs in MB
ROOTFS_EXTRA ?= "64"
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 8db3352..3faa609 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -5,9 +5,6 @@ KERNEL_IMAGE ?= ""
INITRD_IMAGE ?= ""
IMAGE_INSTALL ?= ""
-IMAGE_TYPE ?= "ext4-img"
-
-inherit ${IMAGE_TYPE}
do_populate[stamp-extra-info] = "${MACHINE}"
--
2.13.0
next prev parent reply other threads:[~2017-08-01 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 15:24 [PATCH 0/3] use local repo for multistrap and drop "dpkg -i" Henning Schild
2017-08-01 15:24 ` Henning Schild [this message]
2017-08-01 15:24 ` [PATCH 2/3] classes: move rootfs into image class and split into tasks Henning Schild
2017-08-01 15:24 ` [PATCH 3/3] classes: image: remove populate and replace it with a custom repo Henning Schild
2017-08-09 6:21 ` Henning Schild
2017-08-02 6:16 ` [PATCH 0/3] use local repo for multistrap and drop "dpkg -i" Jan Kiszka
2017-08-02 7:04 ` Claudius Heine
2017-08-02 8:15 ` Henning Schild
2017-08-02 8:11 ` Henning Schild
2017-08-02 8:12 ` Henning Schild
2017-08-03 19:17 ` Henning Schild
2017-08-10 12:46 ` Baurzhan Ismagulov
2017-08-11 8:13 ` Henning Schild
2017-08-11 15:36 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a4ea9c98a5834651eed2888b02a2bdbe1d2ac3.1501600807.git.henning.schild@siemens.com \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox