From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6566315014247940096 X-Received: by 2002:a2e:3209:: with SMTP id y9-v6mr109887ljy.33.1528978151204; Thu, 14 Jun 2018 05:09:11 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9853:: with SMTP id e19-v6ls820331ljj.1.gmail; Thu, 14 Jun 2018 05:09:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ0ySzn2n8edncOW0u/S+E9h5C9DGv3V4zix1psFnd+K7Nb653dNfnS6tKNMS4uQSzzu2g8 X-Received: by 2002:a2e:8654:: with SMTP id i20-v6mr108051ljj.11.1528978150610; Thu, 14 Jun 2018 05:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528978150; cv=none; d=google.com; s=arc-20160816; b=S9UCP0dGPbOIR/fq/Xbw5YNeOFTtQxHI3a0JTF3HQFpIDEs961o/uGmF9Zq0IazLF8 SZQiaKb1Q2cZTHwdfJSfif6nSnlWujZo6V/3ArAkgJy6wWlYIiswvHFmT5ooy0HvqhP2 yYASKU355MPL+x6OLpsahi52nte3VPK+J6Nt7UQkkFtSnP7/6x7hF36WnIjdBPaEpOzH mKgENxwvfGwr7aDlHqwKyx3j33wd8cd5T1pJKSvtuOTHQ+mB6ogF0L4eFnuyR9VtUAZm IXl1TLNuVPrOPDLTj1TXwP/Rih5RV2SsoHs8fz752ayMAb3uAZa0lXmGn3+adVMnHb19 wZDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=fkuW9Mc/QLo0jSS4czMsRrUv8pxKX4Jg/2lNpt+TQs8=; b=F9w53oS8E/UYX8ZoLznl1QnWW1VrhAJXpxF1qq4+xMeYCQwmCVGTKuV2YJE/LnUvJt kGhBnjnpeVpvtBNm2zeSAIzHkMHuRTdPDPcGbeFozapQY1m+VRvgXD1yEqbRPkCTmFGv CTG4u3ISC6KcOzavACPPWpu4mRJFnXozbo9h3F1+G8nEJrCsLXrnzJsJJynFrGqXruRB CrBpMHMtLcm6LiKcSUz8PcpYElqdZ7pbx14fGDddpgevoIVP5tmHXYLs2Dtn0IpJznYl VSjE+EWRYgwAZ2Y3Wv8JU9cMIMMbOOTsr9tappBQ7pjmJXNxvN/IslSv17ylSGbZgd8Q 2mEA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id z203-v6si188373lff.3.2018.06.14.05.09.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jun 2018 05:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w5EC999E024131 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 14 Jun 2018 14:09:09 +0200 Received: from [146.254.83.53] ([146.254.83.53]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w5EC995K003492; Thu, 14 Jun 2018 14:09:09 +0200 Subject: Re: [PATCH] Fix mounting of downloads dir into buildchroot To: Henning Schild Cc: isar-users References: <5e078304-29a8-460f-9859-84a7bfeb13b1@siemens.com> <20180614104003.09186edc@md1pvb1c.ad001.siemens.net> <20180614131542.13cf1581@md1pvb1c.ad001.siemens.net> From: Jan Kiszka Message-ID: <241d38bc-c664-304d-efcb-e158c140e943@siemens.com> Date: Thu, 14 Jun 2018 14:09:07 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180614131542.13cf1581@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: WNArfPsdCGgT On 2018-06-14 13:15, Henning Schild wrote: > Am Thu, 14 Jun 2018 10:43:52 +0200 > schrieb Jan Kiszka : > >> On 2018-06-14 10:40, Henning Schild wrote: >>> Am Tue, 12 Jun 2018 23:35:48 +0200 >>> schrieb "[ext] Jan Kiszka" : >>> >>>> setup_root_file_system() mounts most of the required paths >>>> buildchroot needs into its rootfs - except for the downloads dir. >>>> But do_build() of dpkg-base cannot not detect this gap because it >>>> tests for isar-apt being mounted. >>>> >>>> To close the gap without causing duplicate mounts, just add the >>>> missing mount to the end of buildchroot do_build(). >>> >>> I am not sure i understand why you need that directory mounted in >>> the first place. You build deps or recipe SRC_URI should provide >>> you with everything you need. >>> Can you please provide an example? >> >> - retrieval of git revision for the build (see also 9a8b7fe77cbd) > > mhh that stupid git again, i wish my "non-shared unpack" patch would > have gotten accepted in bitbake. It's not git-specific. It's about the build system of the package has a chance to retrieve the git revision from the repo - in case the upstream package is expecting to do that, like in the Jailhouse case. > So that mount from 9a8b7fe77cbd got lost with debootstrap? Yes, that is a likely a regression of the debootstrap refactoring. > >> - pushing recipe-private downloads into that folder (that is a >> special case, granted) > > Something that probably should not be allowed ... thinking about > reproducing a build. Right now we "just" have to tame apt and bitbake. It's not as bad in this case as it seems (and fixing the issue makes it even better) because buildroot [1] is pulling well-defined packages. Jan [1] https://github.com/siemens/jailhouse-images/blob/master/recipes-core/non-root-initramfs/non-root-initramfs_2017.11.2.bb -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux