public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "amikan@ilbers.de" <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH] rpi: Fix kernel file name for arm64 target
Date: Tue, 26 May 2026 09:40:03 +0000	[thread overview]
Message-ID: <246661bb60add9b6a9694a2382c7e640dbe9a663.camel@siemens.com> (raw)
In-Reply-To: <20260526090048.3114378-1-amikan@ilbers.de>

On Tue, 2026-05-26 at 12:00 +0300, Anton Mikanovich wrote:
> For generic arm64 targets KERNEL_FILE is set by override, so if we need
> to change it, override ':arm64' should be used. Otherwize generic value
> still will be used.

The override is in bitbake.conf, namely:

KERNEL_FILE ?= "vmlinuz"
KERNEL_FILE:mipsel ?= "vmlinux"
KERNEL_FILE:riscv64 ?= "vmlinux"
KERNEL_FILE:arm64 ?= "vmlinux"

> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta-isar/conf/machine/rpi-common.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-isar/conf/machine/rpi-common.conf b/meta-isar/conf/machine/rpi-common.conf
> index 9dd70f99..c9b59125 100644
> --- a/meta-isar/conf/machine/rpi-common.conf
> +++ b/meta-isar/conf/machine/rpi-common.conf
> @@ -11,6 +11,7 @@ INSTALLER_WKS_FILE ?= "installer-rpi.wks"
>  
>  # RPi have custom kernel file names
>  KERNEL_FILE = "${KERNEL_NAME}.img"
> +KERNEL_FILE:arm64 = "${KERNEL_NAME}.img"

It is hard to explain why this is needed and probably other downstream
targets stumble upon this as well. How about keeping it as-is, but
change the definition in bitbake.conf by using an anonymous function
(untested)?

E.g.

KERNEL_FILE = "${@'vmlinux' if d.getVar('DISTRO_ARCH') in ['mipsel',
'riscv64', 'arm64'] else 'vmlinuz'}"

Best regards,
Felix

>  
>  KERNEL_TYPE = "raspios"
>  KERNEL_IMAGE_PKG ?= "raspberrypi-kernel"
> -- 
> 2.34.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260526090048.3114378-1-amikan%40ilbers.de.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/246661bb60add9b6a9694a2382c7e640dbe9a663.camel%40siemens.com.

  reply	other threads:[~2026-05-26  9:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  9:00 Anton Mikanovich
2026-05-26  9:40 ` 'MOESSBAUER, Felix' via isar-users [this message]
2026-05-26  9:47   ` Anton Mikanovich
2026-05-26 10:09     ` 'MOESSBAUER, Felix' via isar-users
2026-05-26 12:25       ` 'Jan Kiszka' via isar-users
2026-05-26 12:28         ` Anton Mikanovich
2026-05-26 12:34           ` 'Jan Kiszka' via isar-users
2026-05-28 13:56   ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=246661bb60add9b6a9694a2382c7e640dbe9a663.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox