From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH v1 5/5] events: Unmount all lost mounts at task fail
Date: Thu, 8 Jul 2021 18:28:38 +0200 [thread overview]
Message-ID: <24de0200-d23e-0fe4-9db1-d876ca6fa55a@siemens.com> (raw)
In-Reply-To: <61cdeb13-6c73-ba11-6085-81909163a477@ilbers.de>
On 08.07.21 16:41, Anton Mikanovich wrote:
> 08.07.2021 15:24, Jan Kiszka wrote:
>> No looping, so everything you miss here will continue to be cleaned up
>> by build_completed() - so what's the point of these changes?
>>
>> Jan
>>
> This is where WORKDIR will be unmounted to prevent double mount.
> It in necessary to fix the original issue fixed by
> d21d49578e5a3b0019075d1946bd93a95914fcca and explained in previous mails.
>
I do get the idea of a perfect world where a single attempt to umount
works and cleanly pairs with the regular umount when the task succeeds.
The problem is that I cannot see that this has been validate to truly
catch the corner cases that the lazy, late-triggered scheme addresses so
far. If it does not handle that, these umounts are pointless. If it
does, we can drop the build_completed() handler. Having both indicates
no progress, just more complexity.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-07-08 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 16:38 [PATCH v1 0/5] Restore downstream mounts compatibility Anton Mikanovich
2021-07-07 16:38 ` [PATCH v1 1/5] Revert "dpkg: Make mount buildroot reliable" Anton Mikanovich
2021-07-08 12:16 ` Jan Kiszka
2021-07-07 16:38 ` [PATCH v1 2/5] mount: Allow calling unmount on not mounted paths Anton Mikanovich
2021-07-08 12:17 ` Jan Kiszka
2021-07-07 16:38 ` [PATCH v1 3/5] dpkg: Remove unmount loop Anton Mikanovich
2021-07-08 12:21 ` Jan Kiszka
2021-07-08 14:35 ` Anton Mikanovich
2021-07-08 16:16 ` Jan Kiszka
2021-08-17 13:02 ` Anton Mikanovich
2021-07-07 16:38 ` [PATCH v1 4/5] image: Add reference counter Anton Mikanovich
2021-07-07 16:38 ` [PATCH v1 5/5] events: Unmount all lost mounts at task fail Anton Mikanovich
2021-07-08 12:24 ` Jan Kiszka
2021-07-08 14:41 ` Anton Mikanovich
2021-07-08 16:28 ` Jan Kiszka [this message]
2021-07-12 16:08 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24de0200-d23e-0fe4-9db1-d876ca6fa55a@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox