From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6982225001537601536 X-Received: by 2002:a7b:c258:: with SMTP id b24mr6425240wmj.122.1625761720594; Thu, 08 Jul 2021 09:28:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:dd86:: with SMTP id x6ls2201262wrl.1.gmail; Thu, 08 Jul 2021 09:28:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxA8nqDjL+HhzEcLGl1DH+uxbp9Fg1USda9uXzZTmzBG9V8CNjz05d5hfa1yHePoKdFqiR6 X-Received: by 2002:a5d:5142:: with SMTP id u2mr9365125wrt.314.1625761719708; Thu, 08 Jul 2021 09:28:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625761719; cv=none; d=google.com; s=arc-20160816; b=dm2jbEQZsOwkAWiazWdXKDpW+gh4tKHA+J+cYSdDqkuLU2q6OgL+7Vg2htWbhPKfOS gXD8y9dtarEoxMaFfHwMwWt3jAuSt8tm24QfNCAl9bQGsRQABUDL0Q5UaXE4PIvgfnBn D3vBYjYGw1r+gX7osjwpSjIiA9BDMNryjmZAC8LpNtmu7tfCIX2Tk5+KNNf7AiHSGFk6 GrY8ejYcRwkSwRdwulaR20wWiG326+WH6wNo21dQRgd640Ung3NVdkyy2y3IfLtV4+Zn nTO2MyA6hlUFAIcu+rbfYzSxAo990Re6+JoKkCtDX6y54rWpCi2raTC0YtKazxeghP+E TPFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=CIBfRcnFx054fW8JQmzgBzXETA6VANTNtFCLzQ5Z9qw=; b=mz97OdUdAYCC70lfosZ9n/+4GiThg0En6lP4OL87gMMJoObP9wniIsU/ng8NOfgDsV m9VTeX2ilqOdBVkgF74ezVnK4omRKPvU1VKeerjXLBVpu6F6h7BhD7d77p0SkZkljquR J/lJkiE1NRmJGEuzyNdNmnQUYY0O5dMBgGwfQE0ktpE17euqVctSae9r3m5pfRTle+8F mFV12xatH2q9Fh3R3YHxDtGtz9I2eRk255CiTZtte4JO+ZcCx1BGjRDObXpC2cMWOcU2 k5l0gkLcUwWD5PtON47RGL85Y50WJbChazUvWR/nuLF+V/w8qYlC3mmoS4ea+1xK56oc NGrg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id c26si150081wmr.1.2021.07.08.09.28.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jul 2021 09:28:39 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 168GSdHl021083 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Jul 2021 18:28:39 +0200 Received: from [167.87.42.31] ([167.87.42.31]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 168GScjc007786; Thu, 8 Jul 2021 18:28:38 +0200 Subject: Re: [PATCH v1 5/5] events: Unmount all lost mounts at task fail To: Anton Mikanovich , isar-users@googlegroups.com References: <20210707163851.204296-1-amikan@ilbers.de> <20210707163851.204296-6-amikan@ilbers.de> <61de5d8d-08d4-9760-3467-d0313b3cb702@siemens.com> <61cdeb13-6c73-ba11-6085-81909163a477@ilbers.de> From: Jan Kiszka Message-ID: <24de0200-d23e-0fe4-9db1-d876ca6fa55a@siemens.com> Date: Thu, 8 Jul 2021 18:28:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <61cdeb13-6c73-ba11-6085-81909163a477@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: WX3I0KCSl+oR On 08.07.21 16:41, Anton Mikanovich wrote: > 08.07.2021 15:24, Jan Kiszka wrote: >> No looping, so everything you miss here will continue to be cleaned up >> by build_completed() - so what's the point of these changes? >> >> Jan >> > This is where WORKDIR will be unmounted to prevent double mount. > It in necessary to fix the original issue fixed by > d21d49578e5a3b0019075d1946bd93a95914fcca and explained in previous mails. > I do get the idea of a perfect world where a single attempt to umount works and cleanly pairs with the regular umount when the task succeeds. The problem is that I cannot see that this has been validate to truly catch the corner cases that the lazy, late-triggered scheme addresses so far. If it does not handle that, these umounts are pointless. If it does, we can drop the build_completed() handler. Having both indicates no progress, just more complexity. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux