From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6680483261914808320 X-Received: by 2002:ac2:43d8:: with SMTP id u24mr16280660lfl.94.1556088817568; Tue, 23 Apr 2019 23:53:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:894e:: with SMTP id b14ls1669410ljk.3.gmail; Tue, 23 Apr 2019 23:53:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtHt5D7bF7m5mh1xSklNIhvdMlsODxtlccg2VsgqNNhzirprZ1nTVDeJ/0QXXceeUGhEEf X-Received: by 2002:a2e:91cb:: with SMTP id u11mr7314873ljg.64.1556088816833; Tue, 23 Apr 2019 23:53:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556088816; cv=none; d=google.com; s=arc-20160816; b=y/hgiUYFXKc3qSVr6uR8/ylPW1pCHywiJCgtENSasNzTyY0sXyRtnS9ucE1zJLutQ7 y3pDUePiPlAO020gSj4CoDORcsOtcSAgpj/79RYIjb53aJ3pAlXSunJKOa8R0IrDNn+o pHngUHrPat2ofXxW4SxZdAsdVDLeV/TrpM8fcY5p9+zZCC8MW3myDG/IBoXXa/5nWqLw spUBON6LOYl8cjhz9GzOT47qWHjCkZWki5ukorYd6e4g9EGukkUWT8HU9jZBZkVHkt62 oE/rr9VV2OSfjOtrkIci9DcEIOA6rlGnURyR03Td8KMQA/fBvItVKq3eNiRMZ05ObYix KUzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=4fAKJYq4hkg8E+xgUnqy/t2z2rGvSM7Hw74l+o6VTxM=; b=vUfU7LQI9B2jB3W9ZWVa3dbh6K//YXuYmhhTw+u2TIrwf5XaYj2qui8EwCPOudzMJo 5o4HibpH7tsW6uuVlFHcackrmVGkoLktuOD9c4OD+U/YH8rJCvdoyXMi98daUdDBcAN3 sb7djd+22fDDhjXH1Gj/P8/csxwVRtGVbltvWZQBKNSNRwjb+21tHhtT99c0enqSMHlh EVZpFyNwsT9URepd3YQTm2t/WAPduN0m6Kah5jgcS8rtyoYYT1pmS5Xyr/lRGzvHezqS Bh2Y3ilNzZzOnZK4vlPD6yygBbtk5X8ZE9NcNbs+Wai/o/Zuwn8jaPUgJHphh/jr+Cnn h0Jw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id d3si232223lfk.5.2019.04.23.23.53.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 23:53:36 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x3O6rZ50024570 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 08:53:35 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x3O6rYZF016000; Wed, 24 Apr 2019 08:53:34 +0200 Subject: Re: [PATCH v2 0/8] Cleanup rootfs creation To: "Maxim Yu. Osipov" , isar-users@googlegroups.com Cc: Claudius Heine References: <20190417111159.2184-1-claudius.heine.ext@siemens.com> From: Claudius Heine Message-ID: <24e19870-6d4c-3258-e568-b8e77d7158e2@siemens.com> Date: Wed, 24 Apr 2019 08:53:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: sP+qMdTHaxxx Hi Maxim, On 22/04/2019 15.48, Maxim Yu. Osipov wrote: > The same problem with SDK creation discovered in v1 series persists also > in v2 series. > > Just recognized that "quick" CI build fails too. See for details: > http://isar-build.org:8080/job/isar_mosipov_develop/91/console > > Please run CI scripts before submitting patches to the mailing list - I did: http://isar-build.org:8080/job/isar_claudius_ilbers-ci/46/consoleText That build just fails because of the qemu boot where loading of modules fails for some reason, but you said that could be ignored. > this will save maintainer's time. Well if you are short on time, then I would suggest looking into better tooling. There are solutions that could automate most of the job you do as a maintainer, meaning loading patchset from mailinglist, processing it in CI and reporting results back to the mailinglist. Probably something like this: https://that.guru/blog/patchwork-and-ci-in-a-tree/ As I suggested months ago that patchwork can help safe time and avoid leaving any patches behind. If you don't look into solutions like that or write your own scripting, then I don't see much reason for you to complain. By doing that, you might even have enough time to start doing code reviews and taking part in design discussions etc. where it is much better invested that just pushing the "Run CI build" button and waiting for that to finish. To be fair I might do you injustice and you are performing thorough review of every ones patches and every ones code is just that excellent that only grammar and spelling mistakes in commit messages are left to critic, but then it might just be a matter of improving communication. Claudius > > Maxim. > > On 4/17/19 1:11 PM, claudius.heine.ext@siemens.com wrote: >> From: Claudius Heine >> >> Hi, >> >> this is the fixed up version. >> >> regards, >> Claudius >> >> changes from v1: >>   - fixed typo in commit message >> >> Claudius Heine (8): >>    isar-boostrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to >>      base.bbclass >>    move 'HOST_DISTRO_APT_SOURCES' from bootstrap-helper to isar-bootstrap >>    buildchroot.bbclass: only cross build if HOST_ARCH != DISTRO_ARCH >>    isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR >>    bitbake.conf: remove unneeded and differently used variables >>    image.bbclass: make IMAGE_ROOTFS overwritable >>    bitbake.conf: set default QEMU_ARCH variables >>    buildchroot/configscript: make creation of builder uid/gid idempotent >> >>   meta/classes/base.bbclass                          |  9 +++++++++ >>   meta/classes/buildchroot.bbclass                   |  2 +- >>   meta/classes/image-sdk-extension.bbclass           |  2 +- >>   meta/classes/image.bbclass                         |  2 +- >>   meta/classes/isar-bootstrap-helper.bbclass         | 14 -------------- >>   meta/conf/bitbake.conf                             | 13 ++++++++----- >>   .../isar-bootstrap/isar-bootstrap-host.bb          | 11 +++-------- >>   .../isar-bootstrap/isar-bootstrap-target.bb        |  6 +----- >>   .../recipes-core/isar-bootstrap/isar-bootstrap.inc |  1 + >>   .../buildchroot/buildchroot-host.bb                |  1 + >>   meta/recipes-devtools/buildchroot/buildchroot.inc  |  3 +-- >>   .../buildchroot/files/configscript.sh              |  4 ++-- >>   meta/recipes-devtools/sdkchroot/sdkchroot.bb       |  3 +-- >>   13 files changed, 30 insertions(+), 41 deletions(-) >> > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de