Re: [PATCH v2 2/2] opensbi-sifive-fu540: update to version 1.1

[Uladzimir Bely <ubely@ilbers.de>]

[-- Attachment #1: Type: text/plain, Size: 3339 bytes --]

In the email from Friday, 2 September 2022 16:26:15 +03 user Jan Kiszka wrote:
> On 02.09.22 09:58, Uladzimir Bely wrote:
> > This version includes a build fix for riscv64 against binutils >=2.38:
> > 
> > https://github.com/riscv-software-src/opensbi/commit/5d53b55
> > 
> > Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> > ---
> > 
> >  meta-isar/recipes-bsp/opensbi/files/sifive-fu540-rules        | 2 +-
> >  ...pensbi-sifive-fu540_0.9.bb => opensbi-sifive-fu540_1.1.bb} | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >  rename meta-isar/recipes-bsp/opensbi/{opensbi-sifive-fu540_0.9.bb =>
> >  opensbi-sifive-fu540_1.1.bb} (68%)> 
> > diff --git a/meta-isar/recipes-bsp/opensbi/files/sifive-fu540-rules
> > b/meta-isar/recipes-bsp/opensbi/files/sifive-fu540-rules index
> > 04e5b5ae..98bc1b49 100644
> > --- a/meta-isar/recipes-bsp/opensbi/files/sifive-fu540-rules
> > +++ b/meta-isar/recipes-bsp/opensbi/files/sifive-fu540-rules
> > @@ -5,7 +5,7 @@ export CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)-
> > 
> >  endif
> > 
> >  override_dh_auto_build:
> > -	CFLAGS= LDFLAGS= $(MAKE) $(PARALLEL_MAKE) PLATFORM=sifive/fu540 \
> > +	CFLAGS= LDFLAGS= $(MAKE) $(PARALLEL_MAKE) PLATFORM=generic \
> > 
> >  		FW_PAYLOAD_PATH=/usr/lib/u-boot/sifive_unleashed/u-boot.bin
> >  
> >  %:
> > diff --git a/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb
> > b/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_1.1.bb similarity
> > index 68%
> > rename from meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb
> > rename to meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_1.1.bb
> > index c25215be..92f75f2d 100644
> > --- a/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb
> > +++ b/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_1.1.bb
> > @@ -8,7 +8,7 @@ inherit dpkg
> > 
> >  SRC_URI = " \
> >  
> >      https://github.com/riscv/opensbi/archive/v${PV}.tar.gz;downloadfilena
> >      me=opensbi-${PV}.tar.gz \ file://sifive-fu540-rules"
> > 
> > -SRC_URI[sha256sum] =
> > "60f995cb3cd03e3cf5e649194d3395d0fe67499fd960a36cf7058a4efde686f0"
> > +SRC_URI[sha256sum] =
> > "d183cb890130983a4f01e75fc03ee4f7ea0e16a7923b8af9c6dff7deb2fedaec"> 
> >  S = "${WORKDIR}/opensbi-${PV}"
> > 
> > @@ -19,5 +19,5 @@ do_prepare_build() {
> > 
> >      cp ${WORKDIR}/sifive-fu540-rules ${WORKDIR}/rules
> >      deb_debianize
> > 
> > -    echo "build/platform/sifive/fu540/firmware/fw_payload.bin
> > /usr/lib/opensbi/sifive-fu540/" > ${S}/debian/install +    echo
> > "build/platform/generic/firmware/fw_payload.bin
> > /usr/lib/opensbi/sifive-fu540/" > ${S}/debian/install
>                             ^^^^^^^
> This looks suspicious. Are we still building the right configuration?
> 
> We have some fu540 somewhere. Could try to find it and test the image,
> but that may take some time.
> 
> Jan

Yes, it would be great. 

There was a change in opensbi that moved fu540 platform into some generic one ( https://
github.com/riscv-software-src/opensbi/commit/9a7a677[1] ), so I considered it in the patch, but 
don't have an opportunity to check it on real hardware.

Also, if you are on topic, you might advice some RISCV RISC-V that is worth buying and be 
supported in Isar. SiFive FU540 looks a bit outdated.

-- 
Uladzimir Bely


--------
[1] https://github.com/riscv-software-src/opensbi/commit/9a7a677

[-- Attachment #2: Type: text/html, Size: 9703 bytes --]