From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7032253102499561472 X-Received: by 2002:a7b:c7c6:: with SMTP id z6mr3989311wmk.173.1637819290636; Wed, 24 Nov 2021 21:48:10 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:1c7:: with SMTP id 190ls3703272wmb.3.canary-gmail; Wed, 24 Nov 2021 21:48:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2/DN3NpVbkaGkxkhNBQ8tJcRYpGlZlNwKGL7Zd1NKg21wBVIUQf85Vy17TPSzoLXMxkWA X-Received: by 2002:a05:600c:3c9b:: with SMTP id bg27mr3820594wmb.163.1637819289562; Wed, 24 Nov 2021 21:48:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637819289; cv=none; d=google.com; s=arc-20160816; b=BtH06Fb8TBMBFl2Gpr++ZzXvCyivltkN2KHXLDFn9sMFiNUP3henqsJiKmtmpYWx93 SzYCeTN+nYYTEylaTCUMNG93xx6YsIQxXMbVpugpyPfSkq75HijDBo1lM94pA8xjApze XeipHzMMVeQSTs719co/t35rNXfObi7FWLct35mGd9SEACRl7msCQht15vJLLABTcKoR HpOz2h0hngafvMzLQoz+SyME+F05UJc+LB/NF2qqHy4YW2TpdlCp8oHSbGh7XN4ywvsR c8FQxQOTptFadOwine92YEoOBmex9OY0STJdx3hHjiqO3sRtfU8UtqTtGTDfqD39XEUX L/aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=rDqpZ4pzbKD5sBhg94uDgNYG4xSHbTYJnCx8Hh/RsEw=; b=OG9IFc+m/e3JwxyeY9KbECl3Stv/7CFLKbSdTFk/hmcHBgCQPKOoTxaNonNg5kjw3z FEgpBdKGOLI0dkrfvND76LIVu4on0EsbXXzSgq2bU7q+c5GYgrAmUO79CVf9/s5r9hsO s0J8o6xAQNSOqTMqfxQswi6Sc0C+eF+qDUi/hAYVbxVb1Oh2U1SWVUsxLsUHzxDcwoS+ HPRanq2h5bvcyiYyV1574vbq/Nl+SWzTJqYMO0qKVm0EPBvNhWaFXEo7rjDjaZdufPHu UM5PXSjyNneZGsYXknzeRyGHh3XMRCuw3sIS6npzODbJcTB6VQW+l7iybF0hB3SAe8D/ a3ig== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id o19si325293wme.2.2021.11.24.21.48.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Nov 2021 21:48:09 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from hp.localnet (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1AP5m7Qs017464 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Nov 2021 06:48:08 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com, Jan Kiszka Subject: Re: [PATCH v2 04/24] linux-module: Do not use shell environment Date: Thu, 25 Nov 2021 08:47:42 +0300 Message-ID: <2567000.lGaqSPkdTl@hp> In-Reply-To: <1bc95be7-e603-966b-5326-962362548e2c@siemens.com> References: <20211119121333.13805-1-ubely@ilbers.de> <20211119121333.13805-5-ubely@ilbers.de> <1bc95be7-e603-966b-5326-962362548e2c@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: C07T/oPrrxa2 In mail from Friday, 19 Nov 2021 =D0=B3. 15:44:12 +03 user Jan Kiszka wrote: > On 19.11.21 13:13, Uladzimir Bely wrote: > > + > > + # restore execute permissions > > + chmod a+x ${S}/debian/rules >=20 > The mode should be fixed (aligned to the template) in template.bbclass > to avoid bothering every recipe with such boilerplate code. I'm seeing > this in other changes as well. >=20 > With all those "do not use shell env" - how will a downstream user > detect that a recipe is not properly converted? That looks like a nice > trap during migration to sbuild (because of silent / non-obvious errors). >=20 > Jan Regarding restoring permissions: this case can be covered by `[PATCH]=20 template: Make templates passthrough` (https://groups.google.com/u/0/g/isar= =2Dusers/c/Pmr2jUjviz8) which automatically keeps debian/.tmpl permis= sions=20 when transforming it to debian/. Internally, I've included this patch= =20 and removed all these parts with `chmod` from the recipes and it looks work= ing=20 (anyway, CI tests are still needed). And you are right, there might be some way to warn users about non-converte= d=20 downstream recipes. It is worth thinking. =2D-=20 Uladzimir Bely Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov