From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057120643105423360 X-Received: by 2002:a05:6512:692:b0:437:9580:9ab5 with SMTP id t18-20020a056512069200b0043795809ab5mr17242859lfe.689.1645532977720; Tue, 22 Feb 2022 04:29:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:2153:b0:443:9651:a9f4 with SMTP id s19-20020a056512215300b004439651a9f4ls2457311lfr.3.gmail; Tue, 22 Feb 2022 04:29:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQCs2L8yar7xxnPRde0xboZ2a5w72fBFWx4kjNek7MM0mIv810ouYANWK84OJs+wEX2FU0 X-Received: by 2002:ac2:50d0:0:b0:443:15cc:9f78 with SMTP id h16-20020ac250d0000000b0044315cc9f78mr16684539lfm.80.1645532976527; Tue, 22 Feb 2022 04:29:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645532976; cv=none; d=google.com; s=arc-20160816; b=pHzY8XGyZm0uJDwefKGWUNBmF6v0eTvYc1qRS+LFV2QOI8a/q3hEKID/EE39kM2BAR VmtLa47+lq7xJiAXC6SieA6lPwIKIevLkKd8ORM1QvwpmvBIbanOWDC4a4D9EzfICVpE wCKu2p7M1Aei59lhAQiD5hJu2HUFK3AS7v/TMJgzAyweGRjT6undFxS2IU7jIbAhaAlC /IDKGxKCpqY0g8QCaPIf3FWDyES9HBh80NLgD81wHUIUIA0EZBF9O8PtPF6zPb7bw2LQ vZqKLhodLCZaY61cMU762Ec/6pouocMkqj6Xhdja9mAxc0+Z28CjXjfxy7uoA4hSgNAM nqDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=JIkpJhJ1vUqlIiksM4c83PvD7KQvZEFYpB8aATA7pBg=; b=YZWtRqfUbhEPls8xwO0lLHr7eJIEfuw+VzRlzrNsYX0LB+H/pJSzvIkv9Kued8tOmi usVNxjPFfNEvw6MxtNzuejFHgxrsjwuCD9TQ+8i71PohwOH0gWHJlMut72klk0DiPlhd Pig5pNODMV5izjC9CGh+ApffBVtu79GMjEQwPgNUfiYLEpV2hSkN77npbe8eL2HoYoKG ACZVrfV+MY0ZoVT3avN3jO+yoiaF+iCrtYZVIPFRVgprLz7aoHcLbgUt7qLmqLvBzbQs /1NKEbSU2cH/Epq/5Y99h0OAxVV3URR15o8J9lw4u8hJjZ7Kpl6b4rbE/PksiIl7NwQf WHiQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id x24si454588ljh.2.2022.02.22.04.29.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Feb 2022 04:29:36 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 21MCTYkp020776 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Feb 2022 13:29:35 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com, Jan Kiszka Subject: Re: [PATCH v5 6/9] optee-os-stm32mp15x: Do not use shell environment Date: Tue, 22 Feb 2022 15:29:31 +0300 Message-ID: <2574298.lGaqSPkdTl@home> In-Reply-To: <57982af9-8bf0-227e-a170-acad96eb6a26@siemens.com> References: <20220213074111.23232-1-ubely@ilbers.de> <20220213074111.23232-7-ubely@ilbers.de> <57982af9-8bf0-227e-a170-acad96eb6a26@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 1ofUAOsCnYIq In the email from Tuesday, 22 February 2022 09:49:38 +03 user Jan Kiszka wrote: > On 13.02.22 08:41, Uladzimir Bely wrote: > > Move export of TEE_IMPL_VERSION variable directly to debian/rules. > > > > This makes building process more Debian-like. > > > > Signed-off-by: Uladzimir Bely > > --- > > > > meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb > > b/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb index > > 0fa2005d..9c0efaf1 100644 > > --- a/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb > > +++ b/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb > > @@ -21,5 +21,8 @@ OPTEE_BINARIES = "tee-header_v2.stm32 > > tee-pageable_v2.stm32 tee-pager_v2.stm32"> > > # Set version manually to PV, the tarball does not contain any hint. > > # Alternative: pull from git and add git as build dependency. > > dpkg_runbuild_prepend() { > > > > - export TEE_IMPL_VERSION=${PV} > > + cat << EOF >> ${S}/debian/rules > > + > > +export TEE_IMPL_VERSION=${PV} > > +EOF > > > > } > > I think I commented on this anti-pattern elsewhere already: This can > lead to piled-up extra lines in the target file. Now that it's merged, > please fix up on top, e.g. using a sed rule that avoids duplicate > patching or appending to the unpack step. > > Please also check if you used it elsewhere in fix those spots accordingly. > > Jan I tried to see the problem with line duplicates you are talking about and I couldn't reproduce it. Any way to invalidate do_build (recipe modification, manual task invalidation by bitbake, etc) makes ${S} to be renewed, so "old" lines are not presented here. So, this kind of export appears only once. -- Uladzimir Bely