From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com, roberto.foglietta@linuxteam.org
Subject: Re: [PATCH v2] imagetypes XZ_OPTIONS replaced by XZ_DEFAULTS defined in bitbake.conf
Date: Thu, 16 Feb 2023 07:30:45 +0300 [thread overview]
Message-ID: <25799860.1r3eYUQgxm@home> (raw)
In-Reply-To: <20230210111255.1508053-1-roberto.foglietta@linuxteam.org>
In the email from Friday, 10 February 2023 14:12:55 +03 user
roberto.foglietta@linuxteam.org wrote:
> From: Anton Mikanovich <amikan@ilbers.de>
>
> imagetypes, bugfix
>
> A previous patch moved XZ_ variables declarations into bitbake.conf from
> the imagetypes class. In such patch the XZ_OPTIONS has been renamed in
> XZ_DEFAULTS but the XZ_ command in imagetype class has not been updated.
> This patch fixed this bug which decreases performance and alters the
> expected behaviour.
>
> Fixes: 924aa382ca26 ("bitbake.conf: declare default XZ and ZSTD options")
>
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
> meta/classes/imagetypes.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/imagetypes.bbclass
> b/meta/classes/imagetypes.bbclass index 0cff440f..7d193d2e 100644
> --- a/meta/classes/imagetypes.bbclass
> +++ b/meta/classes/imagetypes.bbclass
> @@ -98,5 +98,5 @@ IMAGE_CONVERSIONS = "gz xz"
> CONVERSION_CMD:gz = "${SUDO_CHROOT} sh -c 'gzip -f -9 -n -c --rsyncable
> ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.gz'" CONVERSION_DEPS:gz =
> "gzip"
>
> -CONVERSION_CMD:xz = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_OPTIONS}
> ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.xz'" +CONVERSION_CMD:xz =
> "${SUDO_CHROOT} sh -c 'xz -c ${XZ_DEFAULTS} ${IMAGE_FILE_CHROOT} >
> ${IMAGE_FILE_CHROOT}.xz'" CONVERSION_DEPS:xz = "xz-utils"
Applied to next, thanks.
prev parent reply other threads:[~2023-02-16 4:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 11:12 roberto.foglietta
2023-02-16 4:30 ` Uladzimir Bely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25799860.1r3eYUQgxm@home \
--to=ubely@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=roberto.foglietta@linuxteam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox