From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7198483668640202752 X-Received: by 2002:a81:4894:0:b0:533:8d85:c5fa with SMTP id v142-20020a814894000000b005338d85c5famr2499ywa.209.1676521849435; Wed, 15 Feb 2023 20:30:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a81:554d:0:b0:52e:c2d1:c1dd with SMTP id j74-20020a81554d000000b0052ec2d1c1ddls289382ywb.11.-pod-prod-gmail; Wed, 15 Feb 2023 20:30:48 -0800 (PST) X-Google-Smtp-Source: AK7set/FAE1mQQdswVp8+0E1erI934wUwO6C3Kp5yuuqgIWY+MAHy6bgjn8KlRNImo4DwdvcmxrN X-Received: by 2002:a81:928b:0:b0:527:98b2:bcf with SMTP id j133-20020a81928b000000b0052798b20bcfmr3885495ywg.21.1676521848670; Wed, 15 Feb 2023 20:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676521848; cv=none; d=google.com; s=arc-20160816; b=swChVjJ1X/lx9OrUGj5H8PDOAUxN/bTbORdV/gA65UOcf/TaMCu9FVqABiCLRH9EFv oBBUrf8NE1oN761aeqx7N+19+D29DKBsb54ZwsH5o4q3h6VPFD3LqlRr+7rMjas3n+AX HoMxstIfm5kSXo0Dk8qkVb2UYZcLeZFJHnhHvzXEPMrpz0q9IaUJM+EhC092mh0BkHjW 11eqZCtON9JYWE1Ngxta8J6e4Bnz92HZkqTpLZMQp8IC8XcRXOMZ9bbZdwuqFtG4znOg j3BkT13nMSZIOnWdJcWQgSTTE6kT9sRj+FZNGVWmpn/ZEtKDDzGaIWY652l6mZ5avQpT tMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=wIsuS8TWT6/LWnYpjA0xzrOuozBSZA/k6LvLku14M9c=; b=ef8mf/byOiV9cKOIw1fQVvLSX+24CfPMKX3MRlhprKest8+fuBe1QP0ls1Q0bg9kcc MSX2Kx9DQXHHvQicQqMHOSw4RiToDnbJQFW4EHQTt7Q3UyYjHjQRamYxpMJFKWQiHwC5 YbinFl8KWdBM5Rzmb05nOyYTUKoivyUIu1O0ZLf/aOjCXtaq1s/0A2YjIkoVEmZ2EfPg rW0A9iNUXOj1jJ8iYJDq6H28Ru7A1KW7ys52qn/f3V0kxhAX1yg4EUIAavbrphTCiBil 3zvZckb7xwqoD06M9A+6lhs1F2c3/R5NIA+Td8o0M0qSDxQvYq8glG59B/TuwJpSR6sm 7SzA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id bo11-20020a05690c058b00b00530c24ddbdfsi27252ywb.1.2023.02.15.20.30.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Feb 2023 20:30:48 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 31G4UjrC016719 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 05:30:46 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com, roberto.foglietta@linuxteam.org Subject: Re: [PATCH v2] imagetypes XZ_OPTIONS replaced by XZ_DEFAULTS defined in bitbake.conf Date: Thu, 16 Feb 2023 07:30:45 +0300 Message-ID: <25799860.1r3eYUQgxm@home> In-Reply-To: <20230210111255.1508053-1-roberto.foglietta@linuxteam.org> References: <20230210111255.1508053-1-roberto.foglietta@linuxteam.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: SaOohkMr4XVr In the email from Friday, 10 February 2023 14:12:55 +03 user roberto.foglietta@linuxteam.org wrote: > From: Anton Mikanovich > > imagetypes, bugfix > > A previous patch moved XZ_ variables declarations into bitbake.conf from > the imagetypes class. In such patch the XZ_OPTIONS has been renamed in > XZ_DEFAULTS but the XZ_ command in imagetype class has not been updated. > This patch fixed this bug which decreases performance and alters the > expected behaviour. > > Fixes: 924aa382ca26 ("bitbake.conf: declare default XZ and ZSTD options") > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/imagetypes.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/imagetypes.bbclass > b/meta/classes/imagetypes.bbclass index 0cff440f..7d193d2e 100644 > --- a/meta/classes/imagetypes.bbclass > +++ b/meta/classes/imagetypes.bbclass > @@ -98,5 +98,5 @@ IMAGE_CONVERSIONS = "gz xz" > CONVERSION_CMD:gz = "${SUDO_CHROOT} sh -c 'gzip -f -9 -n -c --rsyncable > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.gz'" CONVERSION_DEPS:gz = > "gzip" > > -CONVERSION_CMD:xz = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_OPTIONS} > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.xz'" +CONVERSION_CMD:xz = > "${SUDO_CHROOT} sh -c 'xz -c ${XZ_DEFAULTS} ${IMAGE_FILE_CHROOT} > > ${IMAGE_FILE_CHROOT}.xz'" CONVERSION_DEPS:xz = "xz-utils" Applied to next, thanks.