* [PATCH] repository: make repo_del_srcpackage delete only source packages
@ 2024-02-23 9:42 Cedric Hombourger
2024-02-23 11:34 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Cedric Hombourger @ 2024-02-23 9:42 UTC (permalink / raw)
To: isar-users; +Cc: Cedric Hombourger
The reprepro removesrc command not only deletes the requested source
package but also any binary packages that were built from it. If
do_deploy_source is recalled after do_deploy_deb, we would see
previously deployed binary packages vanish from isar-apt.
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
---
meta/classes/repository.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/repository.bbclass b/meta/classes/repository.bbclass
index a61e5dcd..28e712fd 100644
--- a/meta/classes/repository.bbclass
+++ b/meta/classes/repository.bbclass
@@ -70,8 +70,8 @@ repo_del_srcpackage() {
if [ -n "${GNUPGHOME}" ]; then
export GNUPGHOME="${GNUPGHOME}"
fi
- reprepro -b "${dir}" --dbdir "${dbdir}" \
- removesrc "${codename}" \
+ reprepro -b "${dir}" --dbdir "${dbdir}" -A source \
+ remove "${codename}" \
"${packagename}"
}
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] repository: make repo_del_srcpackage delete only source packages
2024-02-23 9:42 [PATCH] repository: make repo_del_srcpackage delete only source packages Cedric Hombourger
@ 2024-02-23 11:34 ` Jan Kiszka
2024-02-23 11:52 ` cedric.hombourger
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2024-02-23 11:34 UTC (permalink / raw)
To: Cedric Hombourger, isar-users
On 23.02.24 10:42, 'Cedric Hombourger' via isar-users wrote:
> The reprepro removesrc command not only deletes the requested source
> package but also any binary packages that were built from it. If
> do_deploy_source is recalled after do_deploy_deb, we would see
> previously deployed binary packages vanish from isar-apt.
>
While I agree that a task should do what it is supposed to do, not more:
How is such a race possible? dpkg_build depends on deploy_source, and
deploy_deb depends on dpkg_build.
Jan
> Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
> ---
> meta/classes/repository.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/repository.bbclass b/meta/classes/repository.bbclass
> index a61e5dcd..28e712fd 100644
> --- a/meta/classes/repository.bbclass
> +++ b/meta/classes/repository.bbclass
> @@ -70,8 +70,8 @@ repo_del_srcpackage() {
> if [ -n "${GNUPGHOME}" ]; then
> export GNUPGHOME="${GNUPGHOME}"
> fi
> - reprepro -b "${dir}" --dbdir "${dbdir}" \
> - removesrc "${codename}" \
> + reprepro -b "${dir}" --dbdir "${dbdir}" -A source \
> + remove "${codename}" \
> "${packagename}"
> }
>
--
Siemens AG, Technology
Linux Expert Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] repository: make repo_del_srcpackage delete only source packages
2024-02-23 11:34 ` Jan Kiszka
@ 2024-02-23 11:52 ` cedric.hombourger
2024-02-23 12:23 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: cedric.hombourger @ 2024-02-23 11:52 UTC (permalink / raw)
To: isar-users, Kiszka, Jan
On Fri, 2024-02-23 at 12:34 +0100, Jan Kiszka wrote:
> On 23.02.24 10:42, 'Cedric Hombourger' via isar-users wrote:
> > The reprepro removesrc command not only deletes the requested
> > source
> > package but also any binary packages that were built from it. If
> > do_deploy_source is recalled after do_deploy_deb, we would see
> > previously deployed binary packages vanish from isar-apt.
> >
>
> While I agree that a task should do what it is supposed to do, not
> more:
> How is such a race possible? dpkg_build depends on deploy_source, and
> deploy_deb depends on dpkg_build.
There's no race. The issue will be seen if you bitbake -fc
deploy_source on a previously built recipe.
>
> Jan
>
> > Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
> > ---
> > meta/classes/repository.bbclass | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/classes/repository.bbclass
> > b/meta/classes/repository.bbclass
> > index a61e5dcd..28e712fd 100644
> > --- a/meta/classes/repository.bbclass
> > +++ b/meta/classes/repository.bbclass
> > @@ -70,8 +70,8 @@ repo_del_srcpackage() {
> > if [ -n "${GNUPGHOME}" ]; then
> > export GNUPGHOME="${GNUPGHOME}"
> > fi
> > - reprepro -b "${dir}" --dbdir "${dbdir}" \
> > - removesrc "${codename}" \
> > + reprepro -b "${dir}" --dbdir "${dbdir}" -A source \
> > + remove "${codename}" \
> > "${packagename}"
> > }
> >
>
--
Cedric Hombourger
Siemens AG
www.siemens.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] repository: make repo_del_srcpackage delete only source packages
2024-02-23 11:52 ` cedric.hombourger
@ 2024-02-23 12:23 ` Jan Kiszka
2024-02-26 7:07 ` [PATCH v2] " Cedric Hombourger
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2024-02-23 12:23 UTC (permalink / raw)
To: Hombourger, Cedric (DI CTO FDS CES LX), isar-users
On 23.02.24 12:52, Hombourger, Cedric (DI CTO FDS CES LX) wrote:
> On Fri, 2024-02-23 at 12:34 +0100, Jan Kiszka wrote:
>> On 23.02.24 10:42, 'Cedric Hombourger' via isar-users wrote:
>>> The reprepro removesrc command not only deletes the requested
>>> source
>>> package but also any binary packages that were built from it. If
>>> do_deploy_source is recalled after do_deploy_deb, we would see
>>> previously deployed binary packages vanish from isar-apt.
>>>
>>
>> While I agree that a task should do what it is supposed to do, not
>> more:
>> How is such a race possible? dpkg_build depends on deploy_source, and
>> deploy_deb depends on dpkg_build.
>
> There's no race. The issue will be seen if you bitbake -fc
> deploy_source on a previously built recipe.
>
Ok, this information is valuable to assess the criticality of the issue,
thus should go also into the commit message.
Jan
--
Siemens AG, Technology
Linux Expert Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] repository: make repo_del_srcpackage delete only source packages
2024-02-23 12:23 ` Jan Kiszka
@ 2024-02-26 7:07 ` Cedric Hombourger
2024-03-11 12:07 ` Uladzimir Bely
0 siblings, 1 reply; 6+ messages in thread
From: Cedric Hombourger @ 2024-02-26 7:07 UTC (permalink / raw)
To: isar-users; +Cc: Cedric Hombourger
The reprepro removesrc command not only deletes the requested source
package but also any binary packages that were built from it. If
do_deploy_source is recalled after do_deploy_deb, we would see
previously deployed binary packages vanish from isar-apt. This
incoherency was found by running bitbake -fc deploy_source after a
complete build of a recipe.
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
---
meta/classes/repository.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/repository.bbclass b/meta/classes/repository.bbclass
index a61e5dcd..28e712fd 100644
--- a/meta/classes/repository.bbclass
+++ b/meta/classes/repository.bbclass
@@ -70,8 +70,8 @@ repo_del_srcpackage() {
if [ -n "${GNUPGHOME}" ]; then
export GNUPGHOME="${GNUPGHOME}"
fi
- reprepro -b "${dir}" --dbdir "${dbdir}" \
- removesrc "${codename}" \
+ reprepro -b "${dir}" --dbdir "${dbdir}" -A source \
+ remove "${codename}" \
"${packagename}"
}
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] repository: make repo_del_srcpackage delete only source packages
2024-02-26 7:07 ` [PATCH v2] " Cedric Hombourger
@ 2024-03-11 12:07 ` Uladzimir Bely
0 siblings, 0 replies; 6+ messages in thread
From: Uladzimir Bely @ 2024-03-11 12:07 UTC (permalink / raw)
To: Cedric Hombourger, isar-users
On Mon, 2024-02-26 at 08:07 +0100, 'Cedric Hombourger' via isar-users
wrote:
> The reprepro removesrc command not only deletes the requested source
> package but also any binary packages that were built from it. If
> do_deploy_source is recalled after do_deploy_deb, we would see
> previously deployed binary packages vanish from isar-apt. This
> incoherency was found by running bitbake -fc deploy_source after a
> complete build of a recipe.
>
> Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
> ---
> meta/classes/repository.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/repository.bbclass
> b/meta/classes/repository.bbclass
> index a61e5dcd..28e712fd 100644
> --- a/meta/classes/repository.bbclass
> +++ b/meta/classes/repository.bbclass
> @@ -70,8 +70,8 @@ repo_del_srcpackage() {
> if [ -n "${GNUPGHOME}" ]; then
> export GNUPGHOME="${GNUPGHOME}"
> fi
> - reprepro -b "${dir}" --dbdir "${dbdir}" \
> - removesrc "${codename}" \
> + reprepro -b "${dir}" --dbdir "${dbdir}" -A source \
> + remove "${codename}" \
> "${packagename}"
> }
>
> --
> 2.39.2
>
Applied to next, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-11 12:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 9:42 [PATCH] repository: make repo_del_srcpackage delete only source packages Cedric Hombourger
2024-02-23 11:34 ` Jan Kiszka
2024-02-23 11:52 ` cedric.hombourger
2024-02-23 12:23 ` Jan Kiszka
2024-02-26 7:07 ` [PATCH v2] " Cedric Hombourger
2024-03-11 12:07 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox