Re: [PATCH v2] rootfs: Make rootfs finalize a separate task

[Jan Kiszka <jan.kiszka@siemens.com>]

On 11.02.20 15:14, vijai kumar wrote:
> 
> 
> On Tuesday, February 11, 2020 at 5:08:43 PM UTC+5:30, Henning Schild wrote:
> 
>     This patch will allow you to keep your apt downloading feature
>     downstream for yourself. I would say - propose it again together with
>     the feature.
> 
> 
> I can push that feature if it is needed upstream, which I doubt, since I
> don't vision an upstream use-case where-in one would need to
> download all the sources.

Providing an "all sources for my target" target is surely an upstream topic.

> 
> Also, It would need your base-apt series.
> 
> 
>     In fact if the feature was in Isar the whole problem would go away,
>     unless you have more postprocess functions.
> 
> 
> Yes. We have one per se for our QA layer. To export dpkg status file to
> deploy directory. This will be used by debsecan.
> 
> 
>     We discussed postprocessing a couple of times, it is really bad style
>     and enabling it as a feature that is easy to use we provoke downstream
>     layers making mistakes by implementing their stuff as such postprocess
>     functions.
> 
> 
> I see the ability to add custom post-processing as a useful feature.
> Not sure if anyone actually uses them in their downstream layers. It is
> good to have if you know what you are doing.
> 
> As long as this provision is there, people would use it. If we feel that 
> this
> provision is unnecessary and would lead to issues, well, we could go
> ahead and remove it.

Even if that hooking mechanism is a two-sided sword, there is already 
inside Isar value in defining a clean environment for the hooks and 
ensuring that this contains all mounts until the last hook is done. So, 
this patch can only be seen as the messenger, not to be shot for 
downstream misuse of the overall feature.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux