Re: Builds get fails when we append SWUPDATE yml file

[Florian Bezdeka <florian.bezdeka@siemens.com>]

On 30.09.21 12:50, Srinuvasan A wrote:
> Hi All and Henning,

if you need feedback from Henning you should add him at least to CC or
even better TO in this case. Otherwise he just might not read this mail.

> 
> Our downstream project isar-siemens SLLL and isar-cip-core get build
> failure when we include this commit 6fa0197
> <https://github.com/ilbers/isar/commit/6fa0197ac36a86b2ae5c27f5b7804dd9a46d3c0b>.
> The build get fails when we append SWUPDATE yml file.
> this will add the KERNEL_IMAGE and INITRD_IMAGE variable, this will
> defined in sw-description.tmpl file
> 
> TEMPLATE_VARS += "PN ROOTFS_PARTITION_NAME KERNEL_IMAGE INITRD_IMAGE"
> SWU_ADDITIONAL_FILES += "${INITRD_IMAGE} ${KERNEL_IMAGE}
> ${ROOTFS_PARTITION_NAME}"

Henning removed KERNEL_IMAGE and INITRD_IMAGE from the list of variables
available in wic files, that might be a breaking change, but it seems
ISAR itself (the ISAR layer) never used it, so it's kind of OK but
remains a breaking change.

You should be able to add something like "WICVARS += KERNEL_IMAGE
INITRD_IMAGE" to your layers (as temporary workaround)

> 
> when we add kas/opt/ebg-swu.yml file this will take the
> "https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/next/wic/simatic-ipc227e-efibootguard.wks
> <https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/next/wic/simatic-ipc227e-efibootguard.wks>"
> file.
> this will configure the wic pulgin as "part --source efibootguard-boot",
> in this script it is expecting those KERNEL_IMAGE and INITRD_IMAGE or
> otherwise it throws the error.
> 
> Failure logs below:
> 
> `DEBUG: Executing python function do_wic_image
> DEBUG: Executing shell function generate_wic_image
> INFO: Creating image(s)...
> 
> WARNING: KERNEL_IMAGE not set. Use default:
> WARNING: INITRD_IMAGE not set
> 
> ERROR: file vmlinuz not found in directory
> /build/tmp/deploy/images/simatic-ipc227e
> WARNING: exit code 1 from a shell command.
> ERROR: Error executing a python function in exec_python_func()
> autogenerated:
> 
> The stack trace of python calls that resulted in this exception/failure was:
> File: 'exec_python_func() autogenerated', lineno: 2, function:
> 0001:
> *** 0002:do_wic_image(d)
> 0003:
> File: '/work/isar/meta/classes/wic-img.bbclass', lineno: 141, function:
> do_wic_image
> 0137:}
> 0138:
> 0139:do_wic_image[file-checksums] += "${WKS_FILE_CHECKSUM}"
> 0140:python do_wic_image() {
> *** 0141: bb.build.exec_func("generate_wic_image", d)
> 0142: bb.build.exec_func("check_for_wic_warnings", d)
> 0143:}
> 0144:addtask wic_image before do_image after do_image_tools
> 0145:
> File: '/work/isar/bitbake/lib/bb/build.py', lineno: 251, function: exec_func
> 0247: with bb.utils.fileslocked(lockfiles):
> 0248: if ispython:
> 0249: exec_func_python(func, d, runfile, cwd=adir)
> 0250: else:
> *** 0251: exec_func_shell(func, d, runfile, cwd=adir)
> 0252:
> 0253: try:
> 0254: curcwd = os.getcwd()
> 0255: except:
> File: '/work/isar/bitbake/lib/bb/build.py', lineno: 452, function:
> exec_func_shell
> 0448: with open(fifopath, 'r+b', buffering=0) as fifo:
> 0449: try:
> 0450: bb.debug(2, "Executing shell function %s" % func)
> 0451: with open(os.devnull, 'r+') as stdin, logfile:
> *** 0452: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile,
> extrafiles=[(fifo,readfifo)])
> 0453: finally:
> 0454: os.unlink(fifopath)
> 0455:
> 0456: bb.debug(2, "Shell function %s finished" % func)
> File: '/work/isar/bitbake/lib/bb/process.py', lineno: 182, function: run
> 0178: if not stderr is None:
> 0179: stderr = stderr.decode("utf-8")
> 0180:
> 0181: if pipe.returncode != 0:
> *** 0182: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)
> 0183: return stdout, stderr
> Exception: bb.process.ExecutionError: Execution of
> '/build/tmp/work/ebsy-buster-amd64/ebsy-image-reference-simatic-ipc227e-wic-swu-img/1.0-r0/temp/run.generate_wic_image.157804'
> failed with exit code 1:
> INFO: Creating image(s)...
> 
> WARNING: KERNEL_IMAGE not set. Use default:
> WARNING: INITRD_IMAGE not set
> 
> ERROR: file vmlinuz not found in directory
> /build/tmp/deploy/images/simatic-ipc227e
> WARNING: exit code 1 from a shell command.
> 
> DEBUG: Python function do_wic_image finished
> `
> 
> Please revert back this commit.

As the affected commit is not in master yet we have all possibilities.
Reverting is one of them, but we could also consider adding that to the
release notes for the next release. That decision is up to the
maintainers I guess.

> 
> Thanks,
> Srinuvasan.A
> 
> -- 
> You received this message because you are subscribed to the Google
> Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to isar-users+unsubscribe@googlegroups.com
> <mailto:isar-users+unsubscribe@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/5ed36530-f7d3-4672-96ce-479f68d00b96n%40googlegroups.com
> <https://groups.google.com/d/msgid/isar-users/5ed36530-f7d3-4672-96ce-479f68d00b96n%40googlegroups.com?utm_medium=email&utm_source=footer>.


-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux