From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7191847640499224576 X-Received: by 2002:a17:902:ea08:b0:19a:acc7:4e8f with SMTP id s8-20020a170902ea0800b0019aacc74e8fmr979077plg.35.1676521780883; Wed, 15 Feb 2023 20:29:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90b:4b11:b0:233:f0f5:58cc with SMTP id lx17-20020a17090b4b1100b00233f0f558ccls4709039pjb.2.-pod-canary-gmail; Wed, 15 Feb 2023 20:29:40 -0800 (PST) X-Google-Smtp-Source: AK7set8+QIIcv/nswxP0P20vKHvL+3Qv2aHu32fys1c7Y3La0ykbwYESC4OMiho2W3aYn9LmsRt/ X-Received: by 2002:a17:902:e5c4:b0:19a:aed0:dca3 with SMTP id u4-20020a170902e5c400b0019aaed0dca3mr5430286plf.37.1676521779507; Wed, 15 Feb 2023 20:29:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676521779; cv=none; d=google.com; s=arc-20160816; b=HIDKnPwnWoh+397I3nUVpOxwZjMOd8LnlQJ6VyIToogJR2vVwqVgkDoccUlhx7RjS3 OlOO5m7L9ZujW4D7DR0a8wgMuornhOliE1Su6yg+Zy02qTEcAZbD8mHrFHzMSRgQTHNm ziHkqRW5Idy9lbpeMl6PsmS1BQd1bSFy2PnUXRYQ7kyVgVpQWoFIZw5/0WYB6Apgzclx Mn/CpfiV0ADPqY4xAPSezfInvcNvf4b+lK2G7T375reYMeKt//l3+05aHOPr06wWC5lP 3yJSbi8gxapOcJLEuqeuO081vnbPP8RwkT67uItTDwNRUyR/FIQhwBu0i694jsA/05MD UI7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=i2wZJEftyWxqUrv0P4tIGYMs7F5y8uvc8kmeVY0FH1Q=; b=Sq6IWcB57Y10lO95KoAKP+g6n2BI0ZL9SMeKzCxbiT3A7hcMWV1DV9K2p+AmFEWE8Q 8hxsaNKrVw34sc01oK+ljDVuuoDrPrpk4j1xc++C97f9YTEe0VigpIVGevIa/1K9jgib mlVjYYMD93JKZnJiF/aLhJwRLwyeXLqpNNTY8+AIkwQATMuAD7mK9pvOkhtzCd2hRzDU yeHIooqLtkDBjO8DCtQNi0WZyN/J48PcOr96dnojb9anwZIgxGpWW1aYCUaxOflsLpOh A4Px4g2TdNZ2xWQw1DiIhRLbp56ise4jhJRBgM6LMP6xB6JhCLuDVblIOOXDxOLBvvGd p6tQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id ky4-20020a170902f98400b0019a849a40b8si19782plb.6.2023.02.15.20.29.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Feb 2023 20:29:39 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 31G4Ta4N016695 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 05:29:36 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com Cc: Michael Adler Subject: Re: [PATCH v3] feat: add zstd support to image conversions Date: Thu, 16 Feb 2023 07:29:35 +0300 Message-ID: <2634994.vuYhMxLoTh@home> In-Reply-To: <20230210143326.267033-1-michael.adler@siemens.com> References: <20230210143326.267033-1-michael.adler@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: nMqnVyAniyrA In the email from Friday, 10 February 2023 17:33:26 +03 user Michael Adler wrote: > This patch enables ISAR to build zstd-compressed images. > > ISAR already supports building xz-compressed images but there are several > key differences between the two that may make one more suitable than the > other, depending on the specific use case: > > 1. Compression speed: zstd is generally faster than xz when it comes to both > compression and decompression times. > > 2. Compression ratio: "zstd and xz trade blows in their compression ratio. > Recompressing all [ArchLinux] packages to zstd with our options yields a > total ~0.8% increase in package size on all of our packages combined, but > the decompression time for all packages saw a ~1300% speedup." [1] > > 3. Memory usage: zstd uses a smaller amount of memory compared to xz. > > [1] > https://archlinux.org/news/now-using-zstandard-instead-of-xz-for-package-co > mpression/ > > Signed-off-by: Michael Adler > --- > meta/classes/imagetypes.bbclass | 5 ++++- > meta/conf/bitbake.conf | 3 +++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/imagetypes.bbclass > b/meta/classes/imagetypes.bbclass index 0cff440..c2033fd 100644 > --- a/meta/classes/imagetypes.bbclass > +++ b/meta/classes/imagetypes.bbclass > @@ -93,10 +93,13 @@ IMAGE_CMD:ubi() { > IMAGE_CMD:ubi[depends] = "${PN}:do_transform_template" > > # image conversions > -IMAGE_CONVERSIONS = "gz xz" > +IMAGE_CONVERSIONS = "gz xz zst" > > CONVERSION_CMD:gz = "${SUDO_CHROOT} sh -c 'gzip -f -9 -n -c --rsyncable > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.gz'" CONVERSION_DEPS:gz = > "gzip" > > CONVERSION_CMD:xz = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_OPTIONS} > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.xz'" CONVERSION_DEPS:xz = > "xz-utils" > + > +CONVERSION_CMD:zst = "${SUDO_CHROOT} sh -c 'zstd -c ${ZSTD_DEFAULTS} > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.zst'" +CONVERSION_DEPS:zst = > "zstd" > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 522241a..c9f52a8 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -140,6 +140,9 @@ XZ_DEFAULTS[vardepsexclude] += "XZ_MEMLIMIT XZ_THREADS" > # Default parallelism for zstd > ZSTD_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}" > ZSTD_THREADS[vardepvalue] = "1" > +ZSTD_LEVEL ?= "19" > +ZSTD_DEFAULTS ?= "-${ZSTD_LEVEL} --threads=${ZSTD_THREADS}" > +ZSTD_DEFAULTS[vardepsexclude] += "ZSTD_LEVEL ZSTD_THREADS" > > BBINCLUDELOGS ??= "yes" Applied to next, thanks.