From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750187537661165568 X-Received: by 2002:a5d:4d4a:: with SMTP id a10mr5722533wru.35.1573825136829; Fri, 15 Nov 2019 05:38:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:c447:: with SMTP id l7ls15569217wmi.1.canary-gmail; Fri, 15 Nov 2019 05:38:56 -0800 (PST) X-Google-Smtp-Source: APXvYqzdoD9RH/zOauE46D7xtndNvKp9VcXxzUAD0gQr4XGKoXrysex700LoxpXBGJRWV5BljqGk X-Received: by 2002:a1c:5603:: with SMTP id k3mr15853472wmb.150.1573825136182; Fri, 15 Nov 2019 05:38:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573825136; cv=none; d=google.com; s=arc-20160816; b=kVpDBF4Qb8a51E51dWUY5850TGneA4JE5IRYpNY8WyiP6G/toMAmWd0x+7Fiu/o4w2 IPdumRsxzp3GJMaMgjiWQbAvmTTQx7wDf25Ak5Ble8h1fVuELcyG7jzX0hAGFxEsa9jR 0x5IKtU4CsaPXjLMnQZzW0RcoQBkq3rOFmedO7l70Fj6w+WUXHKGWtFWV6iihIZayRRa oKrnnj6AEX1a+/ULcZvSzanaMuWavTYUz9qHIWhZMv6o6PSoICKUmdL5p0zrX48e0IYA V4pVQxAWIL7dFk/xo/phSRkAYavTl9pgKX+++OH33W7zORBPL3tMK3xiT9QObdfR1MY6 6G8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=DpSiZu0uLRS2lATN6p0nvVSegaHTXz42xssLFeGpLYA=; b=lJIXkBZ9MamvXxr7H2ezMbd4c0R0VYUSyTbOyM8APAa71VdW2cfpx9/8Pcf9sl11cV eqKQVcJtgT6qEICWJRTWTQ39d/8BunbXHXvFvfy8ipVV8aabRJW3v1ZEiwbLCk2sb0t7 1Nwh1cywjw0qqx7CjRTlMozR94Vb2M50ab3WUcRjmmwcNuF7+9nVIDzOL9DLlaZlUlCb jOy9ThO8hAo0PBUqTAEHpcXadkTJ0nU9ukIXgLplbzVB4veummOc07BakbtRE1AvsSNv eDgZeLPb/8VRut9T+IRwXJLSWYxHNa8qMoxxzJKrqDbcgzfJpuTlwmKbHKXpg3mQd20M 7CIA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id q128si562462wme.1.2019.11.15.05.38.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Nov 2019 05:38:56 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id xAFDctCP005380 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Nov 2019 14:38:55 +0100 Received: from [139.22.40.153] ([139.22.40.153]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xAFDctWQ028026; Fri, 15 Nov 2019 14:38:55 +0100 Subject: Re: [PATCH v4 - misc fixes 1/6] wic-img: do not leave temporary files behind To: Cedric Hombourger , isar-users@googlegroups.com References: <1572958385-246-1-git-send-email-Cedric_Hombourger@mentor.com> <1573205003-1335-1-git-send-email-Cedric_Hombourger@mentor.com> <1573205003-1335-2-git-send-email-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <26ab6076-157e-7573-919d-dfa7cb273b25@siemens.com> Date: Fri, 15 Nov 2019 14:38:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <1573205003-1335-2-git-send-email-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: hu0gEU1Cz/3k On 08.11.19 10:23, Cedric Hombourger wrote: > We do not seem to make any use of the timestamped wic images being > generated and worse we are leaving them in the buildchroot tmp folder. > "mv" the generated files instead of "cp"'ing them to the deploy > directory. > > Signed-off-by: Cedric Hombourger > --- > meta/classes/wic-img.bbclass | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass > index 795640f..24c3b65 100644 > --- a/meta/classes/wic-img.bbclass > +++ b/meta/classes/wic-img.bbclass > @@ -155,8 +155,12 @@ EOSUDO > -e ${IMAGE_BASENAME} ${WIC_CREATE_EXTRA_ARGS} > sudo chown -R $(stat -c "%U" ${ISARROOT}) ${ISARROOT}/meta ${ISARROOT}/meta-isar ${ISARROOT}/scripts || true > WIC_DIRECT=$(ls -t -1 ${BUILDCHROOT_DIR}/$WICTMP/${IMAGE_FULLNAME}.wic/*.direct | head -1) > - cp -f ${WIC_DIRECT} ${WIC_IMAGE_FILE} > - cp -f ${WIC_DIRECT}.bmap ${WIC_IMAGE_FILE}.bmap > + sudo chown $(stat -c "%U:%G" ${ISARROOT}) ${WIC_DIRECT} ${WIC_DIRECT}.bmap > + sudo mv -f ${WIC_DIRECT} ${WIC_IMAGE_FILE} > + sudo mv -f ${WIC_DIRECT}.bmap ${WIC_IMAGE_FILE}.bmap > + sudo rmdir --ignore-fail-on-non-empty \ > + ${BUILDCHROOT_DIR}/${WICTMP}/${IMAGE_FULLNAME}.wic \ > + ${BUILDCHROOT_DIR}/${WICTMP} Where does the need for the sudos come from? What are source and target users here? Jan > } > > do_wic_image[file-checksums] += "${WKS_FILE_CHECKSUM}" > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux