From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520143438976909312 X-Received: by 10.223.134.137 with SMTP id 9mr151106wrx.25.1518103463815; Thu, 08 Feb 2018 07:24:23 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.26.132 with SMTP id a126ls1055574wma.1.canary-gmail; Thu, 08 Feb 2018 07:24:23 -0800 (PST) X-Google-Smtp-Source: AH8x227sCRAQkCRgTaR3LgQeIYXQTAWqLTaIAM9V/pYtwT9IfXXIMaH9oInXFEEkIUv9rXkgJm1c X-Received: by 10.28.178.207 with SMTP id b198mr195213wmf.0.1518103463303; Thu, 08 Feb 2018 07:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518103463; cv=none; d=google.com; s=arc-20160816; b=CXzKR7Po/CKDobIyp/V7Ev2RmgEPjjiUis53VdB6Jf3f7aVwjZU7IaiqRZ2+OmdHNX Ooc0TBZhRsXTue0KTeAARPF5jmglbfribxCHPFs/xtJ0+dl5XbqgiwqulYWQKDx0jnG/ Sd7z9IusG6r4hACMPXyOdbAir6oz+rh7FlbhEh2e0vkuKAqwXvuEUuR1a5c4CrbHQ4Uq a1H5p5zauJEBW8LszEon/M8iCusaIBl1dZE07G68NfitcctQmXBiWbi6eXCtWHtQozMT s8VBBdUPUCrS3/tTT6RkvaaVJ/ma9hf8VcOS0+5rJagHwOgZJ/FFcGI4/bJr67y18W0u EcjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=d9LcG9Jsg7DqGYIH2kxCw3iipraSBWDJePlJANtHAM8=; b=rebCwwUiaTfVpq9Ux6qnr9JAMmQT658PGQ+gHlcEo3Fq5FD43+y1XDqYrnnSB5IVoy JoGfMUSINjfOqvCtL3o3rjnjmC2T3nrQ6wKv5CXkSGs5KoFtwjCUiKxaktXj19oTykHj QwTHaGDKdr4mDjsTunFvgAhr0cbNrrRRCHsUadVp+FBqJ3btYWrPfkI20rfCJXnk5vto rwyrDC2xBsgYRDxJ2et9oQV95DtkGeoV9Ooj4THEW0YrcmXWL75wvXosmFFDfJ18L270 GGnmO7LpT/87q+JHG4+XTFXQ5niOPAQ2UBTVgRxSCvj9Dmu0Nygt/XxbVCWt3//8wWbp 9gFw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id e14si23241wmg.0.2018.02.08.07.24.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 07:24:23 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w18FOMDM029972 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Feb 2018 16:24:22 +0100 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w18FOLoZ027529; Thu, 8 Feb 2018 16:24:21 +0100 Subject: Re: [PATCH] meta/classes/base: Fix showdata and liststasks after bitbake update To: Alexander Smirnov , isar-users@googlegroups.com Cc: Claudius Heine References: <20180208112622.3373-1-claudius.heine.ext@siemens.com> From: Claudius Heine Message-ID: <26d4eb02-20c1-c6a4-8c7a-f040d4c2d51d@siemens.com> Date: Thu, 8 Feb 2018 16:24:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: GwpwQrmAkMij Hi Alex, On 02/08/2018 02:55 PM, Alexander Smirnov wrote: > Hi, > > On 02/08/2018 02:26 PM, claudius.heine.ext@siemens.com wrote: >> From: Claudius Heine >> >> Those tasks were broken, this patchs fixes by implementing them similar >> to how openembedded-core does it. >> > > I see that this code is identical to OE one, do you know which copyright > it is? If this code is copied from OE, I think it makes sense to mention > this explicitly in the code. Sure, I got it from [1], and this file does not have an own header, so I suppose its MIT or GPLv2. I don't know if this falls under 'metadata' or not. Since Isar uses the same licenses, you might know what exactly is meant by that. How are you proposing to name the authors? Cheers, Claudius [1] http://git.openembedded.org/openembedded-core/tree/meta/classes/utility-tasks.bbclass > > Alex > >> Signed-off-by: Claudius Heine >> --- >>   meta/classes/base.bbclass | 28 +++++++++++++++++----------- >>   1 file changed, 17 insertions(+), 11 deletions(-) >> >> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >> index 7d44f72..448dd67 100644 >> --- a/meta/classes/base.bbclass >> +++ b/meta/classes/base.bbclass >> @@ -40,22 +40,28 @@ bbfatal() { >>   addtask showdata >>   do_showdata[nostamp] = "1" >>   python do_showdata() { >> -    import sys >> -    # emit variables and shell functions >> -    bb.data.emit_env(sys.__stdout__, d, True) >> -    # emit the metadata which isnt valid shell >> -    for e in bb.data.keys(d): >> -        if bb.data.getVarFlag(e, 'python', d): >> -            sys.__stdout__.write("\npython %s () {\n%s}\n" % (e, >> bb.data.getVar(e, d, 1))) >> +    for e in d.keys(): >> +        if d.getVarFlag(e, 'python'): >> +            bb.plain("\npython %s () {\n%s}\n" % (e, d.getVar(e, True))) >>   } >>   addtask listtasks >>   do_listtasks[nostamp] = "1" >>   python do_listtasks() { >> -    import sys >> -    for e in bb.data.keys(d): >> -        if bb.data.getVarFlag(e, 'task', d): >> -            sys.__stdout__.write("%s\n" % e) >> +    taskdescs = {} >> +    maxlen = 0 >> +    for e in d.keys(): >> +        if d.getVarFlag(e, 'task'): >> +            maxlen = max(maxlen, len(e)) >> +            if e.endswith('_setscene'): >> +                desc = "%s (setscene version)" % >> (d.getVarFlag(e[:-9], 'doc') or '') >> +            else: >> +                desc = d.getVarFlag(e, 'doc') or '' >> +            taskdescs[e] = desc >> + >> +    tasks = sorted(taskdescs.keys()) >> +    for taskname in tasks: >> +        bb.plain("%s  %s" % (taskname.ljust(maxlen), >> taskdescs[taskname])) >>   } >>   do_fetch[dirs] = "${DL_DIR}" >> -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de