From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6672285328798121984 X-Received: by 2002:a17:906:18a1:: with SMTP id c1mr9291668ejf.116.1553540882423; Mon, 25 Mar 2019 12:08:02 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:8ebb:: with SMTP id w56ls2215546edw.2.gmail; Mon, 25 Mar 2019 12:08:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxyIQ3v72UKeIJ5LUVvED8EStPJJtwgWnvrQ8nmIuNQ3QIUeildmjvtthuEGFYwD5gixq4 X-Received: by 2002:a50:f419:: with SMTP id r25mr17897770edm.250.1553540881998; Mon, 25 Mar 2019 12:08:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553540881; cv=none; d=google.com; s=arc-20160816; b=riXzXt7mIGIIdphPANA/T0X1eivj6z5r1vTbxMeztxUH9PO4PS27vjY7laPpDqX38X w54VNx53S1iYkWQ5/SF6F+yIvGAcczk7MYAdT9dF1q//hmYbXkphLGdIkIGSv8/htWFU lofmBY8WbDoPqJHVK/LfZMkV/vtcwocqmZ22Uz7qZUNIZ1xz+PfZIiT9hFQLOL5bgzjN DMSFbsvUi3ml/6MdDwLHAsOOCi5bwr8VFaQpYgp9LVrblOgt1RM+g5Qzx6MFoUOCHQbM UPpRx/VF6LNDvn3iW0ZgaU0MboAcxwxcFmRBTqdL9rFi7k3TvvqIeW33rdLHFN0LBCa2 Vksg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=MDfydyFnmkJuwVRlOApAUuJh8M+WJWMGDBs3vSGtKGM=; b=i+M7dxjzk3UCyJgiRa8DJIsURSgv5Om4zk3UC5ERootP95AdbF1F2tPW9K/pNKjtbm jTxWuFv45ZpGYWeJuNVQlax2vPIMP+cUTpqfQXyG6trbEUnUcgDGj1/TJJkIjad0gZcN YXpCTu7Qc+TL8dD0My/pQHFrIM01Utf/rSpmDvxEG8uDI4XxlzG2L5ZzODULXRu3yyBd yM4Oah0nUwnx/JpxIlhSWUQArrN3XFQNeVC8kOcWnQuU0N5SdRwWGJmvug7cgakxX2/J Arnp88nyWgzqJUZQSnfhBYcqqJvnhKXgc1/KoE6oq7UJzSszBk2e1zSfoeuDP9SpYi6l Ttcg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id a5si961344edn.3.2019.03.25.12.08.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 12:08:01 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.164] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2PJ80ba019957 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Mar 2019 20:08:00 +0100 Subject: Re: [PATCH] template: Remove MACHINE from default TEMPLATE_VARS To: Jan Kiszka , isar-users , Claudius Heine References: <28bc18bf-0f28-3470-3253-41cb5069b1d1@web.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <271de745-1ffc-acb3-43fc-921c6207472b@ilbers.de> Date: Mon, 25 Mar 2019 20:08:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <28bc18bf-0f28-3470-3253-41cb5069b1d1@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Bpcq+KJcogik On 3/25/19 12:14 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This breaks packages, even those not using templating, when they are > pulled via multiconfig by different machines of the same arch. As the > MACHINE variable differs, bitbake first builds do_transform_template > multiple times, and then everything that follows after, including > standard packages like isar-cfg-* or expand-on-first-boot. Those are > shared, use only a single workdir, and will quickly break of built > concurrently. Applied to the 'next'. Thanks, Maxim. > Fixes: 43b4c21aa185 ("meta: added do_transform_template task as templating system and switch") > Signed-off-by: Jan Kiszka > --- > meta/classes/template.bbclass | 3 +-- > meta/recipes-bsp/u-boot/u-boot-custom.inc | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass > index 324511a..3eb9114 100644 > --- a/meta/classes/template.bbclass > +++ b/meta/classes/template.bbclass > @@ -4,8 +4,7 @@ > # SPDX-License-Identifier: MIT > > TEMPLATE_FILES ?= "" > -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME MACHINE \ > - DISTRO_ARCH" > +TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME DISTRO_ARCH" > > do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" > do_transform_template[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > index 1afe430..b3eab46 100644 > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > @@ -19,7 +19,7 @@ BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > > TEMPLATE_FILES = "debian/changelog.tmpl \ > debian/control.tmpl" > -TEMPLATE_VARS += "BUILD_DEPENDS" > +TEMPLATE_VARS += "MACHINE BUILD_DEPENDS" > > do_prepare_build() { > cp -r ${WORKDIR}/debian ${S}/ > -- > 2.16.4 > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov