From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7189000421229199360 X-Received: by 2002:a17:906:3bd8:b0:7b2:b5aa:f1e0 with SMTP id v24-20020a1709063bd800b007b2b5aaf1e0mr252978ejf.54.1673956421629; Tue, 17 Jan 2023 03:53:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:520a:b0:43d:b3c4:cd21 with SMTP id s10-20020a056402520a00b0043db3c4cd21ls1363823edd.2.-pod-prod-gmail; Tue, 17 Jan 2023 03:53:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXsn//en8KNBgfglSB5rkN02jxs/VkakCIRUj1p/nxQEoKMcAJCvYG7GWYBGNzQyygbNInHB X-Received: by 2002:aa7:ccd9:0:b0:495:d1f4:7609 with SMTP id y25-20020aa7ccd9000000b00495d1f47609mr13596866edt.19.1673956420485; Tue, 17 Jan 2023 03:53:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673956420; cv=none; d=google.com; s=arc-20160816; b=WGnReobDWNIbKhl3XMFTBR8ojNJMqwqM8FHoXK/43NckUdG5u/sLhcffAVLpYG7pyj Jzv0hjTHNbg/nMXy6QqiYXzAHVMyNn92iVX3QIBPCN4CGjkZI580rspj5/9TI1e8WvW0 4Tbe3mBJKpV7pkYVX6ltUac8Vdr0s6UiLght5HTOcftr6pHURP1j8dqCNCFQboDb9G+2 U/D12h8pR57ESS1iQDY490AgtN0trXngStdicQoKbnQaYthzR8+e0M+rcIjVshf/EjLN 3MMcMkulSL7vW4o+xDS81sfD04A2lDK5gS1VZXY5yNXfinmkIFp663IXfiCxT+uydeO6 Cj+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=MEWzpmgXJ5kpS3ns+KkdKOnoOqtn6O+27yv7Sp7cTWo=; b=SDL6f5/2/X7AoioSb00VyySmq/Rj0XVFRyaMsFXIXIoY/myMCGuK30CACixWgGwcgU mCIcXMIkF75yvwVCHgMIDWPupo35jZX116C64rixxY1T2HKPpHxQgZ4Ua6qSB3BLOXlM J8d+xxVjG+AO2xj048sA2gJYrR+lRg5fm0GrxBOF8OLhYorjRZ6zJEAA5+P+taVwM1Gh WO0BJCzO2/AkQRT84ajaMOdaQ7dfzndeimDaK8t5946fCQIx1dJeb8hQG7Id5SJVde5V SdlXAw9eMHJBfMDhU5WOMyxu9u9hYxEhES1znnVzS1XjgvJbUK9k/v5pJzXP+re91kHk D1VA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=blWl2IXa; spf=pass (google.com: domain of fm-68982-202301171153402030ce08b6f379ab57-gvjs5h@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-68982-202301171153402030ce08b6f379ab57-gVJs5h@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net. [185.136.64.227]) by gmr-mx.google.com with ESMTPS id jy28-20020a170907763c00b0086e09d5ce59si362488ejc.2.2023.01.17.03.53.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2023 03:53:40 -0800 (PST) Received-SPF: pass (google.com: domain of fm-68982-202301171153402030ce08b6f379ab57-gvjs5h@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) client-ip=185.136.64.227; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=blWl2IXa; spf=pass (google.com: domain of fm-68982-202301171153402030ce08b6f379ab57-gvjs5h@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-68982-202301171153402030ce08b6f379ab57-gVJs5h@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 202301171153402030ce08b6f379ab57 for ; Tue, 17 Jan 2023 12:53:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=florian.bezdeka@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=MEWzpmgXJ5kpS3ns+KkdKOnoOqtn6O+27yv7Sp7cTWo=; b=blWl2IXa8rfAhqDZO8TGA4mU4N8beQb3kkJGn+0Ili/6HEDTunOAB4Yv1O7RYCcOPhzPHo ni4gchxdwsuqhRYApwy7KZaw8sxaVysZetJCI1SMDZre3U58HT3AyD0BOSK6+D6o6joISGhp 33opiiOdW58PQGtQhTHwxYUx8p/wo=; Message-ID: <27337f043bddfad8dbc2c166fe1932ed45398c47.camel@siemens.com> Subject: Re: [PATCH v6] suggested changes for reproducibility patchset v6 From: Florian Bezdeka To: "Roberto A. Foglietta" Cc: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com Date: Tue, 17 Jan 2023 12:53:39 +0100 In-Reply-To: References: <20230115215310.732295-1-roberto.foglietta@linuxteam.org> <551831fb188675b0c6d1a879f1a8b251efce4e4a.camel@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-TUID: 5q5VZs13xjqr On Sun, 2023-01-15 at 23:46 +0100, Roberto A. Foglietta wrote: > On Sun, 15 Jan 2023 at 23:32, Florian Bezdeka > wrote: > >=20 > > On Sun, 2023-01-15 at 22:53 +0100, roberto.foglietta@linuxteam.org > > wrote: > > > From: "Roberto A. Foglietta" > > >=20 > > > suggested changes for reproducibility patchset > > >=20 > > > WARNING: eval-image-1.0-r0 do_rootfs_finalize: modified timestamp > > > (1673628837) of 3 files for image reproducibly > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0List of files modified could be fou= nd here: > > > ./build/tmp/deploy/images/debx86/files.modified_timestamps > > >=20 > >=20 > > Can't follow. Patches / Commits need proper description (=3D commit > > message). I guess you fixed a warning, but the warning itself (=3D > > list > > of modified files) was inside the mentioned file, so we have to > > guess > > what changed? > >=20 >=20 > Do not worry, I will do a proper patch when your changes will be > included into ilbers/next - this is just a suggestion for Felix >=20 > @Felix=C2=A0 > There is no reason to show a warning of long N files but just a > summary with the name of the file to check. > Please forget the v6 because it got out prematurely. I just sent the > v7. > Keep in consideration that in my building after the image > finalize,=C2=A0do_install_imager_deps runs and mess-up things. > It is something that I need to investigate. >=20 >=20 > > >=20 > > > v.6: the 1st part of the warning shows up each time the epoch is > > > used > > > =C2=A0 =C2=A0 =C2=A0while the 2nd line appears only when some files h= as been > > > touched > > > =C2=A0 =C2=A0 =C2=A0This allows the user to know the current situatio= n aboat > > > epoch. > >=20 > > Version information does not belong here. See below. > >=20 > > >=20 > > > Signed-off-by: Roberto A. Foglietta > > > --- > >=20 > > Comments like changes between versions of your patches should be > > mentioned here. Not inside the commit message. > >=20 >=20 > Ok, it seems weird to me but it probably is a standard that automatic > software needs. Is that right? This is how "git am" works. Everything above the "---" line will go into the commit message (should be used for story telling), everything below that line and in front of the first hunk will be thrown away and can be used for further comments/hints for reviewers/maintainers.