Re: [PATCH v2 0/9] Avoid using shell environment during the build

[Uladzimir Bely <ubely@ilbers.de>]

In the email from вторник, 25 января 2022 г. 16:29:28 +03 user Jan Kiszka 
wrote:
> On 25.01.22 13:32, Uladzimir Bely wrote:
> > This patchset is a subseries of 'Sbuild/Schroot migration' patchset
> > including only preparation patches. It doesn't require any changes
> > in host machine configuration for downstreams (meta-iot2050 and
> > xenomai-images were tested) so can be merged independently.
> > 
> > In this patchset the main topic is a migration to template files that
> > allows to use cleaner build environment.
> > 
> > When this patchset is merged, it will make maintenance of remaining
> > sbuild-related patches easier and will shorten their number.
> > 
> > Changes since v1:
> > - Introduced `dpkg_build_export` function to be used for passing
> > variables to build environment;
> 
> I wonder - as just written in the iot2050 PR - if we have any chance to
> detect old exports and warn the user if their recipes need to be
> converted to dpkg_build_export. Any ideas?
> 
> Jan
> 

That's an interesting question. If we could make a hook that could intercept 
any 'export' call in dpkg_runbuild (usually, in _prepend), we could make a 
warning. On the other hand, in this case we could not introduce a new 
function, but just do what we really need instead of doing shell export.

For now I have no ideas how we could do it.

> > - Linux kernel framgments handling is done in Debian way.
> > 
> > Anton Mikanovich (6):
> >    linux-module: Do not use shell environment
> >    u-boot: Do not use shell environment
> >    trusted-firmware: Do not use shell environment
> >    optee-os: Do not use shell environment
> >    kselftest: Do not use shell environment
> >    linux-mainline: Move cfg fragment test to debian/rules
> > 
> > Uladzimir Bely (3):
> >    template: Copy template attributes on transform
> >    dpkg: Use a specific export function in pre-build tasks
> >    linux-custom: Move cfg fragments applying to debian/rules
> >   
> >   meta-isar/recipes-app/hello/hello.bb          |  2 +-
> >   .../optee-os/optee-os-stm32mp15x_3.11.0.bb    |  2 +-
> >   .../linux/linux-mainline_5.4.70.bb            | 16 +++---
> >   meta/classes/dpkg-base.bbclass                |  9 ++++
> >   meta/classes/dpkg.bbclass                     |  2 +-
> >   meta/classes/template.bbclass                 |  4 +-
> >   .../libubootenv/libubootenv_0.3-3.bb          |  2 +-
> >   .../files/debian/{rules => rules.tmpl}        |  4 +-
> >   meta/recipes-bsp/optee-os/optee-os-custom.inc |  9 +---
> >   .../files/debian/{rules => rules.tmpl}        |  4 +-
> >   .../trusted-firmware-a-custom.inc             |  9 +---
> >   .../u-boot/files/debian/{rules => rules.tmpl} |  2 +-
> >   meta/recipes-bsp/u-boot/u-boot-custom.inc     |  9 +---
> >   .../kselftest/files/{rules => rules.tmpl}     |  0
> >   meta/recipes-kernel/kselftest/kselftest.inc   | 21 +++-----
> >   .../linux-module/files/debian/rules           | 37 -------------
> >   .../linux-module/files/debian/rules.tmpl      | 52 +++++++++++++++++++
> >   meta/recipes-kernel/linux-module/module.inc   | 19 ++-----
> >   .../linux/files/debian/isar/configure.tmpl    | 19 +++++++
> >   .../linux/files/debian/rules.tmpl             |  3 ++
> >   meta/recipes-kernel/linux/linux-custom.inc    | 14 ++---
> >   21 files changed, 125 insertions(+), 114 deletions(-)
> >   rename meta/recipes-bsp/optee-os/files/debian/{rules => rules.tmpl}
> >   (75%)
> >   rename meta/recipes-bsp/trusted-firmware-a/files/debian/{rules =>
> >   rules.tmpl} (77%) rename meta/recipes-bsp/u-boot/files/debian/{rules =>
> >   rules.tmpl} (94%) rename meta/recipes-kernel/kselftest/files/{rules =>
> >   rules.tmpl} (100%) delete mode 100755
> >   meta/recipes-kernel/linux-module/files/debian/rules create mode 100755
> >   meta/recipes-kernel/linux-module/files/debian/rules.tmpl create mode
> >   100644 meta/recipes-kernel/linux/files/debian/isar/configure.tmpl