From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057120643105423360 X-Received: by 2002:a05:6000:1885:: with SMTP id a5mr14374194wri.656.1643118695078; Tue, 25 Jan 2022 05:51:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:448f:: with SMTP id j15ls379066wrq.3.gmail; Tue, 25 Jan 2022 05:51:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyemmiuUrvcq5rPIkg34VNzPBivFmPraYoBRoVwumzmgkURJDrP9v9b90Ze8gwFsQsVcMoG X-Received: by 2002:a05:6000:1787:: with SMTP id e7mr18823534wrg.710.1643118694091; Tue, 25 Jan 2022 05:51:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643118694; cv=none; d=google.com; s=arc-20160816; b=NUzIiKTFI02+tLtaiptTJmKTRYBWzBNOcpLelWSKTdzjxaJm8DDaxUndRHZcwB2zZP rbLXJwHMVAYxFiqhU+gLZD+xEUheaZ0LmRUqB3ht+K7pH69rVPBJyPy5+PQ+y6IznIW0 cp16a08DSNfYWNVix2o59Kk5YeLh4oO9/2MQGCPSapgHuHdraISY5MEyMeHRp8AQR+3m PR0VZn3QBsSWY6nxmwvojCNcj+9kmKaNs8I9loiF3HAnOX6C7QKUTGF2z4QhdgUlWruL O4iZZZNiqC+j1wDPSLK//OY6VgXjjS0lpwgFvj8PBnRvBYsWjpLGfA2Hx845fTqN67Vo mv8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=5aXAPRFOzlUauG+ysvnNjRqTyk62jnDcWvNF2G2+bNw=; b=oB/2lxzmJdr19TadFewsUnp7K69I+LvSLMRWgW4KlzQliSQsF8qJfRlnGiw6g+AXgG de1BzmWND6yQNmFaTrU8i72us7gPm2gOJydt3Bg0bG8zpsxz1xy9Lza0jJCEbWI0wO9r 8lCavMVvziiiN9kM1uHFdUsRQCKmzlEyhCIFFAGJwR4hvN7Fhy8h3G/Ir4azpETiv0b/ qk5cLv9zf+qs8gxltx2iGhEYXavSEyl4r9X+jvloKcRTmb9nx06iItfbSSAishTJteFY ZB0RTRukB75oVeA4C8LudphEpGz/pzRVz6D/97Rehdss2+DKD/KAix5dKSOq7oCZ9HA6 EHeA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id h16si25051wml.0.2022.01.25.05.51.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Jan 2022 05:51:34 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 20PDpW7V019872 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jan 2022 14:51:33 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com, Jan Kiszka Subject: Re: [PATCH v2 0/9] Avoid using shell environment during the build Date: Tue, 25 Jan 2022 16:51:32 +0300 Message-ID: <2755364.Ex9A2HvPv6@home> In-Reply-To: <9ccd085b-7649-c856-dab7-3d959bb4141c@siemens.com> References: <20220125123219.32395-1-ubely@ilbers.de> <9ccd085b-7649-c856-dab7-3d959bb4141c@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: WTmCQD9a6fBy In the email from =D0=B2=D1=82=D0=BE=D1=80=D0=BD=D0=B8=D0=BA, 25 =D1=8F=D0= =BD=D0=B2=D0=B0=D1=80=D1=8F 2022 =D0=B3. 16:29:28 +03 user Jan Kiszka=20 wrote: > On 25.01.22 13:32, Uladzimir Bely wrote: > > This patchset is a subseries of 'Sbuild/Schroot migration' patchset > > including only preparation patches. It doesn't require any changes > > in host machine configuration for downstreams (meta-iot2050 and > > xenomai-images were tested) so can be merged independently. > >=20 > > In this patchset the main topic is a migration to template files that > > allows to use cleaner build environment. > >=20 > > When this patchset is merged, it will make maintenance of remaining > > sbuild-related patches easier and will shorten their number. > >=20 > > Changes since v1: > > - Introduced `dpkg_build_export` function to be used for passing > > variables to build environment; >=20 > I wonder - as just written in the iot2050 PR - if we have any chance to > detect old exports and warn the user if their recipes need to be > converted to dpkg_build_export. Any ideas? >=20 > Jan >=20 That's an interesting question. If we could make a hook that could intercep= t=20 any 'export' call in dpkg_runbuild (usually, in _prepend), we could make a= =20 warning. On the other hand, in this case we could not introduce a new=20 function, but just do what we really need instead of doing shell export. =46or now I have no ideas how we could do it. > > - Linux kernel framgments handling is done in Debian way. > >=20 > > Anton Mikanovich (6): > > linux-module: Do not use shell environment > > u-boot: Do not use shell environment > > trusted-firmware: Do not use shell environment > > optee-os: Do not use shell environment > > kselftest: Do not use shell environment > > linux-mainline: Move cfg fragment test to debian/rules > >=20 > > Uladzimir Bely (3): > > template: Copy template attributes on transform > > dpkg: Use a specific export function in pre-build tasks > > linux-custom: Move cfg fragments applying to debian/rules > > =20 > > meta-isar/recipes-app/hello/hello.bb | 2 +- > > .../optee-os/optee-os-stm32mp15x_3.11.0.bb | 2 +- > > .../linux/linux-mainline_5.4.70.bb | 16 +++--- > > meta/classes/dpkg-base.bbclass | 9 ++++ > > meta/classes/dpkg.bbclass | 2 +- > > meta/classes/template.bbclass | 4 +- > > .../libubootenv/libubootenv_0.3-3.bb | 2 +- > > .../files/debian/{rules =3D> rules.tmpl} | 4 +- > > meta/recipes-bsp/optee-os/optee-os-custom.inc | 9 +--- > > .../files/debian/{rules =3D> rules.tmpl} | 4 +- > > .../trusted-firmware-a-custom.inc | 9 +--- > > .../u-boot/files/debian/{rules =3D> rules.tmpl} | 2 +- > > meta/recipes-bsp/u-boot/u-boot-custom.inc | 9 +--- > > .../kselftest/files/{rules =3D> rules.tmpl} | 0 > > meta/recipes-kernel/kselftest/kselftest.inc | 21 +++----- > > .../linux-module/files/debian/rules | 37 ------------- > > .../linux-module/files/debian/rules.tmpl | 52 +++++++++++++++++++ > > meta/recipes-kernel/linux-module/module.inc | 19 ++----- > > .../linux/files/debian/isar/configure.tmpl | 19 +++++++ > > .../linux/files/debian/rules.tmpl | 3 ++ > > meta/recipes-kernel/linux/linux-custom.inc | 14 ++--- > > 21 files changed, 125 insertions(+), 114 deletions(-) > > rename meta/recipes-bsp/optee-os/files/debian/{rules =3D> rules.tmpl} > > (75%) > > rename meta/recipes-bsp/trusted-firmware-a/files/debian/{rules =3D> > > rules.tmpl} (77%) rename meta/recipes-bsp/u-boot/files/debian/{rules = =3D> > > rules.tmpl} (94%) rename meta/recipes-kernel/kselftest/files/{rules = =3D> > > rules.tmpl} (100%) delete mode 100755 > > meta/recipes-kernel/linux-module/files/debian/rules create mode 100755 > > meta/recipes-kernel/linux-module/files/debian/rules.tmpl create mode > > 100644 meta/recipes-kernel/linux/files/debian/isar/configure.tmpl