[PATCH] initramfs: Add missing TASK_USE_SUDO

[PATCH] initramfs: Add missing TASK_USE_SUDO

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Forgotten in fea0f649fc3a.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Aren't we testing this class in Isar? Found it while porting isar-cip-
core to bb2.

 meta/classes/initramfs.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
index db283347..a5141a53 100644
--- a/meta/classes/initramfs.bbclass
+++ b/meta/classes/initramfs.bbclass
@@ -28,6 +28,7 @@ ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
 inherit rootfs
 
 do_generate_initramfs[dirs] = "${DEPLOY_DIR_IMAGE}"
+do_generate_initramfs[network] = "${TASK_USE_SUDO}"
 do_generate_initramfs() {
     rootfs_do_mounts
     rootfs_do_qemu
-- 
2.35.3

Re: [PATCH] initramfs: Add missing TASK_USE_SUDO

[Jan Kiszka]

On 03.02.23 18:51, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Forgotten in fea0f649fc3a.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Aren't we testing this class in Isar? Found it while porting isar-cip-
> core to bb2.

There is a target mc:qemuamd64-bullseye:isar-initramfs in citest.py - no
idea why that did not trigger. In any case, please merge quickly to help
downstream.

Thanks,
Jan

> 
>  meta/classes/initramfs.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
> index db283347..a5141a53 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -28,6 +28,7 @@ ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>  inherit rootfs
>  
>  do_generate_initramfs[dirs] = "${DEPLOY_DIR_IMAGE}"
> +do_generate_initramfs[network] = "${TASK_USE_SUDO}"
>  do_generate_initramfs() {
>      rootfs_do_mounts
>      rootfs_do_qemu

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH] initramfs: Add missing TASK_USE_SUDO

[Moessbauer, Felix]

On Fri, 2023-02-03 at 19:18 +0100, Jan Kiszka wrote:
> On 03.02.23 18:51, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > Forgotten in fea0f649fc3a.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> > Aren't we testing this class in Isar? Found it while porting isar-
> > cip-
> > core to bb2.
> 
> There is a target mc:qemuamd64-bullseye:isar-initramfs in citest.py -
> no
> idea why that did not trigger. In any case, please merge quickly to
> help
> downstream.

Acked. The same applies to other fixes to make ISAR work again on
sid or risv or in CI. Latest next is currently not usable.

Felix

> 
> Thanks,
> Jan
> 
> > 
> >  meta/classes/initramfs.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/classes/initramfs.bbclass
> > b/meta/classes/initramfs.bbclass
> > index db283347..a5141a53 100644
> > --- a/meta/classes/initramfs.bbclass
> > +++ b/meta/classes/initramfs.bbclass
> > @@ -28,6 +28,7 @@ ROOTFS_PACKAGES = "initramfs-tools
> > ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
> >  inherit rootfs
> >  
> >  do_generate_initramfs[dirs] = "${DEPLOY_DIR_IMAGE}"
> > +do_generate_initramfs[network] = "${TASK_USE_SUDO}"
> >  do_generate_initramfs() {
> >      rootfs_do_mounts
> >      rootfs_do_qemu
> 
> -- 
> Siemens AG, Technology
> Competence Center Embedded Linux
> 

Re: [PATCH] initramfs: Add missing TASK_USE_SUDO

[Jan Kiszka]

On 03.02.23 19:18, Jan Kiszka wrote:
> On 03.02.23 18:51, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Forgotten in fea0f649fc3a.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Aren't we testing this class in Isar? Found it while porting isar-cip-
>> core to bb2.
> 
> There is a target mc:qemuamd64-bullseye:isar-initramfs in citest.py - no
> idea why that did not trigger. In any case, please merge quickly to help
> downstream.
> 

mc:qemuamd64-bullseye:isar-initramfs fails miserably when being built. I
still don't understand how the testsuite works and how that was missing
in your CI.

However, please merge such simple, obvious fixes much faster, even more
when CI didn't help anyway.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH] initramfs: Add missing TASK_USE_SUDO

[Uladzimir Bely]

In the email from Friday, 3 February 2023 20:51:27 +03 user Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Forgotten in fea0f649fc3a.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Aren't we testing this class in Isar? Found it while porting isar-cip-
> core to bb2.
> 
>  meta/classes/initramfs.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied to next, thanks.

Re: [PATCH] initramfs: Add missing TASK_USE_SUDO

[Jan Kiszka]

On 07.02.23 09:56, Uladzimir Bely wrote:
> In the email from Friday, 3 February 2023 20:51:27 +03 user Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Forgotten in fea0f649fc3a.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Aren't we testing this class in Isar? Found it while porting isar-cip-
>> core to bb2.
>>
>>  meta/classes/initramfs.bbclass | 1 +
>>  1 file changed, 1 insertion(+)
>>
> 
> Applied to next, thanks.
> 

Thanks you!

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux