Re: [PATCH] image: include image name in the kernel/initrd image copies

[Jan Kiszka <jan.kiszka@siemens.com>]

On 18.10.18 13:45, chombourger@gmail.com wrote:
> Hi Jan,
> 
>     We have two use cases so far: QEMU and wic. Both work without downstream effort
>     by just using those two variables. That by itself is not bad. An alternative
>     might only by peeking directly into the rootfs trees of the images, i.e.
>     avoiding the copying to deploy. Not sure, actually, what value this copy-out
>     provides, at least as long as the user does not manual deployment of the
>     artifacts.
> 
> 
> Same here, it just sounded like a bigger change (which I am happy to work on if 
> we want to go down this path)
> 
>     Anyway. If we keep copy-out: Instead of appending further elements to the
>     kernel/initrd prefix, we should really consolidate things. The image, maybe it
>     be wic-generated or ext4-img or whatever, as well as associated artifacts
>     should
>     follow the same file naming scheme so that you can easily identify related
>     artifacts.
> 
> 
> Aren't we there with this patch?
> 
> $ ls *isar-image-base-debian-stretch-qemuamd64*
> initrd.img-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd64  
> isar-image-base-debian-stretch-qemuamd64.wic.img  
> vmlinuz-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd6
> 
> The command returned as expected all the image artifacts we have for 
> IMAGE=isar-image-base && DISTRO=debian-stretch && MACHINE=qemuamd64
> The name pattern would be: [<sub-image-name>-]<image>-<distro>-<machine>[<suffix>]
> 

ext4-img does

EXT4_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.ext4.img"

wic-img does

WIC_IMAGE_FILE ="${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.wic.img"

Now I would expect something like

KERNEL_IMAGE = "${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.vmlinuz"

and similar for initrd. If there is a value (dunno), we could keep
including the kernel version.

Moreover, we should probably ensure via a single variable that the "${PN}-${DISTRO}-${MACHINE}" image name core is always the same, not
ad-hoc constructed in multiple places.

Or we strictly model what Yocto does, but that seems different to me
(bzImage--<kernel-recipe-version>-<machine>-<builddate>.bin), not even
multiconfig-ready.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux