From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6613620343774904320 X-Received: by 2002:adf:ef84:: with SMTP id d4-v6mr2735765wro.18.1539870801310; Thu, 18 Oct 2018 06:53:21 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:61cf:: with SMTP id q15-v6ls2102055wrv.13.gmail; Thu, 18 Oct 2018 06:53:20 -0700 (PDT) X-Google-Smtp-Source: ACcGV60hyOlDFQvxmF8DCi2EeM926SSui3GzKdA4IDsf/zY4M7iScJJKukqJNIeeVXFRaZovn3Tq X-Received: by 2002:a5d:530e:: with SMTP id e14-v6mr2752686wrv.4.1539870800807; Thu, 18 Oct 2018 06:53:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539870800; cv=none; d=google.com; s=arc-20160816; b=o1Mu80VF0WJxzska7FR5byp1XLLO+AutUOg+q/6325LVEqJ3jUMv2s+R/e0RXUj8DL 0/4rDDR9cVevbn/a4AKh5K3ur5E0/JNJxOmCexCk7BK9IsWv4MqBYFq+ThWJdP/OAWAv cRJUHvccbfChGwLUCK2iXz6yPOHVWVfj1ZbBwzzgOWxhfvrkfz0OxH2pj9eTACp1rSzg DHwyBPpEsWD63D4pCRCa00qJm2ooXAQ8q48LHXmd4SqEFcN8sQF9Soi0tdGuX9sh6Wxi cOGx8RuHy6lu2quSTMwwUlkoyZArNxrsyirdx8pTRoI/Hed7lZBvs43qsNaPD09kg+0P 5wtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=VknMfyXls78TAXEZQEXNdgakQ6Fbq/rX2v9RLf50SkU=; b=VrEetPkq71uTTh5q9OIMp3Yrvm1kSO5L5zmsKJ1rLJz6aMsgbPNqaxK4KqLYKcukO9 j3FW4ujwKt0s8iT4Tst27d4gJ1NapuN5OqDgD9sDeEzBwDBBIkmduLJ8OnwqXlSvB82w CzQ0EVzEZSfopVYq427u7KAqX4oDOpSC3wlWE57LGpdU8Mc3/4mrZkJHYw6J71SRgL68 qCE+BTvaY6WfOHYPvMZcWoaZzMItfmD8CxLraHgyxo8qNnuTleP681Tpw5A7h6C9x/mf F0IWhulCAlOjnBWbWzAxDJxwzLd1iZ6UyEDVI+8c+2wdcLCAW7mRjSdjUKUX2RnAdeKI 48QA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id z62-v6si84407wmc.2.2018.10.18.06.53.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 06:53:20 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id w9IDrKLq009829 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Oct 2018 15:53:20 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w9IDrKNK008210 for ; Thu, 18 Oct 2018 15:53:20 +0200 Subject: Re: [PATCH] image: include image name in the kernel/initrd image copies To: isar-users@googlegroups.com References: <1539853468-156-1-git-send-email-Cedric_Hombourger@mentor.com> <578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com> <695f9e56-13af-9a25-df97-4f1b8a11a364@siemens.com> From: Jan Kiszka Message-ID: <27912c86-2c53-4986-bf9c-2f9b9796bd50@siemens.com> Date: Thu, 18 Oct 2018 15:53:19 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: VuBFiwx10gq0 On 18.10.18 13:45, chombourger@gmail.com wrote: > Hi Jan, > > We have two use cases so far: QEMU and wic. Both work without downstream effort > by just using those two variables. That by itself is not bad. An alternative > might only by peeking directly into the rootfs trees of the images, i.e. > avoiding the copying to deploy. Not sure, actually, what value this copy-out > provides, at least as long as the user does not manual deployment of the > artifacts. > > > Same here, it just sounded like a bigger change (which I am happy to work on if > we want to go down this path) > > Anyway. If we keep copy-out: Instead of appending further elements to the > kernel/initrd prefix, we should really consolidate things. The image, maybe it > be wic-generated or ext4-img or whatever, as well as associated artifacts > should > follow the same file naming scheme so that you can easily identify related > artifacts. > > > Aren't we there with this patch? > > $ ls *isar-image-base-debian-stretch-qemuamd64* > initrd.img-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd64  > isar-image-base-debian-stretch-qemuamd64.wic.img  > vmlinuz-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd6 > > The command returned as expected all the image artifacts we have for > IMAGE=isar-image-base && DISTRO=debian-stretch && MACHINE=qemuamd64 > The name pattern would be: [-]--[] > ext4-img does EXT4_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.ext4.img" wic-img does WIC_IMAGE_FILE ="${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.wic.img" Now I would expect something like KERNEL_IMAGE = "${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.vmlinuz" and similar for initrd. If there is a value (dunno), we could keep including the kernel version. Moreover, we should probably ensure via a single variable that the "${PN}-${DISTRO}-${MACHINE}" image name core is always the same, not ad-hoc constructed in multiple places. Or we strictly model what Yocto does, but that seems different to me (bzImage----.bin), not even multiconfig-ready. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux