public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH v4] meta: Run depmod after kernel module installation
@ 2018-08-19 18:57 Jan Kiszka
  2018-08-27 22:08 ` Maxim Yu. Osipov
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2018-08-19 18:57 UTC (permalink / raw)
  To: isar-users

From: Jan Kiszka <jan.kiszka@siemens.com>

Otherwise the module may not be found if the module package is installed
on its own, i.e. without the kernel package performing the depmod run.

As we now install a postinst baseline with the right mode, the chmod on
AUTOLOAD becomes obsolete.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Changes to v3:
 - allow depmod to fail (e.g. when building the image)

 meta/recipes-kernel/linux-module/files/debian/postinst | 2 ++
 meta/recipes-kernel/linux-module/module.inc            | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100755 meta/recipes-kernel/linux-module/files/debian/postinst

diff --git a/meta/recipes-kernel/linux-module/files/debian/postinst b/meta/recipes-kernel/linux-module/files/debian/postinst
new file mode 100755
index 0000000..35d5de0
--- /dev/null
+++ b/meta/recipes-kernel/linux-module/files/debian/postinst
@@ -0,0 +1,2 @@
+#!/bin/sh
+depmod -a
diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 3075f44..76a49f3 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -26,6 +26,5 @@ dpkg_runbuild_prepend() {
 
     if [ ${AUTOLOAD} = "1" ]; then
         echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst
-        chmod +x ${S}/debian/postinst
     fi
 }
-- 
2.16.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] meta: Run depmod after kernel module installation
  2018-08-19 18:57 [PATCH v4] meta: Run depmod after kernel module installation Jan Kiszka
@ 2018-08-27 22:08 ` Maxim Yu. Osipov
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Yu. Osipov @ 2018-08-27 22:08 UTC (permalink / raw)
  To: Jan Kiszka, isar-users

On 08/19/2018 09:57 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Otherwise the module may not be found if the module package is installed
> on its own, i.e. without the kernel package performing the depmod run.
> 
> As we now install a postinst baseline with the right mode, the chmod on
> AUTOLOAD becomes obsolete.

Applied to the 'next',

Regards,
Maxim.


> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes to v3:
>   - allow depmod to fail (e.g. when building the image)
> 
>   meta/recipes-kernel/linux-module/files/debian/postinst | 2 ++
>   meta/recipes-kernel/linux-module/module.inc            | 1 -
>   2 files changed, 2 insertions(+), 1 deletion(-)
>   create mode 100755 meta/recipes-kernel/linux-module/files/debian/postinst
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/postinst b/meta/recipes-kernel/linux-module/files/debian/postinst
> new file mode 100755
> index 0000000..35d5de0
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/postinst
> @@ -0,0 +1,2 @@
> +#!/bin/sh
> +depmod -a
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
> index 3075f44..76a49f3 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -26,6 +26,5 @@ dpkg_runbuild_prepend() {
>   
>       if [ ${AUTOLOAD} = "1" ]; then
>           echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst
> -        chmod +x ${S}/debian/postinst
>       fi
>   }
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-27 22:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-19 18:57 [PATCH v4] meta: Run depmod after kernel module installation Jan Kiszka
2018-08-27 22:08 ` Maxim Yu. Osipov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox