Re: [RFC PATCH 1/2] sdk: support creation of container image

[Jan Kiszka <jan.kiszka@siemens.com>]

On 12.01.21 12:50, [ext] Silvano Cirujano Cuesta wrote:
> 
> On 12/01/2021 12:36, Henning Schild wrote:
>> Am Tue, 12 Jan 2021 11:33:37 +0100
>> schrieb "[ext] Silvano Cirujano Cuesta"
>> <silvano.cirujano-cuesta@siemens.com>:
>>
>>> Extend task "populate_sdk" to support the creation of a container
>>> image containing the SDK.
>>>
>>> Signed-off-by: Silvano Cirujano Cuesta
>>> <silvano.cirujano-cuesta@siemens.com> ---
>>>  meta/classes/image-sdk-extension.bbclass | 99
>>> ++++++++++++++++++++++-- 1 file changed, 92 insertions(+), 7
>>> deletions(-)
>>>
>>> diff --git a/meta/classes/image-sdk-extension.bbclass
>>> b/meta/classes/image-sdk-extension.bbclass index a8c708a..9317256
>>> 100644 --- a/meta/classes/image-sdk-extension.bbclass
>>> +++ b/meta/classes/image-sdk-extension.bbclass
>>> @@ -6,10 +6,77 @@
>>>  # This class extends the image.bbclass to supply the creation of a
>>> sdk 
>>>  SDK_INCLUDE_ISAR_APT ?= "0"
>>> +SDK_GENERATE_FORMATS = "${@d.getVar("SDK_FORMATS", "tar")}"
>> I do not understand why there are two variables, maybe one is enough.
>> And i think a ?= assignment would be a better choice here.
> 
> Probably lack of ISAR expersite... I don't know why using
> 
> SDK_FORMATS = "${@d.getVar("SDK_FORMATS", "tar")}"
> 
> fails. I've also tried
> 
> SDK_FORMATS ?= "tar"
> 
> and failed.

How did it fail - because this is how it should look like.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux