From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750639733816164352 X-Received: by 2002:aa7:d410:: with SMTP id z16mr32319870edq.40.1571761756890; Tue, 22 Oct 2019 09:29:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:1847:: with SMTP id v7ls4436001edy.0.gmail; Tue, 22 Oct 2019 09:29:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqw19bvyMVXbd/PS3Vus7UgyV70Lt5EJ92Ra7J5kq3I+DvJZvM21zCUsgzMurYPBENQYrs8f X-Received: by 2002:aa7:db59:: with SMTP id n25mr32716806edt.288.1571761756334; Tue, 22 Oct 2019 09:29:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571761756; cv=none; d=google.com; s=arc-20160816; b=blGqm70DZbJ4mt43dOuAD2oAL4ccqYnQ+Xk4MIKYptD3iqxSGqQVnxwv/8Inh9pRgL cqX9NR+WBTenD7WG3MxnPlywENHglrEkpHGmfYJZrXPXve/1vgVo43UmLCQpMVJRjXrq /M9H+QCpLESRpFnDtvfFrQl+qQ19Isrlzh+4ktTeNN4VpDAQ9vTKOHnrVvQUtV4d7mh5 lGsA2/+gBZ1m7xlEiDtYM8k8OHrlzB+EdKGUX0evqWo+T+lrRV62DMd2Czl3RpwWM1uE Yd0MGpjAY8UiFmegzwzbBhjes5EbQMw0OZOKX1rze4pUR9JKc/Hba8x8EwWBV6pSP2AN JhdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=nm+hJ655k/Femthz4zEp6OfIXJYk1eSSK5HdbOxqfN0=; b=n3plZ0xWknXM7GS9CXEoSTZq2Inud7nwzl16Hz6SLvH4ckUb8iK+rFSNZ4Kn2X8fVY HCZCJS39d7gZDrX/9vaz6D9bBNiAhGRduoF3G7O3+2Hv+dyHZf1qnwEmvBEgtPz9Mm4i eJrss9KdKRbSjgPQnvpPo/VnuxbodKOH80Xy6+er23X/5QObk2gd8rbvs2CNySDW/wfv v02xQkOVhM7Y7E4Z7bAGLNRr3JoP6LOnTZT5hExOdrxXIxntPST+JKOI4+/bN0JUXXE1 EXIJ0OA7XQHzjUWXcL/o3kddUqP8cF6616ZGT9+gFBauc6D04VQXPTCrUcAdxmVrJiyC X1Xg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id r3si1005040eds.2.2019.10.22.09.29.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Oct 2019 09:29:16 -0700 (PDT) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x9MGTFCQ022513 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 22 Oct 2019 18:29:15 +0200 Received: from [139.25.69.120] ([139.25.69.120]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x9MGTFH5010286 for ; Tue, 22 Oct 2019 18:29:15 +0200 Subject: Re: [PATCH v2] meta: rootfs: Fix manifest generation To: isar-users@googlegroups.com References: <20191022144930.3458-1-Vijaikumar_Kangarajan@mentor.com> <20191022145336.3873-1-Vijaikumar_Kangarajan@mentor.com> From: Gylstorff Quirin Message-ID: <28666b08-fc78-8ad3-083b-f94a345b98ce@siemens.com> Date: Tue, 22 Oct 2019 18:28:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191022145336.3873-1-Vijaikumar_Kangarajan@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: YYCAuNTpPCsO On 10/22/19 4:53 PM, vijaikumar.kanagarajan@gmail.com wrote: > From: Vijai Kumar K > > finalize-rootfs task removes qemu-*-static. It is needed for > rootfs_generate_manifest to work when HOST_ARCH != DISTRO_ARCH. > > Make sure a proper chroot environment is available when > generating manifest. > > Signed-off-by: Vijai Kumar K > --- > Changes in v2: > - Updated commit message. > > meta/classes/rootfs.bbclass | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index da66b3f..1da27ff 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -9,8 +9,8 @@ ROOTFS_PACKAGES ?= "" > # available features are: > # 'deploy-package-cache' - copy the package cache ${WORKDIR}/apt_cache > # 'clean-package-cache' - delete package cache from rootfs > -# 'finalize-rootfs' - delete files needed to chroot into the rootfs > # 'generate-manifest' - generate a package manifest of the rootfs into ${ROOTFS_MANIFEST_DEPLOY_DIR} > +# 'finalize-rootfs' - delete files needed to chroot into the rootfs > ROOTFS_FEATURES ?= "" > > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > @@ -185,6 +185,15 @@ rootfs_postprocess_clean_package_cache() { > sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* > } > > +ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" > +rootfs_generate_manifest () { > + mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR} > + sudo -E chroot --userspec=$(id -u):$(id -g) '${ROOTFSDIR}' \ > + dpkg-query -W -f \ > + '${source:Package}|${source:Version}|${binary:Package}|${Version}\n' > \ > + ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest > +} > + > ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs', 'rootfs_postprocess_finalize', '', d)}" > rootfs_postprocess_finalize() { > sudo -s <<'EOSUDO' > @@ -223,15 +232,6 @@ rootfs_postprocess_finalize() { > EOSUDO > } > Is it possible to add a guard to finalize to check that it is the last command in ROOTFS_POSTPROCESS_COMMAND. > -ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" > -rootfs_generate_manifest () { > - mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR} > - sudo -E chroot --userspec=$(id -u):$(id -g) '${ROOTFSDIR}' \ > - dpkg-query -W -f \ > - '${source:Package}|${source:Version}|${binary:Package}|${Version}\n' > \ > - ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest > -} > - > do_rootfs_postprocess[vardeps] = "${ROOTFS_POSTPROCESS_COMMAND}" > python do_rootfs_postprocess() { > # Take care that its correctly mounted: > Thanks. This should have been found in the CI build. Is the CrossBuild not part of the CI configuration? Quirin