public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: isar-users <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl
Date: Sun, 24 May 2020 11:43:13 +0200	[thread overview]
Message-ID: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

.PHONY is not needed (and wasn't consistently used anyway). And that
missing && before the last export was apparently not critical as well.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/rules.tmpl | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta/recipes-kernel/linux/files/debian/rules.tmpl b/meta/recipes-kernel/linux/files/debian/rules.tmpl
index 46b56ec5..05a26fe2 100755
--- a/meta/recipes-kernel/linux/files/debian/rules.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/rules.tmpl
@@ -12,28 +12,24 @@ isar_env=$(strip \
 	export DEB_BUILD_PROFILES='$(DEB_BUILD_PROFILES)' && \
 	export DEB_HOST_GNU_TYPE='$(DEB_HOST_GNU_TYPE)' && \
 	export MAKE='$(MAKE)' && \
-	export O='${O}' \
+	export O='${O}' && \
 	export S='${S}' \
 )

 %:
 	dh $(@)

-.PHONY: override_dh_auto_clean
 override_dh_auto_clean:
 	$(isar_env) && bash $(deb_top_dir)/isar/clean

-.PHONY: override_dh_auto_build
 override_dh_auto_build:
 	$(isar_env) && bash $(deb_top_dir)/isar/build

 override_dh_auto_install:
 	$(isar_env) && bash $(deb_top_dir)/isar/install

-.PHONY: override_dh_auto_test
 override_dh_auto_test:
 	true

-PHONY: override_dh_strip
 override_dh_strip:
 	unset DEB_HOST_GNU_TYPE && dh_strip -Xvmlinu --no-automatic-dbgsym
--
2.26.1


             reply	other threads:[~2020-05-24  9:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-24  9:43 Jan Kiszka [this message]
2020-05-28 20:04 ` Baurzhan Ismagulov
2020-05-29  5:53   ` Jan Kiszka
2020-06-22  7:36     ` Jan Kiszka
2020-08-31 16:29       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=289568e6-46d2-e2e3-9771-7668cd10bc01@web.de \
    --to=jan.kiszka@web.de \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox