public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: isar-users <isar-users@googlegroups.com>, Claudius Heine <ch@denx.de>
Subject: [PATCH] template: Remove MACHINE from default TEMPLATE_VARS
Date: Mon, 25 Mar 2019 12:14:46 +0100	[thread overview]
Message-ID: <28bc18bf-0f28-3470-3253-41cb5069b1d1@web.de> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

This breaks packages, even those not using templating, when they are
pulled via multiconfig by different machines of the same arch. As the
MACHINE variable differs, bitbake first builds do_transform_template
multiple times, and then everything that follows after, including
standard packages like isar-cfg-* or expand-on-first-boot. Those are
shared, use only a single workdir, and will quickly break of built
concurrently.

Fixes: 43b4c21aa185 ("meta: added do_transform_template task as templating system and switch")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/template.bbclass             | 3 +--
 meta/recipes-bsp/u-boot/u-boot-custom.inc | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass
index 324511a..3eb9114 100644
--- a/meta/classes/template.bbclass
+++ b/meta/classes/template.bbclass
@@ -4,8 +4,7 @@
 # SPDX-License-Identifier: MIT

 TEMPLATE_FILES ?= ""
-TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME MACHINE \
-                   DISTRO_ARCH"
+TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME DISTRO_ARCH"

 do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
 do_transform_template[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc
index 1afe430..b3eab46 100644
--- a/meta/recipes-bsp/u-boot/u-boot-custom.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc
@@ -19,7 +19,7 @@ BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git"

 TEMPLATE_FILES = "debian/changelog.tmpl \
                   debian/control.tmpl"
-TEMPLATE_VARS += "BUILD_DEPENDS"
+TEMPLATE_VARS += "MACHINE BUILD_DEPENDS"

 do_prepare_build() {
     cp -r ${WORKDIR}/debian ${S}/
--
2.16.4

             reply	other threads:[~2019-03-25 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 11:14 Jan Kiszka [this message]
2019-03-25 11:19 ` Jan Kiszka
2019-03-25 19:08 ` Maxim Yu. Osipov
2019-03-26  5:25   ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28bc18bf-0f28-3470-3253-41cb5069b1d1@web.de \
    --to=jan.kiszka@web.de \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox