public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] dpkg-base: Permit multiple clean runs
@ 2019-09-16  6:46 Jan Kiszka
  2019-09-17  9:11 ` Henning Schild
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2019-09-16  6:46 UTC (permalink / raw)
  To: isar-users

From: Jan Kiszka <jan.kiszka@siemens.com>

"find ${S}/.." fails if the is no ${S} anymore.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/dpkg-base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index c86d0b3..e814208 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -102,7 +102,7 @@ addtask dpkg_build before do_build
 CLEANFUNCS += "repo_clean"
 
 repo_clean() {
-    DEBS=$( find ${S}/.. -maxdepth 1 -name "*.deb" )
+    DEBS=$( find ${S}/.. -maxdepth 1 -name "*.deb" || true )
     if [ -n "${DEBS}" ]; then
         for d in ${DEBS}; do
             p=$( dpkg-deb --show --showformat '${Package}' ${d} )
-- 
2.16.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dpkg-base: Permit multiple clean runs
  2019-09-16  6:46 [PATCH] dpkg-base: Permit multiple clean runs Jan Kiszka
@ 2019-09-17  9:11 ` Henning Schild
  0 siblings, 0 replies; 2+ messages in thread
From: Henning Schild @ 2019-09-17  9:11 UTC (permalink / raw)
  To: [ext] Jan Kiszka; +Cc: isar-users

Am Mon, 16 Sep 2019 08:46:07 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> "find ${S}/.." fails if the is no ${S} anymore.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/dpkg-base.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/dpkg-base.bbclass
> b/meta/classes/dpkg-base.bbclass index c86d0b3..e814208 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -102,7 +102,7 @@ addtask dpkg_build before do_build
>  CLEANFUNCS += "repo_clean"
>  
>  repo_clean() {
> -    DEBS=$( find ${S}/.. -maxdepth 1 -name "*.deb" )
> +    DEBS=$( find ${S}/.. -maxdepth 1 -name "*.deb" || true )

"|| true" swallows too many potential errors

go for

[ ! -d ${S} ] && return 0

Henning

>      if [ -n "${DEBS}" ]; then
>          for d in ${DEBS}; do
>              p=$( dpkg-deb --show --showformat '${Package}' ${d} )


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-17  9:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-16  6:46 [PATCH] dpkg-base: Permit multiple clean runs Jan Kiszka
2019-09-17  9:11 ` Henning Schild

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox