From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7174010600156037120 X-Received: by 2002:a17:90a:bc47:b0:219:2e22:ea9 with SMTP id t7-20020a17090abc4700b002192e220ea9mr46357109pjv.55.1670333448859; Tue, 06 Dec 2022 05:30:48 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6a00:9a0:b0:56b:9d05:32df with SMTP id u32-20020a056a0009a000b0056b9d0532dfls4662733pfg.11.-pod-prod-gmail; Tue, 06 Dec 2022 05:30:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf5eUufzolDRNfczH/kWId492q4uRcbiK6Gnv7B3umZAMnauKuFIOKaraO63omasTqq8sd3H X-Received: by 2002:aa7:9e1a:0:b0:576:cd93:98cf with SMTP id y26-20020aa79e1a000000b00576cd9398cfmr12409806pfq.53.1670333447838; Tue, 06 Dec 2022 05:30:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670333447; cv=none; d=google.com; s=arc-20160816; b=cRSrxNVhr2nTn3EIo6O+ohUxJUz4U3Gy4vvHMoCRvRHGzUsDqzt87T3vMa6WFdmUyP f8jtNOvPxlOvxBbOADt41fHatljZ80NdPMc6GrFVs5oLE4/qjrbm8vXpnKYOKWl+wtc6 1Frt09Qfl4Xi/rZUdDnpVeLrtdMmaRHDjpuMBp7o4UnVjuwfHlDveke2Mbmigts8uJIf VqhNyVDUn8JLtkLQ+fwKkjPASAvqX6crXhPAQmjl+dWcz36ffvPgieN7LYPEVhMqdLZ9 1bALnA2idQwXQo94TLf5cB3jae8W/nllJaQyb4U493aVLz99lrFnOyq0IzrXF4uJmJkf dKYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id; bh=Gf8AyYJkrMG4v+/GOv3jNtUNcFBQDZdk9PxNzF9cp94=; b=ulGUcZszSsN/+xSO6n6ZSvCIk/EnYbQFgVjJUnJ6RyNwKrgQ5+fz/8i5lmWv0TbxgZ GxL2459sAFYsuuUPQp7Bb7T1zX6GzQmt8LMnELb2TZWrJuvo5AAKpHMolnNptC/UJmK2 fZgDiZELGfZenCA6h8z8mvTVQcOYwFTSaLOQpIp0uzCzmvmPo9E/qGvEVG2BM6K6y1+1 a6rqDuY1+DFF6nfOTA4oBdCbbSBK54B1YrhUmlEjuxTvt9D1feN3VjLFPW6o9xvNiD/M 7x0yHnG3wZdyVOLtUoPliSlCQNUOL0FfViv6y0py50WWO47/+flJSLqoFFXLcCQ9DKyi ARoQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id p3-20020a170902e74300b00189ad838080si1046170plf.8.2022.12.06.05.30.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Dec 2022 05:30:47 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 2B6DUfti001529 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Dec 2022 14:30:42 +0100 Message-ID: <29814741-e465-b10f-d80c-0e42309bc7c5@ilbers.de> Date: Tue, 6 Dec 2022 16:30:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/1] fixed 2 typos in RECIPE-API-CHANGELOG.md (due to 87d31ee) Content-Language: en-US To: "Roberto A. Foglietta" , isar-users@googlegroups.com References: From: Anton Mikanovich Cc: Baurzhan Ismagulov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: H49sIYCs54ft 06.12.2022 15:24, Roberto A. Foglietta wrote: > Hi all, > > I sent the patch with elastic mail and probably it went into the spam > folder, so I am manually sending this as well. Best regards, R- > > From ee4b3bb4ddb9825ec8aad30ec4440d4ca5b79db5 Mon Sep 17 00:00:00 2001 > From: "Roberto A. Foglietta" > Date: Tue, 6 Dec 2022 12:53:46 +0100 > Subject: [PATCH] fixed 2 typos in RECIPE-API-CHANGELOG.md (due to 87d31ee) > > bugfix, typos, documentation > > 87d31ee: add interface to passthrough env vars to sbuild > > Signed-off-by: Roberto A. Foglietta > --- > RECIPE-API-CHANGELOG.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 1b8efa5..0bb8338 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -436,8 +436,8 @@ specific bitbake variables as environment > variables into the sbuild environment. > The motivation behind it is to allow the use of external mirrors for > programming languages with builtin > package managers (like rust and go). By that, the variables are also > excluded from the bitbake signatures. > This helps in areas where default mirrors can either not be reached > or provide only little throughput. > -Please note, the forwarded variables do not have to exist. While they > are not forwared in case they do not > +Please note, the forwarded variables do not have to exist. While they > are not forwarded in case they do not > exist, empty variables are forwarded. > > -**Note about reproducability**: the forwarded variables must not have > any influence on the generated package. > +**Note about reproducibility**: the forwarded variables must not have > any influence on the generated package. > This mechanism must also not be used to inject build configurations. > For these cases, templates should be used. Hello Roberto, This changes are ok, but the patch itself is formatted quite badly. There is no need in mention fixed hash (87d31ee) in commit title. On the other hard, mentioning of fixed hash in commit message should be informative to note how it is connected to the current patch, like: Fixes: 87d31ee ("add interface to passthrough env vars to sbuild") It's probably don't mentioned anywhere in the Isar documentation, but commit message is better to be formatted in the form of text (started with a capital letter and ended with a dot), not just a keyword list. One of the keywords can be used as a prefix to the commit title to point the place of changes were done by the patch. In general you can follow kernel patches submitting guidelines that are quite good documented and much more strictly. And once again: please submit patchsets with 'git send-mail'. This will reduce manual work during review and applying, and also will allow Patchwork to generate correct applicable records.