Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Jan,

On 26/04/2019 13.50, Jan Kiszka wrote:
> On 26.04.19 13:31, [ext] Jan Kiszka wrote:
>> On 26.04.19 09:36, Claudius Heine wrote:
>>> Hi Maxim,
>>>
>>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>>> From: Claudius Heine <ch@denx.de>
>>>>>
>>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>>> distributions.
>>>>>
>>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>>> ---
>>>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>>    1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git 
>>>>> a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb 
>>>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> index 08b068f..3e96281 100644
>>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = 
>>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>>    ISAR_BOOTSTRAP_LOCK = 
>>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>>    require isar-bootstrap.inc
>>>>> +# We only build debian host buildchroot environments
>>>>> +DISTRO_APT_KEYS = ""
>>>>
>>>>   From the first glance this modification limits functionality.
>>>> It looks like a hack and I would suggest to avoid this modification.
>>>
>>> Well it is a fix and that limited functionality was already present but
>>> just implicit, hidden behind some bug and the cleanup just made it
>>> appear.
>>>
>>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>>> avoid confusion between target and host apt keys.
>>>
>>> Good idea. But that would be a new feature/improvement.
>>>
>>
>> If that is just about adding and documenting another variable, let's 
>> not discuss about when and who because just doing that will already be 
>> faster, even if it's a "drive-by" improvement /wrt this patchset.
>>
> 
> OTOH, I don't get the problem yet from just reading the commit message: 
> Wasn't DISTRO_APT_KEYS designed to be a superset of all needed keys?

DISTRO_APT_KEYS is only used for distros that aren't Debian, because 
debootstrap uses the keys of the host distro (Debian) per default. 
THIRD_PARTY_APT_KEYS is for the keys of other third party repositories 
that are not used to bootstrap from.

We currently only support raspbian as a non-debian distribution and 
before this patchset only 'debian-stretch' as buildchroot-host.
After this patchset we support all Debian versions we currently support 
for the target for the buildchroot-host as well. Since raspbian does not 
supply packages that can be used for a buildchroot-host environment, it 
makes sense to just use the Debian host keys for bootstrapping the 
buildchroot-host rootfs in general.

If at one point we want to support other non-debian apt/dpkg based 
distributions like ubuntu, that can be used for the target as well as 
the host root file system, then it makes sense to allow specifying 
additional keys for the buildchroot-host as well. Until that time 
however this fix is enough to go forward.

regards,
Claudius

> We 
> are appending raspbian to it when using that distro. So, we are at least 
> missing the reasoning here why that model didn't work and cannot be made 
> working for the host/target case. And then we can refer to that when 
> introducing split key sets.
> 
> Thanks,
> Jan
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de