public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
Cc: isar-users@googlegroups.com, Baurzhan Ismagulov <ibr@ilbers.de>
Subject: Re: [PATCH 1/1] fixed 2 typos in RECIPE-API-CHANGELOG.md (due to 87d31ee)
Date: Tue, 6 Dec 2022 22:56:06 +0300	[thread overview]
Message-ID: <2b15955e-4444-fa6d-9449-95f83782561a@ilbers.de> (raw)
In-Reply-To: <CAJGKYO6T5Z+FcuKBEQ_fu+5YN+-VmkL5pSO5tVPT3k4-dNf-Og@mail.gmail.com>

06.12.2022 18:16, Roberto A. Foglietta wrote:
> On Tue, 6 Dec 2022 at 14:30, Anton Mikanovich <amikan@ilbers.de> wrote:
>
>> This changes are ok, but the patch itself is formatted quite badly.
>>
> the patch has been formatted by git format-patch
>
>> There is no need in mention fixed hash (87d31ee) in commit title.
>> On the other hard, mentioning of fixed hash in commit message should be
>> informative to note how it is connected to the current patch, like:
>>
>> Fixes: 87d31ee ("add interface to passthrough env vars to sbuild")
> ok, resending in attachment
>
>> And once again: please submit patchsets with 'git send-mail'. This will
>> reduce
>> manual work during review and applying, and also will allow Patchwork to
>> generate correct applicable records.
>>
>   I sent the patch with elastic mail and probably it went into the spam
> folder. As explained in this list in the past, Google does not allow
> anymore to use their smtp via git. Thus, I am using
> smtp.elasticmail.com but usually the e-mail that I send via that smtp
> do not arrive in the list but they end up in moderation. So, as far as
> possible, I did. Please check the following thread about:
>
>   https://groups.google.com/g/isar-users/c/xC6-QImeLzc/m/1HATZVvVAgAJ
>
>   Best regards, R-

I still see commit message "bugfix, typos, documentation" which do not looks
good enough. Also please mark updated patchsets as v2, v3, etc. next time.


  reply	other threads:[~2022-12-06 19:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 12:24 Roberto A. Foglietta
2022-12-06 13:30 ` Anton Mikanovich
2022-12-06 15:16   ` Roberto A. Foglietta
2022-12-06 19:56     ` Anton Mikanovich [this message]
2022-12-06 20:52       ` Roberto A. Foglietta
2022-12-07  8:32         ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b15955e-4444-fa6d-9449-95f83782561a@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=ibr@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox