From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7174010600156037120 X-Received: by 2002:a63:4c4a:0:b0:478:b6ba:eb08 with SMTP id m10-20020a634c4a000000b00478b6baeb08mr10580911pgl.129.1670356573321; Tue, 06 Dec 2022 11:56:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:8a94:b0:218:a5af:5c43 with SMTP id x20-20020a17090a8a9400b00218a5af5c43ls291119pjn.3.-pod-control-gmail; Tue, 06 Dec 2022 11:56:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf4mVGcdVA8l98ATh9j9Mq7joVKUpG7VHs+ylad4dZeTXV9MZXns6b80tKmgLNtVJuqO19vU X-Received: by 2002:a17:902:e9cc:b0:189:ad0c:4027 with SMTP id 12-20020a170902e9cc00b00189ad0c4027mr31226370plk.63.1670356572434; Tue, 06 Dec 2022 11:56:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670356572; cv=none; d=google.com; s=arc-20160816; b=0P7J28Fgd4a4jnZsUwJu8X90kVT+3bxaawoVxhw3Kt9FG3YmY4p7qkwMArEHAZpzhd IhzOSoAX5fn3NVAE1wkKEIHnA6xfYI8RbzOxqecqyXRiswhwrzfcvANclNp19QkCXhP2 +5VpguFnRuUem1jwhhMTOu/so3hVJM3RKBf6/KwjPeTQqsgf133aAyF34ks/6oqfn5hM 4A6T6T0VgXBp+WOj7TYsYg0VwlqZHxd1co325uU7hwrRKkmwOn+f5Jm4tMBJIMp7zz8I WBYRyogqxHvrDBDuON/UVcdqE9lB7JfYQpTA/vVtPpQpEGmEO8nNY/KT5pqgUKAB8unC zDHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id; bh=BxgRdrbau3IaEBIOAyjLedLlvMG0P+tHYhy+mnGcHvI=; b=ooajqLAWm1DnM2959GjsebK6sDSMKxNv0jqz8Fu9qXXKViyYqDA78Es8tYDmznYOHu kb38lcikzBuSqGW0q7kaW8r/dgVmavh+Li9A92wFPKS82hgJSYrZIDs0a3Wp/TRMJMEa XGvjNEN9Z/hVG3B6wN4wunx/2wSXDH95pCeftecO9FGk2ubVcND7mxpA2VFO2Fw8Y+X7 FeCJy4GbeCr3v5KyMSBtdcT1LVtAnZRi/DL/JNA55wlEP+q55NgNDw+VFzloo02lced/ EF9HKZ66S1VjqY6eUM4M2M4xQuD9TiiEYSUnLg8SMijZaPp+A/Kv7LI/RjsmnFoEB9NA 20Xg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id mt18-20020a17090b231200b0021296f4cff5si1252698pjb.3.2022.12.06.11.56.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Dec 2022 11:56:12 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 2B6Ju6qD002923 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Dec 2022 20:56:07 +0100 Message-ID: <2b15955e-4444-fa6d-9449-95f83782561a@ilbers.de> Date: Tue, 6 Dec 2022 22:56:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/1] fixed 2 typos in RECIPE-API-CHANGELOG.md (due to 87d31ee) Content-Language: en-US To: "Roberto A. Foglietta" Cc: isar-users@googlegroups.com, Baurzhan Ismagulov References: <29814741-e465-b10f-d80c-0e42309bc7c5@ilbers.de> From: Anton Mikanovich In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: TzBFnuBWl3+5 06.12.2022 18:16, Roberto A. Foglietta wrote: > On Tue, 6 Dec 2022 at 14:30, Anton Mikanovich wrote: > >> This changes are ok, but the patch itself is formatted quite badly. >> > the patch has been formatted by git format-patch > >> There is no need in mention fixed hash (87d31ee) in commit title. >> On the other hard, mentioning of fixed hash in commit message should be >> informative to note how it is connected to the current patch, like: >> >> Fixes: 87d31ee ("add interface to passthrough env vars to sbuild") > ok, resending in attachment > >> And once again: please submit patchsets with 'git send-mail'. This will >> reduce >> manual work during review and applying, and also will allow Patchwork to >> generate correct applicable records. >> > I sent the patch with elastic mail and probably it went into the spam > folder. As explained in this list in the past, Google does not allow > anymore to use their smtp via git. Thus, I am using > smtp.elasticmail.com but usually the e-mail that I send via that smtp > do not arrive in the list but they end up in moderation. So, as far as > possible, I did. Please check the following thread about: > > https://groups.google.com/g/isar-users/c/xC6-QImeLzc/m/1HATZVvVAgAJ > > Best regards, R- I still see commit message "bugfix, typos, documentation" which do not looks good enough. Also please mark updated patchsets as v2, v3, etc. next time.