From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 12 May 2026 15:51:48 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wr1-f64.google.com (mail-wr1-f64.google.com [209.85.221.64]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 64CDplDx006362 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 12 May 2026 15:51:47 +0200 Received: by mail-wr1-f64.google.com with SMTP id ffacd0b85a97d-43d789cebcfsf4698219f8f.1 for ; Tue, 12 May 2026 06:51:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1778593902; cv=pass; d=google.com; s=arc-20240605; b=dHgOD0NxliAvT2aRDViiX+IzhAHwth6I6kIuwg5G7O89iDyXf6zNnxecZwWLKi/0/r bwQKzFRXxckVHe69cOOvp62Gk5Opv377yzMoaBA8cVbkaRmcL96YdY4nxv7B1HF5dSgv MnUnqK6iuaiaCebJ9W1nchWizOPGQ+mVC9WW35PDxNFMIJMx2/WAOGptmc8ND10CaQaZ wVw9/ZgOHWuxSb6rP+7TmODAhkaKjVQBxqiZQE3l9Hb7HAz2u/X/AZLK2RZ6bxgW+V3T 2QBJyREiGMJd+Fr6e6C9E2ua3ddlefnuJyTojmw2rW+0ohRiIqKcMYydtFr0q/6B8KAx D9Mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=efP/gQuqnkricRrytYVSBGCHteeZ5dbL25/u3O0HfuI=; fh=UonTUUnHE9QZ2FjsQR5mGGdW/0rrlV6I7zFRB6kE9RE=; b=cnUOGFQ1afEelEEa0yppH+VxbzKgm/32bpWh3iSP3aGxw+wItgIkYZj6PiviU6gJmu MW89iVWi828vtTUwsBwaytaxvqXXOyVET4V9ePTQ3NSr5SLQnCGilX5LQJOWrsMNu0iu kOQpjKyIIeMCat8Sjil7joBX6QDYdA3KXnLcLZ4YndZvabeuWUxrRFOu/ZKeKOdK32yq zgBTvsIUNU8rbFriCd6bSY2mhp1X+5rOQeFsOJYPKkKgG5VvrI2keVlup0ePcGF5AOcA 6bw2cqL/ocUQCh2pjv2IyA+SG1Lm9VbdSPfar3mCZWw1UsfNS8e2okpsnSvFq96cD60h QRTQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1778593902; x=1779198702; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:to :subject:user-agent:mime-version:date:message-id:sender:from:to:cc :subject:date:message-id:reply-to; bh=efP/gQuqnkricRrytYVSBGCHteeZ5dbL25/u3O0HfuI=; b=wgE8A3IcK6bboRPe9g/oJAGiyD/7PI5dJ8o8bqPOnHAkp0zgIWF8BSCWjk4wH85Yer UvMk/FbVSCT/R2LvG5+58e8StbW+QbqvwB5X+9YQRNzQbiOR02zH4bgBCC5in9+Bk2yl 3bcIAMWoBnMOENm1ASK9EF4NSqQqpVjfcPtETLhZpXe5r9RaAVjRWzYHr+uc7rbRzADk Ow7zEU89jk+n30mOTIDTIC1GuvAM03jMmi3XZRdcb9GIOFO+DuDQc+bFOQDUOiN8N+i9 UqGyfMiLC2SMkYRIyFnQYtO9ilF4i1YtLFy8PJSyFFSDo3u+QCHOwSj0mffMiXRI+fUR ay5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778593902; x=1779198702; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=efP/gQuqnkricRrytYVSBGCHteeZ5dbL25/u3O0HfuI=; b=Gc3Lhr840waziQOmj9lOuSwOCpz28rPvDF4Gw3M4XE7YRYNRtp6PxsOmAmANxJzLBg 94daDIXjQQ+8rTxERi3MqRyAtsqWPnlttIQCuFT9DYPMSBS5by1OvkYWpTucuzOFrMPK Td4A4LSgE4deI5wDXYEn1DLTrr8DFGLXEA0XOtmtoN6t+WbAdoR1L3MZxFAYrF4yfNwz WkpoiAMx/njxKM1MgxUk7YeyDRtCrH8jca0TkcaRvhdxvVQNoTCDO9jR5t2iT8r1+yQR 6dzcqw6A84or55K4YYULo5qrGjpR0LFTRm7IPSVe/bzfGwAMhQu5HnvHcBZ96yQvTdFi nt4A== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AFNElJ801GvjkYyKayy+tKRhsWPjyVoSjsRJ2oVZhF/dAU0I5v6gQ+veu0RYE0tRzArUDbXgoQWE@ilbers.de X-Gm-Message-State: AOJu0Yz9LeZdQyFWerQmBC9tPVdglZ5CPpt18/5BCeCemRFZeZzoQfsy izWf7yx3bkEAfog+vi6QnTO0Ttn7j9c3DypoTcl8UgWhZXFNDwjV79LE X-Received: by 2002:a5d:4bc6:0:b0:450:ad00:86aa with SMTP id ffacd0b85a97d-45ac2cf118dmr4722445f8f.15.1778593902056; Tue, 12 May 2026 06:51:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AUV6zMNSTComGac3OEQ+vMNH8tlwAmniieBgHv8OGf07f8XAIQ==" Received: by 2002:adf:efd2:0:b0:44b:6152:4d75 with SMTP id ffacd0b85a97d-45aaefacfd4ls384402f8f.0.-pod-prod-00-eu-canary; Tue, 12 May 2026 06:51:39 -0700 (PDT) X-Received: by 2002:a05:600c:8706:b0:48a:79d8:a8d6 with SMTP id 5b1f17b1804b1-48e8e207a4emr56661375e9.7.1778593899200; Tue, 12 May 2026 06:51:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778593899; cv=none; d=google.com; s=arc-20240605; b=Aq5INVWX+f1vQ/M2pMdrSSbFWQnPrHVyj6+t+x7TqxUlCTCbSjRAlO/JsFrxUcKISk 8eroofJl0cyqw0++dmz695Ei3c93Q4QAVTy3S6auJXy0/ePCdZalZuVM6L1i8+u2d1l9 KoULoIiIR6txuWUMe3C7WO6lUG/xmxVpuV8ueYBy/+sRTvsZ7KFdsIBtKJKsI/USyvzY QUO1WuQ6OUdSr3Qrw/2LasgfQAJFn1/Lfurcq+UoU1c8cFSh2bajsbA+Ek4S/u2gC+XR TMclCWr1lFkzO0vVcM1P2P5CqycMAMal01/mN/HviTfcckVspwofAG840ddUsFHXH5qc wHUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=t0Ye7fUhrMPtdR6Q74PqXBfl+dHmrgqfRD42+dRq6/w=; fh=SW1OBMASKXaVWsqy+A/8F/8cED0OSBaCA92wD7SJ8Ec=; b=HUWZ+mvboodZoARRIeoeiGpUzDxkXIRD9K2FJ5JQU+cIa/gJ6CWCdSpDre/6rcPT0c zgXnTsyisfea4D/Ed85N27OhE/+Te51A/KGqaXsZUHqH04Gzyv4/XidMyWbm1GVeK1li pUBQLANWCTTdwhjBgnSu69mAL6dCkpwEvUewxGU8XaU8kCy2VjZJ/w/APqDuHW0auBCX ZvhSFieACAn2yZiqGtxSuRnKYOZCmw+VRopmp+JKss0mGnisnCBCp5q7zxK1O+OYCr3S 0h6Mj1EBPm9yiiH+aX/VUdipYz1xU5in92InivQ+jHsr94+xNI19bOZ4h/BbNavCCDWJ 1F5g==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-48fc8ccfc1bsi3275e9.0.2026.05.12.06.51.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 May 2026 06:51:39 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 64CDpbWf006353 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 May 2026 15:51:38 +0200 Message-ID: <2b18650a-a913-4dfb-a7ad-aebc2d45bb7b@ilbers.de> Date: Tue, 12 May 2026 16:51:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] repository: default Priority to optional when field is absent To: isar-users@googlegroups.com, srinu References: <20260427100424.558898-1-srinuvasan.a@siemens.com> Content-Language: en-US, ru-RU From: Anton Mikanovich In-Reply-To: <20260427100424.558898-1-srinuvasan.a@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: amikan@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: qg/ojeL2kghI Hello Srinuvasan, 27.04.2026 13:04, srinuvasan.a via isar-users wrote: > From: Srinuvasan A > > Some upstream packages omit the Priority field from their binary .deb > metadata. reprepro rejects such packages with "No priority given", > aborting repository construction. > > This was observed with a base-apt build that include upstream packages > such as gir1.2-javascriptcoregtk-4.1. Both base-apt and isar-apt use > the repository class. Fix repo_add_packages() to detect a missing > Priority field and fall back to "optional", matching the Debian policy > default. > > Add a test recipe (test-nopriority) that explicitly strips the > Priority field before build, and a citest.py test case that exercises > the isar-apt repository path with this recipe, covering the same > failure mode as the base-apt case. > > Signed-off-by: Srinuvasan A > Signed-off-by: Cedric Hombourger > --- > .../test-nopriority/test-nopriority.bb | 10 ++++++++++ > meta/classes-recipe/repository.bbclass | 15 ++++++++++++--- > testsuite/citest.py | 10 ++++++++++ > 3 files changed, 32 insertions(+), 3 deletions(-) > create mode 100644 meta-test/recipes-app/test-nopriority/test-nopriority.bb > > diff --git a/meta-test/recipes-app/test-nopriority/test-nopriority.bb b/meta-test/recipes-app/test-nopriority/test-nopriority.bb > new file mode 100644 > index 00000000..dc06c112 > --- /dev/null > +++ b/meta-test/recipes-app/test-nopriority/test-nopriority.bb Can you also add copyright header with SPDX in new file? > @@ -0,0 +1,10 @@ > +# Test that a .deb without a Priority field can be added to the repository. > +# The debianize class sets Priority in the Source stanza of debian/control; > +# we strip it here so the resulting .deb has no Priority metadata, exercising > +# the prio_opt fallback in repository.bbclass. > + > +inherit dpkg-raw > + > +do_prepare_build:append() { > + sed -i '/^Priority:/d' ${S}/debian/control > +} > diff --git a/meta/classes-recipe/repository.bbclass b/meta/classes-recipe/repository.bbclass > index a5dd8bbc..ba2803ad 100644 > --- a/meta/classes-recipe/repository.bbclass > +++ b/meta/classes-recipe/repository.bbclass > @@ -61,14 +61,23 @@ repo_add_packages() { > local dir="$1" > local dbdir="$2" > local codename="$3" > + local package > + local priority > + local prio_opt > shift; shift; shift > > if [ -n "${GNUPGHOME}" ]; then > export GNUPGHOME="${GNUPGHOME}" > fi > - reprepro -b "${dir}" --dbdir "${dbdir}" -C main \ > - includedeb "${codename}" \ > - "$@" > + for package in "$@"; do > + prio_opt="" > + priority=$(dpkg-deb -f "${package}" Priority 2>/dev/null || true) > + if [ -z "${priority}" ]; then > + prio_opt="-P optional" > + fi > + reprepro -b "${dir}" --dbdir "${dbdir}" -C main ${prio_opt} \ > + includedeb "${codename}" "${package}" > + done > } > > repo_del_srcpackage() { > diff --git a/testsuite/citest.py b/testsuite/citest.py > index fc6ec24c..9fdb9fd7 100755 > --- a/testsuite/citest.py > +++ b/testsuite/citest.py > @@ -84,6 +84,16 @@ class DevTest(CIBaseTest): > self.init() > self.perform_build_test(targets) > > + def test_dev_nopriority(self): > + """Test that packages without a Priority field can be added to the repo.""" > + targets = [ > + 'mc:qemuamd64-bookworm:isar-image-ci', > + ] > + > + self.init() > + self.perform_build_test(targets, > + image_install='test-nopriority') > + > def test_dev_rebuild(self): > self.init() > layerdir_core = CIUtils.getVars('LAYERDIR_core') Do we really need this test case in "dev"? It supposed to be as minimal as possible, without adding any specific checks. So maybe this test case should be moved in "fast". -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/2b18650a-a913-4dfb-a7ad-aebc2d45bb7b%40ilbers.de.