From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221425893476925440 X-Received: by 2002:a05:6402:2787:b0:516:463d:8a10 with SMTP id b7-20020a056402278700b00516463d8a10mr11209935ede.3.1687353759300; Wed, 21 Jun 2023 06:22:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:d750:0:b0:50b:c3b9:c10a with SMTP id a16-20020aa7d750000000b0050bc3b9c10als1229116eds.0.-pod-prod-05-eu; Wed, 21 Jun 2023 06:22:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7hFoLNfj/DXoLpfw5cvO8AAW6g+9pByCdsPGC4STxDJvl45chZPl8TPp3o9okaBBHoN+EU X-Received: by 2002:aa7:c393:0:b0:51a:44b3:ab82 with SMTP id k19-20020aa7c393000000b0051a44b3ab82mr8339399edq.38.1687353757455; Wed, 21 Jun 2023 06:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687353757; cv=none; d=google.com; s=arc-20160816; b=Ry/+N8pXKVXat0QjPnntuM5cQn0LC6LLhjwNQWseG7f1VIVR9yI6A9q3CnYRKs1o2+ hT3jLc18TtnInk71JMIlBK5EY61t4lrBuWUbewBsVcf4/V1bkx+Du21eLNtN13+AtuGg Bh34qthMAyvxqhyg6Kxa+Sz8IUPTfluRS1hFFO+cvOVuA6op1psrD3lPIwENIgVzthBQ t9N1AhCGy4wWJ0FrCPHIuOYlZSjanpmbm180EQ7GBOHEYTDO548FG3eTj6St5KNxCuI/ tjIgZrA8JG/eFliYnO1IVmgbYBz8gcKo6S1z0ej+H0ChweEvkUef61xQU7xRgwKFmxUr elFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=dLItpDWmfa4zblIT2n6Ac5FmnAJHi2SuPgjAOXllbOI=; b=a7m3C4m0bQkjmsel+6wLNjHW+SvbGyZbD4r/QSjasVoWvMF8RqSB2HoN4qLXvpyhmx 1CAk/Gy+Q8osO7h+8NgVOtmXBdsxIlfnG41y+MVxDOFXumMdSORl8FIwDUaAR5K9V8g/ Us0oej6K9xkXFVx6MnV7QMjaFY6aXE5dE1GSaf9xrxS9O8jmlYOC80ivNrBEVO9v97Gq VEi28Peus8ohAt7UrmTfCSOVKslUxq34KrtOnBrpXgE3AlTT7xslF5xKIZV1OA1FuX3S YAU7imdeC69PgHMgodHlngiX7OySbBEMPH0MFmWcDYu2PZVgs4O3PR+sm1l+ATgycF9D Nw2w== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=ONxAYQEc; spf=pass (google.com: domain of fm-72506-2023062113223708cb10be853d3d540b-smqq_p@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-72506-2023062113223708cb10be853d3d540b-smQq_P@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-228.siemens.flowmailer.net (mta-65-228.siemens.flowmailer.net. [185.136.65.228]) by gmr-mx.google.com with ESMTPS id w20-20020aa7d294000000b0050bd0abf2b4si217011edq.3.2023.06.21.06.22.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2023 06:22:37 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-2023062113223708cb10be853d3d540b-smqq_p@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) client-ip=185.136.65.228; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=ONxAYQEc; spf=pass (google.com: domain of fm-72506-2023062113223708cb10be853d3d540b-smqq_p@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-72506-2023062113223708cb10be853d3d540b-smQq_P@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: by mta-65-228.siemens.flowmailer.net with ESMTPSA id 2023062113223708cb10be853d3d540b for ; Wed, 21 Jun 2023 15:22:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=dLItpDWmfa4zblIT2n6Ac5FmnAJHi2SuPgjAOXllbOI=; b=ONxAYQEcaRxXnHdmpck56KEKiwaGgsM6bXNdfVrR00JKgjT/0qTZWCnpJtfVCg7sBBDagu gqgeWoCazeGMLjDEI/lVK7zAFI1jQVmEOvBYauNq8dcRdZ3rJaJ5MrYSeDEeaqjmUllhsr9O cNbbj19SeKCVHFPiVbfqAPNo4Nw+Q=; Message-ID: <2b3438623ca390390b4c398117eb8362ca9cb89c.camel@siemens.com> Subject: Re: [PATCH 1/2] add support for derived sbuild chroots From: Moessbauer Felix To: Henning Schild , 'Jan Kiszka' via isar-users Cc: Jan Kiszka , Uladzimir Bely , Baurzhan Ismagulov Date: Wed, 21 Jun 2023 21:22:30 +0800 In-Reply-To: <20230621144230.2d63abad@md1za8fc.ad001.siemens.net> References: <20230413070026.3511123-1-felix.moessbauer@siemens.com> <902a5e9b613428bb7e7782ae6a5405b067c0333e.camel@ilbers.de> <05246f6a-cd48-60b2-766a-028db42100ea@siemens.com> <20230621144230.2d63abad@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: sNfYF6dt8JXz On Wed, 2023-06-21 at 14:42 +0200, Henning Schild wrote: > Am Mon, 19 Jun 2023 07:58:14 +0200 > schrieb "'Jan Kiszka' via isar-users" : >=20 > > On 13.06.23 08:24, Uladzimir Bely wrote: > > > On Thu, 2023-04-13 at 07:00 +0000, 'Felix Moessbauer' via isar- > > > users > > > wrote:=C2=A0=20 > > > > This patch adds support to create derived sbuild chroots to > > > > speedup > > > > the > > > > build process. For packages that share a large set of common > > > > build > > > > dependencies, a derived sbuild chroot can be created to avoid > > > > the > > > > overhead of installing all base build-deps on each sbuild > > > > invocation. > > > >=20 > > > > Signed-off-by: Felix Moessbauer > > > > --- > > > > =C2=A0doc/user_manual.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 27 > > > > +++++++++++++++++++ > > > > =C2=A0meta/classes/crossvars.bbclass=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 11 +++++--- > > > > =C2=A0.../sbuild-chroot/sbuild-chroot.inc=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 7 ++++- > > > > =C2=A03 files changed, 41 insertions(+), 4 deletions(-)=C2=A0=20 > > >=20 > > > We are going to merge this in near few days in spite of an open > > > question left in discussion. The reasons: > > >=20 > > > 1. It passes internal CI (dev/fast/full). > > >=20 > > > 2. It was useful in case of 'meta-iot2050' downstream for > > > rewriting > > > "npm.bbclass" in order not to use buildchroot.bbclass (that is > > > going to be deleted with "Imager schroot migration" patchset that > > > is to be merged soon too.=C2=A0=20 > >=20 > > To track what I discussed with Baurzhan offlist: I would be good to > > have some QA check running when using a derived sbuild chroot that > > the > > package built has all extra packages as part of its Build-Depends > > so > > that we are not create again silently broken debianizations. Any > > ideas > > how to achieve that best, considering also implicit inclusions of > > the > > Build-Depends? >=20 > As said by others that is kind of hard and the simplest would be a > double check in a "normal" sbuild where no extra packages are > installed. But i really do not see that as a big problem. Missing > build > deps are unfortunate but not a big deal for anyone to resolve quickly > ... should they ever surface because the build env for a given > code-base is ever brought on such a "minimal" build env. >=20 > In the past we shared a buildchroot and build order or parallel > builds > of packages with conflicting build-depends would cause sporadic > errors > that used to be hard to understand. Now nothing is shared ... if one > forgot a tool or library that is trivial to understand and fix. >=20 > IMHO not worth the effort. The feature is useful and the potential > problems rather harmless. >=20 > > Furthermore, I had a small comment on patch 2. >=20 > I kind of dislike that example but like the effort to put the new > feature under CI and present it with an example and test case to > begin > with. How about merging just this patch, but not the example? I currently cannot offer to provide a better example or CI integration. Sorry. If someone wants to implement it, feel free to send a patch. Felix >=20 > Henning > =C2=A0 > > Jan > >=20 >=20