From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6917993065941565440 X-Received: by 2002:a19:2d10:: with SMTP id k16mr1392371lfj.161.1611047490640; Tue, 19 Jan 2021 01:11:30 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:810b:: with SMTP id d11ls3169006ljg.11.gmail; Tue, 19 Jan 2021 01:11:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDw7QUdHE9tBMeVgChqLWNMiMoqKWTSZ/4RcEbM1p1qlIzcnnDW1+4GKbAbce1iUzK8MsU X-Received: by 2002:a05:651c:87:: with SMTP id 7mr1514748ljq.312.1611047489600; Tue, 19 Jan 2021 01:11:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611047489; cv=none; d=google.com; s=arc-20160816; b=vo0DxYH0TkNUcYTcqWmyZm90LT06ShOHDHsvHn/G2P2fO676h21dYjFqYxau+BbHVt 9mMAvyQ9eCye1cgAjC2u1oYzQIJaOZiOJTnNrdbms2MB6FBRMpMJdoM+Tabo1yiFRwZ8 Gz83saAuUs2V9yhYYArcvpuv61m+sbGRqcqp83s7xUV077dV7gcJFdxVs0YcMhRWOadd ZjvodN0upH9aQGsF7uDgVlRh9kvjFdnPJZRIYs/MIq1P2WkRB3DxPaUnYCoGpCLRTXEq 4+S9s6jNuBQ+3o6Wq6Tjl2lDxjh0MTE81kV0UlR4UjBETwEcWwzRINV7DL3lbFwTyCYV m9ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=3QpAGA7RUuSfQD79vAalzFUV4nVoG/AlQ9OC0jjdq3o=; b=O2ne6z6capq2g2UjDdBhVl92AZANmBNI8U8XJdRhDY16pvwe3Zfv642ouNM406rkKX co5RRxqWsvimKyc8l2dluzkgmk1WsM1+xuUu1sdUxk1ogJK1XRb8qbKf+Eg3d8KEHTW4 TSOfjjFhDjXrbxHP5O61Pri1VYv3Vd813nKAWN7Xt4IV0mqSUiO2RCt39RLEB9DDIiHp 8nFxpJHrMhOwI7S2OCFhGogv5u6tjhQC0j2pEZAaVHPPeK9e4xpUYtQZu1CpmT99T13s TEIgKQlGXOp3W3TtzKfVUx3RSsnM7JdOSrEnwhu/YoPMcuhcf5I5Mj6QnCGapiI6XlDN +Ptg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id 7si802923lfp.13.2021.01.19.01.11.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jan 2021 01:11:29 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DKjZT0HXqz1qvqv; Tue, 19 Jan 2021 10:11:29 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DKjZT05cPz1r75Q; Tue, 19 Jan 2021 10:11:29 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Acyole5Im5oL; Tue, 19 Jan 2021 10:11:27 +0100 (CET) X-Auth-Info: TQ0ED+qDi1j80Ao16AIBDzHJE6pjoC6zM+DfQNtzKWg= Received: from [10.88.0.186] (dslb-002-207-026-175.002.207.pools.vodafone-ip.de [2.207.26.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 19 Jan 2021 10:11:27 +0100 (CET) Subject: Re: image-postproc-extension.bbclass modifying /etc/os-release To: Silvano Cirujano Cuesta , isar-users@googlegroups.com References: <67e1fac9-5af5-29aa-de57-9a0de0cdd165@siemens.com> <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> From: Claudius Heine Organization: Denx Software Engineering Message-ID: <2b5ec879-e6bb-ae22-0f67-d015b9d4d224@denx.de> Date: Tue, 19 Jan 2021 10:11:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: LxETy+x4AeTe Hi Silvano, On 2021-01-18 12:35, Silvano Cirujano Cuesta wrote: > I might try to provide a fix, if we agree that the current implementation has an issue. > > @Claudius: you wrote the original code [1]. Do you remember why you implemented it this way? Do you remember if you were aware of the issue I mentioned and you provided a mitigation for the issue that I see (assuming my analysis is right)? > > [1] https://github.com/ilbers/isar/commit/13ce96e5bc84b60f2fa7ccfe93dde045461884e6 I now looked at the code, and in that commit I just copied the `update_etc_os_release` function to fit into the post processing framework. The original commit is actually [1], so Henning might have more insight into this than me. regards, Claudius [1] https://github.com/ilbers/isar/commit/2c99c8d2b821c493dfc4eab65ea0d205c992cd4d