Re: [PATCH 2/6] meta: Move 'do_fetch' and 'do_unpack' to base-class

[Alexander Smirnov <asmirnov@ilbers.de>]

On 09/04/2017 07:11 PM, Jan Kiszka wrote:
> On 2017-09-04 18:10, Alexander Smirnov wrote:
>> On 09/04/2017 07:03 PM, Jan Kiszka wrote:
>>> On 2017-09-04 17:14, Alexander Smirnov wrote:
>>>> On 08/30/2017 10:03 PM, Henning Schild wrote:
>>>>> Issues:
>>>>> unpack and fetch can only be used if you inherit dpkg, they should be
>>>>> available to others i.e. classes and images
>>>>
>>>> For me it's ok to move fetch to base class. Unpack has dependency from
>>>> dpkg class.
>>>>
>>>
>>> What is that dependency?
>>>
>>
>> Commented in previous patch.
> 
> The previous patch makes it generic, thus independent of dpkg. I cannot
> follow you, sorry.

Ok. Currently task unpack depends on dpkg class, because it uses 
BUILDROOT variable which is defined locally in dpkg.class. So the 
current task is also generic, and can be moved to base class but with 
BUILDROOT variable definition. Or BUILDROOT could be defined in 
bitbake.conf.

My concern about previous patch that it doesn't make task more generic - 
the content stays the same, but it changes the WORKDIR, what affects 
whole Isar design.

Alex