From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145516460113920 X-Received: by 10.28.55.209 with SMTP id e200mr130419wma.0.1504543152021; Mon, 04 Sep 2017 09:39:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.47.207 with SMTP id v198ls196016wmv.10.gmail; Mon, 04 Sep 2017 09:39:11 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7n7PF65rfux4LtEQR3HODXGKRkWVYsdZPrmT478yEo8egJN+4oyJ7ZaxWlT+ahbO2wkFh4 X-Received: by 10.28.23.200 with SMTP id 191mr131049wmx.25.1504543151619; Mon, 04 Sep 2017 09:39:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504543151; cv=none; d=google.com; s=arc-20160816; b=VRPFQz4xbkXG3Ohn9ZOufe+YPjVSw/TuP8WcXZpsEmduYo+VwDMN7tTxAAWcHeUeK6 DsQXN3oIJGxwG4AJpNtHmqmDlv/j2FL3Oqy3cfgvg5zhaB0Fx9F0x2lKPwRBqTnb9AkA xtqjhZQ+N6CsCziX54L3JcSypKVfLAffgXmR0RxENXtkwxScxFbprC4MLD+2h/b/ZsIR 3Z6blojhbGqSZDpKXz4EVtvU8uHjRXl10BdufSRQxpfoV3TIbsAGFncqmahVideBexvS XsXW3ZKnHRIfLyg8JT6FAObz0m+A4fOs6FLuiRFT++fOH1bsAPl73FY+vD8scuO4djeN /bmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=I/5uQp6VuDhPANM/aazQoozOay4tFX2vl49xuOXxXws=; b=PPAbN2eDxQCaTIbUZG03gb4Hm1BpV5IP+vomDKJ0ZuD3h+OU+v5+WIgnoStH15i98M Q9+g93SRf9alq1URIl3doGhiEq0AA2KJlkyfVOfbs8pWP9Y8vU6l0QVEAeT7aRPuKnlj Nrb+K5a8QQiTuogsfPN4GQ4LPD0jTfltuHL3rnwLyCRD1t4UC5+/j7OPyByJEm4mYfYE TS+ZGVykzn7qD0EC+OgETaLTWWywNH7W3BpTzr4LqnF+V6gq2xqddXyqdHwJ8rOWVZQM 6MGiiAR6V+/IYkTfHWFVgbTYKACqKNfcllV0ZDhMWyBP9e8SNOzynsQsw3/UPy1YYkKr nfhg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id b196si60047wmd.3.2017.09.04.09.39.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2017 09:39:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v84Gd83o009238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 4 Sep 2017 18:39:10 +0200 Subject: Re: [PATCH 2/6] meta: Move 'do_fetch' and 'do_unpack' to base-class To: Jan Kiszka , isar-users@googlegroups.com References: <1d3a315a8ac98ba02800168b6f8bc50d95a96bb4.1504119538.git.henning.schild@siemens.com> <70c40785-daa4-e186-5b00-1d6081d1c288@siemens.com> From: Alexander Smirnov Message-ID: <2bd3f3aa-2259-f074-adb6-87816b6a229a@ilbers.de> Date: Mon, 4 Sep 2017 19:39:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: zcIdPEl7V3D/ On 09/04/2017 07:11 PM, Jan Kiszka wrote: > On 2017-09-04 18:10, Alexander Smirnov wrote: >> On 09/04/2017 07:03 PM, Jan Kiszka wrote: >>> On 2017-09-04 17:14, Alexander Smirnov wrote: >>>> On 08/30/2017 10:03 PM, Henning Schild wrote: >>>>> Issues: >>>>> unpack and fetch can only be used if you inherit dpkg, they should be >>>>> available to others i.e. classes and images >>>> >>>> For me it's ok to move fetch to base class. Unpack has dependency from >>>> dpkg class. >>>> >>> >>> What is that dependency? >>> >> >> Commented in previous patch. > > The previous patch makes it generic, thus independent of dpkg. I cannot > follow you, sorry. Ok. Currently task unpack depends on dpkg class, because it uses BUILDROOT variable which is defined locally in dpkg.class. So the current task is also generic, and can be moved to base class but with BUILDROOT variable definition. Or BUILDROOT could be defined in bitbake.conf. My concern about previous patch that it doesn't make task more generic - the content stays the same, but it changes the WORKDIR, what affects whole Isar design. Alex