public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Cc: Quirin Gylstorff <quirin.gylstorff@siemens.com>
Subject: Re: [PATCH] classes/image-postproc: Fix unchangeable VARIAN_VERSION value
Date: Sun, 27 Apr 2025 19:46:02 +0200	[thread overview]
Message-ID: <2be15008-46de-4837-8421-fbb3e81c68f3@siemens.com> (raw)
In-Reply-To: <20250426114211.69284-1-amikan@ilbers.de>

On 26.04.25 13:42, Anton Mikanovich wrote:
> During custom /etc/os-release generation in update_etc_os_release()
> VARIAN_VERSION was set to PV without taking in account --version option

"VARIANT" - here and in the title.

Jan

> provided from outside.
> 
> Fixes: 78b24427a050 ("classes/image-postproc: Add image version")
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/image-postproc-extension.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image-postproc-extension.bbclass b/meta/classes/image-postproc-extension.bbclass
> index f7f762c4..991bac4c 100644
> --- a/meta/classes/image-postproc-extension.bbclass
> +++ b/meta/classes/image-postproc-extension.bbclass
> @@ -28,7 +28,7 @@ update_etc_os_release() {
>      fi
>      if [ -n "${OS_RELEASE_VARIANT_VERSION}" ]; then
>          sudo sed -i '/^VARIANT_VERSION=.*/d' '${IMAGE_ROOTFS}/etc/os-release'
> -        echo "VARIANT_VERSION=\"${PV}\"" | \
> +        echo "VARIANT_VERSION=\"${OS_RELEASE_VARIANT_VERSION}\"" | \
>              sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
>      fi
>  }

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/2be15008-46de-4837-8421-fbb3e81c68f3%40siemens.com.

  reply	other threads:[~2025-04-27 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-26 11:42 Anton Mikanovich
2025-04-27 17:46 ` 'Jan Kiszka' via isar-users [this message]
2025-04-28  6:11   ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2be15008-46de-4837-8421-fbb3e81c68f3@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox