[PATCH] classes/image-postproc: Fix unchangeable VARIAN_VERSION value

[PATCH] classes/image-postproc: Fix unchangeable VARIAN_VERSION value

[Anton Mikanovich]

During custom /etc/os-release generation in update_etc_os_release()
VARIAN_VERSION was set to PV without taking in account --version option
provided from outside.

Fixes: 78b24427a050 ("classes/image-postproc: Add image version")

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/image-postproc-extension.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image-postproc-extension.bbclass b/meta/classes/image-postproc-extension.bbclass
index f7f762c4..991bac4c 100644
--- a/meta/classes/image-postproc-extension.bbclass
+++ b/meta/classes/image-postproc-extension.bbclass
@@ -28,7 +28,7 @@ update_etc_os_release() {
     fi
     if [ -n "${OS_RELEASE_VARIANT_VERSION}" ]; then
         sudo sed -i '/^VARIANT_VERSION=.*/d' '${IMAGE_ROOTFS}/etc/os-release'
-        echo "VARIANT_VERSION=\"${PV}\"" | \
+        echo "VARIANT_VERSION=\"${OS_RELEASE_VARIANT_VERSION}\"" | \
             sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
     fi
 }
-- 
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250426114211.69284-1-amikan%40ilbers.de.

Re: [PATCH] classes/image-postproc: Fix unchangeable VARIAN_VERSION value

['Jan Kiszka' via isar-users]

On 26.04.25 13:42, Anton Mikanovich wrote:
> During custom /etc/os-release generation in update_etc_os_release()
> VARIAN_VERSION was set to PV without taking in account --version option

"VARIANT" - here and in the title.

Jan

> provided from outside.
> 
> Fixes: 78b24427a050 ("classes/image-postproc: Add image version")
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/image-postproc-extension.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image-postproc-extension.bbclass b/meta/classes/image-postproc-extension.bbclass
> index f7f762c4..991bac4c 100644
> --- a/meta/classes/image-postproc-extension.bbclass
> +++ b/meta/classes/image-postproc-extension.bbclass
> @@ -28,7 +28,7 @@ update_etc_os_release() {
>      fi
>      if [ -n "${OS_RELEASE_VARIANT_VERSION}" ]; then
>          sudo sed -i '/^VARIANT_VERSION=.*/d' '${IMAGE_ROOTFS}/etc/os-release'
> -        echo "VARIANT_VERSION=\"${PV}\"" | \
> +        echo "VARIANT_VERSION=\"${OS_RELEASE_VARIANT_VERSION}\"" | \
>              sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
>      fi
>  }

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/2be15008-46de-4837-8421-fbb3e81c68f3%40siemens.com.

Re: [PATCH] classes/image-postproc: Fix unchangeable VARIAN_VERSION value

[Anton Mikanovich]

27/04/2025 20:46, Jan Kiszka wrote:
> On 26.04.25 13:42, Anton Mikanovich wrote:
>> During custom /etc/os-release generation in update_etc_os_release()
>> VARIAN_VERSION was set to PV without taking in account --version option
> "VARIANT" - here and in the title.
>
> Jan

Thanks, will fix during the merge if no other changes needed.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/6cc1f88c-c1f7-4b78-945a-45164b61ac1b%40ilbers.de.